From 786dea207d5b891d37e596e96dd2f84c4cb59f49 Mon Sep 17 00:00:00 2001 From: Patrick Walton Date: Tue, 3 Dec 2013 16:44:16 -0800 Subject: libextra: Another round of de-`Cell`-ing. 34 uses of `Cell` remain. --- src/librustdoc/lib.rs | 11 +++++------ src/librustdoc/passes.rs | 9 +++------ 2 files changed, 8 insertions(+), 12 deletions(-) (limited to 'src/librustdoc') diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs index 39e2b908b50..9edb80d8e74 100644 --- a/src/librustdoc/lib.rs +++ b/src/librustdoc/lib.rs @@ -24,7 +24,6 @@ extern mod syntax; extern mod rustc; extern mod extra; -use std::cell::Cell; use std::local_data; use std::io; use std::io::File; @@ -194,13 +193,13 @@ fn rust_input(cratefile: &str, matches: &getopts::Matches) -> Output { let mut plugins = matches.opt_strs("plugins"); // First, parse the crate and extract all relevant information. - let libs = Cell::new(matches.opt_strs("L").map(|s| Path::new(s.as_slice()))); - let cfgs = Cell::new(matches.opt_strs("cfg")); - let cr = Cell::new(Path::new(cratefile)); + let libs = matches.opt_strs("L").map(|s| Path::new(s.as_slice())); + let cfgs = matches.opt_strs("cfg"); + let cr = Path::new(cratefile); info!("starting to run rustc"); let (crate, analysis) = do std::task::try { - let cr = cr.take(); - core::run_core(libs.take().move_iter().collect(), cfgs.take(), &cr) + let cr = cr; + core::run_core(libs.move_iter().collect(), cfgs, &cr) }.unwrap(); info!("finished with rustc"); local_data::set(analysiskey, analysis); diff --git a/src/librustdoc/passes.rs b/src/librustdoc/passes.rs index 6f469ba6fff..1ca9fb1e98c 100644 --- a/src/librustdoc/passes.rs +++ b/src/librustdoc/passes.rs @@ -8,12 +8,10 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -use std::num; -use std::cell::Cell; -use std::uint; use std::hashmap::HashSet; use std::local_data; - +use std::num; +use std::uint; use syntax::ast; use clean; @@ -56,11 +54,10 @@ pub fn strip_hidden(crate: clean::Crate) -> plugins::PluginResult { pub fn strip_private(crate: clean::Crate) -> plugins::PluginResult { // This stripper collects all *retained* nodes. let mut retained = HashSet::new(); - let crate = Cell::new(crate); let exported_items = local_data::get(super::analysiskey, |analysis| { analysis.unwrap().exported_items.clone() }); - let mut crate = crate.take(); + let mut crate = crate; // strip all private items { -- cgit 1.4.1-3-g733a5