From 4e1c2158f29fbb6c2bdb4d50f1fdc6a30685bc3c Mon Sep 17 00:00:00 2001 From: Daniel Micay Date: Sat, 8 Mar 2014 01:10:32 -0500 Subject: cmp: switch `min` and `max` to `TotalOrd` The `Float` trait provides correct `min` and `max` methods on floating point types, providing a consistent result regardless of the order the parameters are passed. These generic functions do not take the necessary performance hit to correctly support a partial order, so the true requirement should be given as a type bound. Closes #12712 --- src/libstd/cmp.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/libstd/cmp.rs') diff --git a/src/libstd/cmp.rs b/src/libstd/cmp.rs index 6975c9da3f0..023b2028703 100644 --- a/src/libstd/cmp.rs +++ b/src/libstd/cmp.rs @@ -184,12 +184,12 @@ pub trait Equiv { } #[inline] -pub fn min(v1: T, v2: T) -> T { +pub fn min(v1: T, v2: T) -> T { if v1 < v2 { v1 } else { v2 } } #[inline] -pub fn max(v1: T, v2: T) -> T { +pub fn max(v1: T, v2: T) -> T { if v1 > v2 { v1 } else { v2 } } -- cgit 1.4.1-3-g733a5