From 7bb498bd7a09f024fe46fc58ea17fe44cbc68df0 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Wed, 19 Feb 2014 10:07:49 -0800 Subject: Mass rename if_ok! to try! This "bubble up an error" macro was originally named if_ok! in order to get it landed, but after the fact it was discovered that this name is not exactly desirable. The name `if_ok!` isn't immediately clear that is has much to do with error handling, and it doesn't look fantastic in all contexts (if if_ok!(...) {}). In general, the agreed opinion about `if_ok!` is that is came in as subpar. The name `try!` is more invocative of error handling, it's shorter by 2 letters, and it looks fitting in almost all circumstances. One concern about the word `try!` is that it's too invocative of exceptions, but the belief is that this will be overcome with documentation and examples. Close #12037 --- src/libstd/hashmap.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/libstd/hashmap.rs') diff --git a/src/libstd/hashmap.rs b/src/libstd/hashmap.rs index 1ac599d0654..5d4db106728 100644 --- a/src/libstd/hashmap.rs +++ b/src/libstd/hashmap.rs @@ -599,15 +599,15 @@ impl Clone for HashMap { impl fmt::Show for HashMap { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - if_ok!(write!(f.buf, r"\{")) + try!(write!(f.buf, r"\{")) let mut first = true; for (key, value) in self.iter() { if first { first = false; } else { - if_ok!(write!(f.buf, ", ")); + try!(write!(f.buf, ", ")); } - if_ok!(write!(f.buf, "{}: {}", *key, *value)); + try!(write!(f.buf, "{}: {}", *key, *value)); } write!(f.buf, r"\}") } @@ -877,15 +877,15 @@ impl Clone for HashSet { impl fmt::Show for HashSet { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - if_ok!(write!(f.buf, r"\{")) + try!(write!(f.buf, r"\{")) let mut first = true; for x in self.iter() { if first { first = false; } else { - if_ok!(write!(f.buf, ", ")); + try!(write!(f.buf, ", ")); } - if_ok!(write!(f.buf, "{}", *x)); + try!(write!(f.buf, "{}", *x)); } write!(f.buf, r"\}") } -- cgit 1.4.1-3-g733a5