From 435ca16f4fa7bd47c16de693054be5cba5fd4ebb Mon Sep 17 00:00:00 2001 From: Steven Fackler Date: Thu, 3 Oct 2013 00:15:54 -0700 Subject: Close out #9155 Add a test to make sure it works and switch a private struct over to a newtype. Closes #9155 --- src/libstd/rt/io/buffered.rs | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) (limited to 'src/libstd/rt') diff --git a/src/libstd/rt/io/buffered.rs b/src/libstd/rt/io/buffered.rs index 3e801f28991..a8cf8151499 100644 --- a/src/libstd/rt/io/buffered.rs +++ b/src/libstd/rt/io/buffered.rs @@ -187,25 +187,21 @@ impl Decorator for BufferedWriter { } } -// FIXME #9155 this should be a newtype struct -struct InternalBufferedWriter { - inner: BufferedWriter -} +struct InternalBufferedWriter(BufferedWriter); impl Reader for InternalBufferedWriter { fn read(&mut self, buf: &mut [u8]) -> Option { - self.inner.inner.read(buf) + self.inner.read(buf) } fn eof(&mut self) -> bool { - self.inner.inner.eof() + self.inner.eof() } } /// Wraps a Stream and buffers input and output to and from it /// /// Note that `BufferedStream` will NOT flush its output buffer when dropped. -// FIXME #9155 this should be a newtype struct pub struct BufferedStream { priv inner: BufferedReader> } @@ -214,7 +210,7 @@ impl BufferedStream { pub fn with_capacities(reader_cap: uint, writer_cap: uint, inner: S) -> BufferedStream { let writer = BufferedWriter::with_capacity(writer_cap, inner); - let internal_writer = InternalBufferedWriter { inner: writer }; + let internal_writer = InternalBufferedWriter(writer); let reader = BufferedReader::with_capacity(reader_cap, internal_writer); BufferedStream { inner: reader } @@ -238,25 +234,25 @@ impl Reader for BufferedStream { impl Writer for BufferedStream { fn write(&mut self, buf: &[u8]) { - self.inner.inner.inner.write(buf) + self.inner.inner.write(buf) } fn flush(&mut self) { - self.inner.inner.inner.flush() + self.inner.inner.flush() } } impl Decorator for BufferedStream { fn inner(self) -> S { - self.inner.inner.inner.inner() + self.inner.inner.inner() } fn inner_ref<'a>(&'a self) -> &'a S { - self.inner.inner.inner.inner_ref() + self.inner.inner.inner_ref() } fn inner_mut_ref<'a>(&'a mut self) -> &'a mut S { - self.inner.inner.inner.inner_mut_ref() + self.inner.inner.inner_mut_ref() } } -- cgit 1.4.1-3-g733a5