From cc61fc09945aeec6fc71a07e91b8610fa71f6425 Mon Sep 17 00:00:00 2001 From: Salem Talha Date: Sun, 26 Jan 2014 03:43:42 -0500 Subject: Removed all instances of XXX in preparation for relaxing of FIXME rule --- src/libstd/rt/crate_map.rs | 2 +- src/libstd/rt/local_heap.rs | 4 ++-- src/libstd/rt/mod.rs | 8 ++++---- src/libstd/rt/rtio.rs | 4 ++-- src/libstd/rt/task.rs | 2 +- src/libstd/rt/util.rs | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) (limited to 'src/libstd/rt') diff --git a/src/libstd/rt/crate_map.rs b/src/libstd/rt/crate_map.rs index 6ea12659e77..8567f0e0251 100644 --- a/src/libstd/rt/crate_map.rs +++ b/src/libstd/rt/crate_map.rs @@ -108,7 +108,7 @@ fn do_iter_crate_map<'a>( /// Iterates recursively over `crate_map` and all child crate maps pub fn iter_crate_map<'a>(crate_map: &'a CrateMap<'a>, f: |&ModEntry|) { - // XXX: use random numbers as keys from the OS-level RNG when there is a nice + // FIXME: use random numbers as keys from the OS-level RNG when there is a nice // way to do this let mut v: HashSet<*CrateMap<'a>> = HashSet::with_capacity_and_keys(0, 0, 32); do_iter_crate_map(crate_map, f, &mut v); diff --git a/src/libstd/rt/local_heap.rs b/src/libstd/rt/local_heap.rs index 36e3bf858e3..42a7e7867f9 100644 --- a/src/libstd/rt/local_heap.rs +++ b/src/libstd/rt/local_heap.rs @@ -293,7 +293,7 @@ impl Drop for MemoryRegion { #[inline] pub unsafe fn local_malloc(td: *u8, size: uint) -> *u8 { - // XXX: Unsafe borrow for speed. Lame. + // FIXME: Unsafe borrow for speed. Lame. let task: Option<*mut Task> = Local::try_unsafe_borrow(); match task { Some(task) => { @@ -306,7 +306,7 @@ pub unsafe fn local_malloc(td: *u8, size: uint) -> *u8 { // A little compatibility function #[inline] pub unsafe fn local_free(ptr: *u8) { - // XXX: Unsafe borrow for speed. Lame. + // FIXME: Unsafe borrow for speed. Lame. let task_ptr: Option<*mut Task> = Local::try_unsafe_borrow(); match task_ptr { Some(task) => { diff --git a/src/libstd/rt/mod.rs b/src/libstd/rt/mod.rs index 9088ee6898b..56f6c8f8e6c 100644 --- a/src/libstd/rt/mod.rs +++ b/src/libstd/rt/mod.rs @@ -52,7 +52,7 @@ Several modules in `core` are clients of `rt`: */ -// XXX: this should not be here. +// FIXME: this should not be here. #[allow(missing_doc)]; use any::Any; @@ -71,7 +71,7 @@ pub use self::util::default_sched_threads; // Export unwinding facilities used by the failure macros pub use self::unwind::{begin_unwind, begin_unwind_raw}; -// XXX: these probably shouldn't be public... +// FIXME: these probably shouldn't be public... #[doc(hidden)] pub mod shouldnt_be_public { pub use super::local_ptr::native::maybe_tls_key; @@ -155,7 +155,7 @@ pub trait Runtime { /// The (low, high) edges of the current stack. fn stack_bounds(&self) -> (uint, uint); // (lo, hi) - // XXX: This is a serious code smell and this should not exist at all. + // FIXME: This is a serious code smell and this should not exist at all. fn wrap(~self) -> ~Any; } @@ -165,7 +165,7 @@ pub trait Runtime { /// the crate's logging flags, registering GC /// metadata, and storing the process arguments. pub fn init(argc: int, argv: **u8) { - // XXX: Derefing these pointers is not safe. + // FIXME: Derefing these pointers is not safe. // Need to propagate the unsafety to `start`. unsafe { args::init(argc, argv); diff --git a/src/libstd/rt/rtio.rs b/src/libstd/rt/rtio.rs index 6b3d50a76ac..455a84b4ce3 100644 --- a/src/libstd/rt/rtio.rs +++ b/src/libstd/rt/rtio.rs @@ -86,7 +86,7 @@ pub struct LocalIo<'a> { #[unsafe_destructor] impl<'a> Drop for LocalIo<'a> { fn drop(&mut self) { - // XXX(pcwalton): Do nothing here for now, but eventually we may want + // FIXME(pcwalton): Do nothing here for now, but eventually we may want // something. For now this serves to make `LocalIo` noncopyable. } } @@ -143,7 +143,7 @@ impl<'a> LocalIo<'a> { /// Returns the underlying I/O factory as a trait reference. #[inline] pub fn get<'a>(&'a mut self) -> &'a mut IoFactory { - // XXX(pcwalton): I think this is actually sound? Could borrow check + // FIXME(pcwalton): I think this is actually sound? Could borrow check // allow this safely? unsafe { cast::transmute_copy(&self.factory) diff --git a/src/libstd/rt/task.rs b/src/libstd/rt/task.rs index e63208bcaec..e99e7fa4edd 100644 --- a/src/libstd/rt/task.rs +++ b/src/libstd/rt/task.rs @@ -212,7 +212,7 @@ impl Task { // pretty sketchy and involves shuffling vtables of trait objects // around, but it gets the job done. // - // XXX: This function is a serious code smell and should be avoided at + // FIXME: This function is a serious code smell and should be avoided at // all costs. I have yet to think of a method to avoid this // function, and I would be saddened if more usage of the function // crops up. diff --git a/src/libstd/rt/util.rs b/src/libstd/rt/util.rs index b482e2fb67f..9c17c624987 100644 --- a/src/libstd/rt/util.rs +++ b/src/libstd/rt/util.rs @@ -20,7 +20,7 @@ use unstable::running_on_valgrind; use vec::ImmutableVector; // Indicates whether we should perform expensive sanity checks, including rtassert! -// XXX: Once the runtime matures remove the `true` below to turn off rtassert, etc. +// FIXME: Once the runtime matures remove the `true` below to turn off rtassert, etc. pub static ENFORCE_SANITY: bool = true || !cfg!(rtopt) || cfg!(rtdebug) || cfg!(rtassert); /// Get the number of cores available -- cgit 1.4.1-3-g733a5