From dc9b3ff1b30c10aaf60d40fd9845d9bf69ae2c2e Mon Sep 17 00:00:00 2001 From: Kevin Ballard Date: Tue, 2 Jul 2013 18:40:46 -0700 Subject: Change signature of Iterator.size_hint Remove the Option wrapper around the lower bound. None is semantically the same as Size(0), so there's no point in having a distinction. --- src/libstd/vec.rs | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) (limited to 'src/libstd/vec.rs') diff --git a/src/libstd/vec.rs b/src/libstd/vec.rs index 1014ff48b1d..7244a9a7aac 100644 --- a/src/libstd/vec.rs +++ b/src/libstd/vec.rs @@ -2024,14 +2024,14 @@ macro_rules! iterator { } #[inline] - fn size_hint(&self) -> (Option, Option) { + fn size_hint(&self) -> (uint, Option) { let diff = if $step > 0 { (self.end as uint) - (self.ptr as uint) } else { (self.ptr as uint) - (self.end as uint) }; - let exact = Some(diff / size_of::<$elem>()); - (exact, exact) + let exact = diff / size_of::<$elem>(); + (exact, Some(exact)) } } } @@ -2132,7 +2132,7 @@ impl> FromIterator for ~[A] { impl> FromIterator for ~[A] { pub fn from_iterator(iterator: &mut T) -> ~[A] { let (lower, _) = iterator.size_hint(); - let mut xs = with_capacity(lower.get_or_zero()); + let mut xs = with_capacity(lower); for iterator.advance |x| { xs.push(x); } @@ -2968,17 +2968,17 @@ mod tests { use iterator::*; let xs = [1, 2, 5, 10, 11]; let mut it = xs.iter(); - assert_eq!(it.size_hint(), (Some(5), Some(5))); + assert_eq!(it.size_hint(), (5, Some(5))); assert_eq!(it.next().unwrap(), &1); - assert_eq!(it.size_hint(), (Some(4), Some(4))); + assert_eq!(it.size_hint(), (4, Some(4))); assert_eq!(it.next().unwrap(), &2); - assert_eq!(it.size_hint(), (Some(3), Some(3))); + assert_eq!(it.size_hint(), (3, Some(3))); assert_eq!(it.next().unwrap(), &5); - assert_eq!(it.size_hint(), (Some(2), Some(2))); + assert_eq!(it.size_hint(), (2, Some(2))); assert_eq!(it.next().unwrap(), &10); - assert_eq!(it.size_hint(), (Some(1), Some(1))); + assert_eq!(it.size_hint(), (1, Some(1))); assert_eq!(it.next().unwrap(), &11); - assert_eq!(it.size_hint(), (Some(0), Some(0))); + assert_eq!(it.size_hint(), (0, Some(0))); assert!(it.next().is_none()); } @@ -2986,10 +2986,10 @@ mod tests { fn test_iter_size_hints() { use iterator::*; let mut xs = [1, 2, 5, 10, 11]; - assert_eq!(xs.iter().size_hint(), (Some(5), Some(5))); - assert_eq!(xs.rev_iter().size_hint(), (Some(5), Some(5))); - assert_eq!(xs.mut_iter().size_hint(), (Some(5), Some(5))); - assert_eq!(xs.mut_rev_iter().size_hint(), (Some(5), Some(5))); + assert_eq!(xs.iter().size_hint(), (5, Some(5))); + assert_eq!(xs.rev_iter().size_hint(), (5, Some(5))); + assert_eq!(xs.mut_iter().size_hint(), (5, Some(5))); + assert_eq!(xs.mut_rev_iter().size_hint(), (5, Some(5))); } #[test] -- cgit 1.4.1-3-g733a5