From 5972b22b7cdf2c4de2729ee874c1742a4ae97589 Mon Sep 17 00:00:00 2001 From: Corey Farwell Date: Wed, 30 Mar 2016 09:26:34 -0400 Subject: Implement `values_mut` on `HashMap`. https://github.com/rust-lang/rust/issues/32551 --- src/libstd/collections/hash/map.rs | 61 ++++++++++++++++++++++++++++++++++++++ src/libstd/lib.rs | 1 + 2 files changed, 62 insertions(+) (limited to 'src/libstd') diff --git a/src/libstd/collections/hash/map.rs b/src/libstd/collections/hash/map.rs index 80b5448800e..4c29023660a 100644 --- a/src/libstd/collections/hash/map.rs +++ b/src/libstd/collections/hash/map.rs @@ -861,6 +861,34 @@ impl HashMap Values { inner: self.iter() } } + /// An iterator visiting all values mutably in arbitrary order. + /// Iterator element type is `&'a mut V`. + /// + /// # Examples + /// + /// ``` + /// # #![feature(map_values_mut)] + /// use std::collections::HashMap; + /// + /// let mut map = HashMap::new(); + /// + /// map.insert("a", 1); + /// map.insert("b", 2); + /// map.insert("c", 3); + /// + /// for val in map.values_mut() { + /// *val = *val + 10; + /// } + /// + /// for val in map.values() { + /// print!("{}", val); + /// } + /// ``` + #[unstable(feature = "map_values_mut", reason = "recently added", issue = "32551")] + pub fn values_mut<'a>(&'a mut self) -> ValuesMut<'a, K, V> { + ValuesMut { inner: self.iter_mut() } + } + /// An iterator visiting all key-value pairs in arbitrary order. /// Iterator element type is `(&'a K, &'a V)`. /// @@ -1262,6 +1290,12 @@ pub struct Drain<'a, K: 'a, V: 'a> { inner: table::Drain<'a, K, V> } +/// Mutable HashMap values iterator. +#[unstable(feature = "map_values_mut", reason = "recently added", issue = "32551")] +pub struct ValuesMut<'a, K: 'a, V: 'a> { + inner: IterMut<'a, K, V> +} + enum InternalEntry { Occupied { elem: FullBucket, @@ -1460,6 +1494,18 @@ impl<'a, K, V> ExactSizeIterator for Values<'a, K, V> { #[inline] fn len(&self) -> usize { self.inner.len() } } +#[unstable(feature = "map_values_mut", reason = "recently added", issue = "32551")] +impl<'a, K, V> Iterator for ValuesMut<'a, K, V> { + type Item = &'a mut V; + + #[inline] fn next(&mut self) -> Option<(&'a mut V)> { self.inner.next().map(|(_, v)| v) } + #[inline] fn size_hint(&self) -> (usize, Option) { self.inner.size_hint() } +} +#[unstable(feature = "map_values_mut", reason = "recently added", issue = "32551")] +impl<'a, K, V> ExactSizeIterator for ValuesMut<'a, K, V> { + #[inline] fn len(&self) -> usize { self.inner.len() } +} + #[stable(feature = "rust1", since = "1.0.0")] impl<'a, K, V> Iterator for Drain<'a, K, V> { type Item = (K, V); @@ -1907,6 +1953,7 @@ mod test_map { assert_eq!(m.drain().next(), None); assert_eq!(m.keys().next(), None); assert_eq!(m.values().next(), None); + assert_eq!(m.values_mut().next(), None); assert_eq!(m.iter().next(), None); assert_eq!(m.iter_mut().next(), None); assert_eq!(m.len(), 0); @@ -2083,6 +2130,20 @@ mod test_map { assert!(values.contains(&'c')); } + #[test] + fn test_values_mut() { + let vec = vec![(1, 1), (2, 2), (3, 3)]; + let mut map: HashMap<_, _> = vec.into_iter().collect(); + for value in map.values_mut() { + *value = (*value) * 2 + } + let values: Vec<_> = map.values().cloned().collect(); + assert_eq!(values.len(), 3); + assert!(values.contains(&2)); + assert!(values.contains(&4)); + assert!(values.contains(&6)); + } + #[test] fn test_find() { let mut m = HashMap::new(); diff --git a/src/libstd/lib.rs b/src/libstd/lib.rs index f7b1042592d..8dcac514172 100644 --- a/src/libstd/lib.rs +++ b/src/libstd/lib.rs @@ -241,6 +241,7 @@ #![feature(link_args)] #![feature(linkage)] #![feature(macro_reexport)] +#![cfg_attr(test, feature(map_values_mut))] #![feature(num_bits_bytes)] #![feature(old_wrapping)] #![feature(on_unimplemented)] -- cgit 1.4.1-3-g733a5