From 3fd8c8b3306ae33bdc85811aa410ba01967922bc Mon Sep 17 00:00:00 2001
From: Palmer Cox
Date: Tue, 14 Jan 2014 22:32:24 -0500
Subject: Rename iterators for consistency
Rename existing iterators to get rid of the Iterator suffix and to
give them names that better describe the things being iterated over.
---
src/libstd/c_str.rs | 8 +--
src/libstd/comm/mod.rs | 8 +--
src/libstd/comm/select.rs | 6 +-
src/libstd/fmt/mod.rs | 2 +-
src/libstd/fmt/parse.rs | 2 +-
src/libstd/hashmap.rs | 74 ++++++++++-----------
src/libstd/io/extensions.rs | 12 ++--
src/libstd/io/fs.rs | 8 +--
src/libstd/io/mod.rs | 22 +++----
src/libstd/option.rs | 24 +++----
src/libstd/path/mod.rs | 16 ++---
src/libstd/path/posix.rs | 22 +++----
src/libstd/path/windows.rs | 26 ++++----
src/libstd/rt/task.rs | 8 +--
src/libstd/str.rs | 156 ++++++++++++++++++++++----------------------
src/libstd/trie.rs | 54 +++++++--------
src/libstd/vec.rs | 142 ++++++++++++++++++++--------------------
17 files changed, 295 insertions(+), 295 deletions(-)
(limited to 'src/libstd')
diff --git a/src/libstd/c_str.rs b/src/libstd/c_str.rs
index b924378a0e7..301df329f49 100644
--- a/src/libstd/c_str.rs
+++ b/src/libstd/c_str.rs
@@ -171,8 +171,8 @@ impl CString {
}
/// Return a CString iterator.
- pub fn iter<'a>(&'a self) -> CStringIterator<'a> {
- CStringIterator {
+ pub fn iter<'a>(&'a self) -> CChars<'a> {
+ CChars {
ptr: self.buf,
lifetime: unsafe { cast::transmute(self.buf) },
}
@@ -330,12 +330,12 @@ fn check_for_null(v: &[u8], buf: *mut libc::c_char) {
/// External iterator for a CString's bytes.
///
/// Use with the `std::iter` module.
-pub struct CStringIterator<'a> {
+pub struct CChars<'a> {
priv ptr: *libc::c_char,
priv lifetime: &'a libc::c_char, // FIXME: #5922
}
-impl<'a> Iterator for CStringIterator<'a> {
+impl<'a> Iterator for CChars<'a> {
fn next(&mut self) -> Option {
let ch = unsafe { *self.ptr };
if ch == 0 {
diff --git a/src/libstd/comm/mod.rs b/src/libstd/comm/mod.rs
index 985a387ee2b..26d67daf7c1 100644
--- a/src/libstd/comm/mod.rs
+++ b/src/libstd/comm/mod.rs
@@ -305,7 +305,7 @@ pub struct Port {
/// An iterator over messages received on a port, this iterator will block
/// whenever `next` is called, waiting for a new message, and `None` will be
/// returned when the corresponding channel has hung up.
-pub struct PortIterator<'a, T> {
+pub struct Messages<'a, T> {
priv port: &'a Port
}
@@ -899,12 +899,12 @@ impl Port {
/// Returns an iterator which will block waiting for messages, but never
/// `fail!`. It will return `None` when the channel has hung up.
- pub fn iter<'a>(&'a self) -> PortIterator<'a, T> {
- PortIterator { port: self }
+ pub fn iter<'a>(&'a self) -> Messages<'a, T> {
+ Messages { port: self }
}
}
-impl<'a, T: Send> Iterator for PortIterator<'a, T> {
+impl<'a, T: Send> Iterator for Messages<'a, T> {
fn next(&mut self) -> Option { self.port.recv_opt() }
}
diff --git a/src/libstd/comm/select.rs b/src/libstd/comm/select.rs
index fa5ec1d3e30..6a10ac56a4e 100644
--- a/src/libstd/comm/select.rs
+++ b/src/libstd/comm/select.rs
@@ -94,7 +94,7 @@ pub struct Handle<'port, T> {
priv port: &'port mut Port,
}
-struct PacketIterator { priv cur: *mut Packet }
+struct Packets { priv cur: *mut Packet }
impl Select {
/// Creates a new selection structure. This set is initially empty and
@@ -267,7 +267,7 @@ impl Select {
(*packet).selection_id = 0;
}
- fn iter(&self) -> PacketIterator { PacketIterator { cur: self.head } }
+ fn iter(&self) -> Packets { Packets { cur: self.head } }
}
impl<'port, T: Send> Handle<'port, T> {
@@ -300,7 +300,7 @@ impl<'port, T: Send> Drop for Handle<'port, T> {
}
}
-impl Iterator<*mut Packet> for PacketIterator {
+impl Iterator<*mut Packet> for Packets {
fn next(&mut self) -> Option<*mut Packet> {
if self.cur.is_null() {
None
diff --git a/src/libstd/fmt/mod.rs b/src/libstd/fmt/mod.rs
index a075010bfb2..8a945d09bfc 100644
--- a/src/libstd/fmt/mod.rs
+++ b/src/libstd/fmt/mod.rs
@@ -497,7 +497,7 @@ pub struct Formatter<'a> {
/// Output buffer.
buf: &'a mut io::Writer,
- priv curarg: vec::VecIterator<'a, Argument<'a>>,
+ priv curarg: vec::Items<'a, Argument<'a>>,
priv args: &'a [Argument<'a>],
}
diff --git a/src/libstd/fmt/parse.rs b/src/libstd/fmt/parse.rs
index 0ac1aac2380..6c08eae7474 100644
--- a/src/libstd/fmt/parse.rs
+++ b/src/libstd/fmt/parse.rs
@@ -168,7 +168,7 @@ pub struct SelectArm<'a> {
/// necessary there's probably lots of room for improvement performance-wise.
pub struct Parser<'a> {
priv input: &'a str,
- priv cur: str::CharOffsetIterator<'a>,
+ priv cur: str::CharOffsets<'a>,
priv depth: uint,
}
diff --git a/src/libstd/hashmap.rs b/src/libstd/hashmap.rs
index 5c3b18caa06..7f19105cdc8 100644
--- a/src/libstd/hashmap.rs
+++ b/src/libstd/hashmap.rs
@@ -528,34 +528,34 @@ impl HashMap {
/// An iterator visiting all keys in arbitrary order.
/// Iterator element type is &'a K.
- pub fn keys<'a>(&'a self) -> HashMapKeyIterator<'a, K, V> {
+ pub fn keys<'a>(&'a self) -> Keys<'a, K, V> {
self.iter().map(|(k, _v)| k)
}
/// An iterator visiting all values in arbitrary order.
/// Iterator element type is &'a V.
- pub fn values<'a>(&'a self) -> HashMapValueIterator<'a, K, V> {
+ pub fn values<'a>(&'a self) -> Values<'a, K, V> {
self.iter().map(|(_k, v)| v)
}
/// An iterator visiting all key-value pairs in arbitrary order.
/// Iterator element type is (&'a K, &'a V).
- pub fn iter<'a>(&'a self) -> HashMapIterator<'a, K, V> {
- HashMapIterator { iter: self.buckets.iter() }
+ pub fn iter<'a>(&'a self) -> Entries<'a, K, V> {
+ Entries { iter: self.buckets.iter() }
}
/// An iterator visiting all key-value pairs in arbitrary order,
/// with mutable references to the values.
/// Iterator element type is (&'a K, &'a mut V).
- pub fn mut_iter<'a>(&'a mut self) -> HashMapMutIterator<'a, K, V> {
- HashMapMutIterator { iter: self.buckets.mut_iter() }
+ pub fn mut_iter<'a>(&'a mut self) -> MutEntries<'a, K, V> {
+ MutEntries { iter: self.buckets.mut_iter() }
}
/// Creates a consuming iterator, that is, one that moves each key-value
/// pair out of the map in arbitrary order. The map cannot be used after
/// calling this.
- pub fn move_iter(self) -> HashMapMoveIterator {
- HashMapMoveIterator {iter: self.buckets.move_iter()}
+ pub fn move_iter(self) -> MoveEntries {
+ MoveEntries {iter: self.buckets.move_iter()}
}
}
@@ -598,40 +598,40 @@ impl Clone for HashMap {
/// HashMap iterator
#[deriving(Clone)]
-pub struct HashMapIterator<'a, K, V> {
- priv iter: vec::VecIterator<'a, Option>>,
+pub struct Entries<'a, K, V> {
+ priv iter: vec::Items<'a, Option>>,
}
/// HashMap mutable values iterator
-pub struct HashMapMutIterator<'a, K, V> {
- priv iter: vec::VecMutIterator<'a, Option>>,
+pub struct MutEntries<'a, K, V> {
+ priv iter: vec::MutItems<'a, Option>>,
}
/// HashMap move iterator
-pub struct HashMapMoveIterator {
- priv iter: vec::MoveIterator