From a3f5626ad1b5bc47ceddfb0d600cf6fd8a6dad8c Mon Sep 17 00:00:00 2001 From: Kevin Cantu Date: Wed, 1 Feb 2012 20:31:01 -0800 Subject: String split renaming: * Renamed str::split -> str::split_byte * Renamed str::splitn -> str::splitn_byte * Renamed str::split_func -> str::split * Renamed str::split_char -> str::split_char * Renamed str::split_chars_iter -> str::split_char_iter * Added u8::is_ascii * Fixed the behavior of str::split_str, so that it matches split_chars and split (i.e. ["", "XXX", "YYY", ""] == split_str(".XXX.YYY.", ".")) * Fixed str::split_byte and str::splitn_byte so that they handle splitting UTF-8 strings on a given UTF-8/ASCII byte and also handle "" as the others do --- src/libstd/fs.rs | 13 +++++++++---- src/libstd/net.rs | 3 ++- 2 files changed, 11 insertions(+), 5 deletions(-) (limited to 'src/libstd') diff --git a/src/libstd/fs.rs b/src/libstd/fs.rs index 75bde25afb8..ef0ff7e6b57 100644 --- a/src/libstd/fs.rs +++ b/src/libstd/fs.rs @@ -252,12 +252,16 @@ the first element of the returned vector will be the drive letter followed by a colon. */ fn split(p: path) -> [path] { - let split1 = str::split(p, os_fs::path_sep as u8); + // FIXME: use UTF-8 safe str, and/or various other string formats + let split1 = str::split_byte(p, os_fs::path_sep as u8); let split2 = []; for s in split1 { - split2 += str::split(s, os_fs::alt_path_sep as u8); + split2 += str::split_byte(s, os_fs::alt_path_sep as u8); } - ret split2; + + // filter out "" + let split3 = vec::filter(split2, {|seg| "" != seg}); + ret split3; } /* @@ -270,9 +274,10 @@ path includes directory components then they are included in the filename part of the result pair. */ fn splitext(p: path) -> (str, str) { + // FIXME: use UTF-8 safe str, and/or various other string formats if str::is_empty(p) { ("", "") } else { - let parts = str::split(p, '.' as u8); + let parts = str::split_byte(p, '.' as u8); if vec::len(parts) > 1u { let base = str::connect(vec::init(parts), "."); let ext = "." + option::get(vec::last(parts)); diff --git a/src/libstd/net.rs b/src/libstd/net.rs index 706221d95c2..68f8f29748a 100644 --- a/src/libstd/net.rs +++ b/src/libstd/net.rs @@ -49,7 +49,8 @@ Failure: String must be a valid IPv4 address */ fn parse_addr(ip: str) -> ip_addr { - let parts = vec::map(str::split(ip, "."[0]), {|s| uint::from_str(s) }); + let parts = vec::map(str::split_byte(ip, "."[0]), + {|s| uint::from_str(s) }); if vec::len(parts) != 4u { fail "Too many dots in IP address"; } for i in parts { if i > 255u { fail "Invalid IP Address part."; } } ipv4(parts[0] as u8, parts[1] as u8, parts[2] as u8, parts[3] as u8) -- cgit 1.4.1-3-g733a5