From d8dfe1957b6541de8fe2797e248fe4bd2fac02d9 Mon Sep 17 00:00:00 2001 From: Aaron Turon Date: Sun, 14 Sep 2014 15:57:55 -0700 Subject: Align with _mut conventions As per [RFC 52](https://github.com/rust-lang/rfcs/blob/master/active/0052-ownership-variants.md), use `_mut` suffixes to mark mutable variants, and `into_iter` for moving iterators. [breaking-change] --- src/libstd/collections/hashmap/map.rs | 16 ++++++++++++++-- src/libstd/collections/hashmap/table.rs | 4 ++-- src/libstd/io/buffered.rs | 2 +- 3 files changed, 17 insertions(+), 5 deletions(-) (limited to 'src/libstd') diff --git a/src/libstd/collections/hashmap/map.rs b/src/libstd/collections/hashmap/map.rs index a50c6a59f7e..4a58f4e75de 100644 --- a/src/libstd/collections/hashmap/map.rs +++ b/src/libstd/collections/hashmap/map.rs @@ -1193,6 +1193,12 @@ impl, V, S, H: Hasher> HashMap { Entries { inner: self.table.iter() } } + /// Deprecated: use `iter_mut`. + #[deprecated = "use iter_mut"] + pub fn mut_iter(&mut self) -> MutEntries { + self.iter_mut() + } + /// An iterator visiting all key-value pairs in arbitrary order, /// with mutable references to the values. /// Iterator element type is `(&'a K, &'a mut V)`. @@ -1216,10 +1222,16 @@ impl, V, S, H: Hasher> HashMap { /// println!("key: {} val: {}", key, val); /// } /// ``` - pub fn mut_iter(&mut self) -> MutEntries { + pub fn iter_mut(&mut self) -> MutEntries { MutEntries { inner: self.table.mut_iter() } } + /// Deprecated: use `into_iter`. + #[deprecated = "use into_iter"] + pub fn move_iter(self) -> MoveEntries { + self.into_iter() + } + /// Creates a consuming iterator, that is, one that moves each key-value /// pair out of the map in arbitrary order. The map cannot be used after /// calling this. @@ -1237,7 +1249,7 @@ impl, V, S, H: Hasher> HashMap { /// // Not possible with .iter() /// let vec: Vec<(&str, int)> = map.move_iter().collect(); /// ``` - pub fn move_iter(self) -> MoveEntries { + pub fn into_iter(self) -> MoveEntries { MoveEntries { inner: self.table.move_iter().map(|(_, k, v)| (k, v)) } diff --git a/src/libstd/collections/hashmap/table.rs b/src/libstd/collections/hashmap/table.rs index 2edb8cd092e..33e760f11ce 100644 --- a/src/libstd/collections/hashmap/table.rs +++ b/src/libstd/collections/hashmap/table.rs @@ -674,14 +674,14 @@ impl RawTable { } } - pub fn mut_iter(&mut self) -> MutEntries { + pub fn iter_mut(&mut self) -> MutEntries { MutEntries { iter: self.raw_buckets(), elems_left: self.size(), } } - pub fn move_iter(self) -> MoveEntries { + pub fn into_iter(self) -> MoveEntries { MoveEntries { iter: self.raw_buckets(), table: self, diff --git a/src/libstd/io/buffered.rs b/src/libstd/io/buffered.rs index 0c63f1a901f..76f86d66ff5 100644 --- a/src/libstd/io/buffered.rs +++ b/src/libstd/io/buffered.rs @@ -265,7 +265,7 @@ impl Writer for LineBufferedWriter { struct InternalBufferedWriter(BufferedWriter); impl InternalBufferedWriter { - fn get_mut_ref<'a>(&'a mut self) -> &'a mut BufferedWriter { + fn get_mut<'a>(&'a mut self) -> &'a mut BufferedWriter { let InternalBufferedWriter(ref mut w) = *self; return w; } -- cgit 1.4.1-3-g733a5