From cb02a370428afaae76db59080befe88b8c97e14d Mon Sep 17 00:00:00 2001 From: Huon Wilson Date: Tue, 28 Jan 2014 00:20:50 +1100 Subject: syntax: make deriving have slightly less cryptic error messages. This unfortunately changes an error like error: mismatched types: expected `&&NotClone` but found `&NotClone` into error: type `NotClone` does not implement any method in scope named `clone` --- src/libsyntax/ext/deriving/cmp/ord.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/libsyntax/ext/deriving/cmp') diff --git a/src/libsyntax/ext/deriving/cmp/ord.rs b/src/libsyntax/ext/deriving/cmp/ord.rs index 8a2b11b798c..5a02d8eead8 100644 --- a/src/libsyntax/ext/deriving/cmp/ord.rs +++ b/src/libsyntax/ext/deriving/cmp/ord.rs @@ -78,14 +78,10 @@ fn cs_op(less: bool, equal: bool, cx: &ExtCtxt, span: Span, substr: &Substructur _ => cx.span_bug(span, "Not exactly 2 arguments in `deriving(Ord)`") }; - let cmp = cx.expr_binary(span, op, - cx.expr_deref(span, self_f), - cx.expr_deref(span, other_f)); + let cmp = cx.expr_binary(span, op, self_f, other_f); let not_cmp = cx.expr_unary(span, ast::UnNot, - cx.expr_binary(span, op, - cx.expr_deref(span, other_f), - cx.expr_deref(span, self_f))); + cx.expr_binary(span, op, other_f, self_f)); let and = cx.expr_binary(span, ast::BiAnd, not_cmp, subexpr); cx.expr_binary(span, ast::BiOr, cmp, and) -- cgit 1.4.1-3-g733a5