From cc61fc09945aeec6fc71a07e91b8610fa71f6425 Mon Sep 17 00:00:00 2001 From: Salem Talha Date: Sun, 26 Jan 2014 03:43:42 -0500 Subject: Removed all instances of XXX in preparation for relaxing of FIXME rule --- src/libsyntax/ext/build.rs | 6 +++--- src/libsyntax/ext/expand.rs | 2 +- src/libsyntax/ext/tt/transcribe.rs | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/libsyntax/ext') diff --git a/src/libsyntax/ext/build.rs b/src/libsyntax/ext/build.rs index 3c0d7aaf4f3..3b2cc4ca6ed 100644 --- a/src/libsyntax/ext/build.rs +++ b/src/libsyntax/ext/build.rs @@ -179,7 +179,7 @@ pub trait AstBuilder { name: Ident, attrs: ~[ast::Attribute], node: ast::Item_) -> @ast::Item; fn arg(&self, span: Span, name: Ident, ty: P) -> ast::Arg; - // XXX unused self + // FIXME unused self fn fn_decl(&self, inputs: ~[ast::Arg], output: P) -> P; fn item_fn_poly(&self, @@ -724,7 +724,7 @@ impl<'a> AstBuilder for ExtCtxt<'a> { } } - // XXX unused self + // FIXME unused self fn fn_decl(&self, inputs: ~[ast::Arg], output: P) -> P { P(ast::FnDecl { inputs: inputs, @@ -736,7 +736,7 @@ impl<'a> AstBuilder for ExtCtxt<'a> { fn item(&self, span: Span, name: Ident, attrs: ~[ast::Attribute], node: ast::Item_) -> @ast::Item { - // XXX: Would be nice if our generated code didn't violate + // FIXME: Would be nice if our generated code didn't violate // Rust coding conventions @ast::Item { ident: name, attrs: attrs, diff --git a/src/libsyntax/ext/expand.rs b/src/libsyntax/ext/expand.rs index cd87819917a..1ffff03a80f 100644 --- a/src/libsyntax/ext/expand.rs +++ b/src/libsyntax/ext/expand.rs @@ -115,7 +115,7 @@ pub fn expand_expr(e: @ast::Expr, fld: &mut MacroExpander) -> @ast::Expr { // Keep going, outside-in. // - // XXX(pcwalton): Is it necessary to clone the + // FIXME(pcwalton): Is it necessary to clone the // node here? let fully_expanded = fld.fold_expr(marked_after).node.clone(); diff --git a/src/libsyntax/ext/tt/transcribe.rs b/src/libsyntax/ext/tt/transcribe.rs index 20d544f52c9..87a2f374c90 100644 --- a/src/libsyntax/ext/tt/transcribe.rs +++ b/src/libsyntax/ext/tt/transcribe.rs @@ -173,7 +173,7 @@ fn lockstep_iter_size(t: &TokenTree, r: &TtReader) -> LockstepIterSize { // return the next token from the TtReader. // EFFECT: advances the reader's token field pub fn tt_next_token(r: &TtReader) -> TokenAndSpan { - // XXX(pcwalton): Bad copy? + // FIXME(pcwalton): Bad copy? let ret_val = TokenAndSpan { tok: r.cur_tok.get(), sp: r.cur_span.get(), @@ -231,7 +231,7 @@ pub fn tt_next_token(r: &TtReader) -> TokenAndSpan { } loop { /* because it's easiest, this handles `TTDelim` not starting with a `TTTok`, even though it won't happen */ - // XXX(pcwalton): Bad copy. + // FIXME(pcwalton): Bad copy. match r.stack.get().forest[r.stack.get().idx.get()].clone() { TTDelim(tts) => { r.stack.set(@TtFrame { @@ -250,7 +250,7 @@ pub fn tt_next_token(r: &TtReader) -> TokenAndSpan { return ret_val; } TTSeq(sp, tts, sep, zerok) => { - // XXX(pcwalton): Bad copy. + // FIXME(pcwalton): Bad copy. let t = TTSeq(sp, tts, sep.clone(), zerok); match lockstep_iter_size(&t, r) { LisUnconstrained => { @@ -306,7 +306,7 @@ pub fn tt_next_token(r: &TtReader) -> TokenAndSpan { return ret_val; } MatchedNonterminal(ref other_whole_nt) => { - // XXX(pcwalton): Bad copy. + // FIXME(pcwalton): Bad copy. r.cur_span.set(sp); r.cur_tok.set(INTERPOLATED((*other_whole_nt).clone())); r.stack.get().idx.set(r.stack.get().idx.get() + 1u); -- cgit 1.4.1-3-g733a5