From ff50ce9a1b43720d7147251904c29b9503ea9dd9 Mon Sep 17 00:00:00 2001 From: Benjamin Herr Date: Sun, 22 Jun 2014 19:53:56 +0200 Subject: libsyntax: don't allow enum structs with no fields Unit-like structs are written as `struct Foo;`, but we erroneously accepted `struct Foo();` and took it to mean the same thing. Now we don't, so use the `struct Foo;` form! [breaking-change] --- src/libsyntax/parse/parser.rs | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/libsyntax') diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index 043ce3bf5b0..4a75473ac11 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -4116,6 +4116,11 @@ impl<'a> Parser<'a> { }; spanned(lo, p.span.hi, struct_field_) }); + if fields.len() == 0 { + self.fatal(format!("unit-like struct definition should be \ + written as `struct {};`", + token::get_ident(class_name)).as_slice()); + } self.expect(&token::SEMI); } else if self.eat(&token::SEMI) { // It's a unit-like struct. -- cgit 1.4.1-3-g733a5