From dddb8d2eba04610eca944a659c1906f78d210ab4 Mon Sep 17 00:00:00 2001 From: flip1995 <9744647+flip1995@users.noreply.github.com> Date: Tue, 3 Jul 2018 13:50:48 +0200 Subject: Implementation of tool lints --- src/libsyntax/attr/mod.rs | 11 +++++++++++ src/libsyntax/feature_gate.rs | 2 ++ 2 files changed, 13 insertions(+) (limited to 'src/libsyntax') diff --git a/src/libsyntax/attr/mod.rs b/src/libsyntax/attr/mod.rs index 4e27d6c1525..f8db62083c7 100644 --- a/src/libsyntax/attr/mod.rs +++ b/src/libsyntax/attr/mod.rs @@ -90,6 +90,7 @@ pub fn is_known(attr: &Attribute) -> bool { } const RUST_KNOWN_TOOL: &[&str] = &["clippy", "rustfmt"]; +const RUST_KNOWN_LINT_TOOL: &[&str] = &["clippy"]; pub fn is_known_tool(attr: &Attribute) -> bool { let tool_name = @@ -97,6 +98,12 @@ pub fn is_known_tool(attr: &Attribute) -> bool { RUST_KNOWN_TOOL.contains(&tool_name.as_str().as_ref()) } +pub fn is_known_lint_tool(m_item: &MetaItem) -> bool { + let tool_name = + m_item.ident.segments.iter().next().expect("empty path in meta item").ident.name; + RUST_KNOWN_LINT_TOOL.contains(&tool_name.as_str().as_ref()) +} + impl NestedMetaItem { /// Returns the MetaItem if self is a NestedMetaItemKind::MetaItem. pub fn meta_item(&self) -> Option<&MetaItem> { @@ -290,6 +297,10 @@ impl MetaItem { pub fn is_meta_item_list(&self) -> bool { self.meta_item_list().is_some() } + + pub fn is_scoped(&self) -> bool { + self.ident.segments.len() > 1 + } } impl Attribute { diff --git a/src/libsyntax/feature_gate.rs b/src/libsyntax/feature_gate.rs index 2ae0e669fd0..d0837063514 100644 --- a/src/libsyntax/feature_gate.rs +++ b/src/libsyntax/feature_gate.rs @@ -458,6 +458,8 @@ declare_features! ( // Scoped attributes (active, tool_attributes, "1.25.0", Some(44690), None), + // Scoped lints + (active, tool_lints, "1.28.0", Some(44690), None), // allow irrefutable patterns in if-let and while-let statements (RFC 2086) (active, irrefutable_let_patterns, "1.27.0", Some(44495), None), -- cgit 1.4.1-3-g733a5