From b7675cf04ad1c65e86f51feddc3451b46a768d6b Mon Sep 17 00:00:00 2001 From: Nick Cameron Date: Tue, 11 Oct 2016 17:19:51 +1300 Subject: Deprecate custom_derive Has a custom deprecation since deprecating features is not supported and is a pain to implement --- src/libsyntax_ext/deriving/mod.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'src/libsyntax_ext') diff --git a/src/libsyntax_ext/deriving/mod.rs b/src/libsyntax_ext/deriving/mod.rs index 07401d59a15..ca07a9267fa 100644 --- a/src/libsyntax_ext/deriving/mod.rs +++ b/src/libsyntax_ext/deriving/mod.rs @@ -175,6 +175,7 @@ pub fn expand_derive(cx: &mut ExtCtxt, feature_gate::GateIssue::Language, feature_gate::EXPLAIN_CUSTOM_DERIVE); } else { + cx.span_warn(titem.span, EXPLAIN_DEPR_CUSTOM_DERIVE); let name = intern_and_get_ident(&format!("derive_{}", tname)); let mitem = cx.meta_word(titem.span, name); new_attributes.push(cx.attribute(mitem.span, mitem)); -- cgit 1.4.1-3-g733a5 From 9322332140fe934ece4476ade531009b2f71f033 Mon Sep 17 00:00:00 2001 From: Nick Cameron Date: Wed, 12 Oct 2016 08:38:35 +1300 Subject: deprecation message for custom derive --- src/libsyntax_ext/deriving/mod.rs | 2 +- src/test/compile-fail/deriving-meta-unknown-trait.rs | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) (limited to 'src/libsyntax_ext') diff --git a/src/libsyntax_ext/deriving/mod.rs b/src/libsyntax_ext/deriving/mod.rs index ca07a9267fa..67747173353 100644 --- a/src/libsyntax_ext/deriving/mod.rs +++ b/src/libsyntax_ext/deriving/mod.rs @@ -175,7 +175,7 @@ pub fn expand_derive(cx: &mut ExtCtxt, feature_gate::GateIssue::Language, feature_gate::EXPLAIN_CUSTOM_DERIVE); } else { - cx.span_warn(titem.span, EXPLAIN_DEPR_CUSTOM_DERIVE); + cx.span_warn(titem.span, feature_gate::EXPLAIN_DEPR_CUSTOM_DERIVE); let name = intern_and_get_ident(&format!("derive_{}", tname)); let mitem = cx.meta_word(titem.span, name); new_attributes.push(cx.attribute(mitem.span, mitem)); diff --git a/src/test/compile-fail/deriving-meta-unknown-trait.rs b/src/test/compile-fail/deriving-meta-unknown-trait.rs index e2234994693..596cc1e7d58 100644 --- a/src/test/compile-fail/deriving-meta-unknown-trait.rs +++ b/src/test/compile-fail/deriving-meta-unknown-trait.rs @@ -8,8 +8,10 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. +// ignore-tidy-linelength + #[derive(Eqr)] -//~^ ERROR `#[derive]` for custom traits is not stable enough for use and is subject to change +//~^ ERROR `#[derive]` for custom traits is not stable enough for use. It is deprecated and will be removed in v1.15 (see issue #29644) struct Foo; pub fn main() {} -- cgit 1.4.1-3-g733a5