From 8797e8cabdd47d1731bbd12099d0cd5503d22d76 Mon Sep 17 00:00:00 2001 From: Nicholas Nethercote Date: Fri, 31 May 2019 16:50:44 +1000 Subject: Move `modern` calls inside `glob_adjust` and `reverse_glob_adjust`. --- src/libsyntax_pos/hygiene.rs | 7 ++++--- src/libsyntax_pos/lib.rs | 9 ++++----- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/libsyntax_pos') diff --git a/src/libsyntax_pos/hygiene.rs b/src/libsyntax_pos/hygiene.rs index 445d4271d89..39a7124c756 100644 --- a/src/libsyntax_pos/hygiene.rs +++ b/src/libsyntax_pos/hygiene.rs @@ -463,9 +463,9 @@ impl SyntaxContext { /// ``` /// This returns `None` if the context cannot be glob-adjusted. /// Otherwise, it returns the scope to use when privacy checking (see `adjust` for details). - pub fn glob_adjust(&mut self, expansion: Mark, mut glob_ctxt: SyntaxContext) - -> Option> { + pub fn glob_adjust(&mut self, expansion: Mark, glob_span: Span) -> Option> { let mut scope = None; + let mut glob_ctxt = glob_span.ctxt().modern(); while !expansion.outer_is_descendant_of(glob_ctxt) { scope = Some(glob_ctxt.remove_mark()); if self.remove_mark() != scope.unwrap() { @@ -485,12 +485,13 @@ impl SyntaxContext { /// assert!(self.glob_adjust(expansion, glob_ctxt) == Some(privacy_checking_scope)); /// } /// ``` - pub fn reverse_glob_adjust(&mut self, expansion: Mark, mut glob_ctxt: SyntaxContext) + pub fn reverse_glob_adjust(&mut self, expansion: Mark, glob_span: Span) -> Option> { if self.adjust(expansion).is_some() { return None; } + let mut glob_ctxt = glob_span.ctxt().modern(); let mut marks = Vec::new(); while !expansion.outer_is_descendant_of(glob_ctxt) { marks.push(glob_ctxt.remove_mark()); diff --git a/src/libsyntax_pos/lib.rs b/src/libsyntax_pos/lib.rs index 30e075a3396..9bab95efd1b 100644 --- a/src/libsyntax_pos/lib.rs +++ b/src/libsyntax_pos/lib.rs @@ -535,19 +535,18 @@ impl Span { } #[inline] - pub fn glob_adjust(&mut self, expansion: Mark, glob_ctxt: SyntaxContext) - -> Option> { + pub fn glob_adjust(&mut self, expansion: Mark, glob_span: Span) -> Option> { let mut span = self.data(); - let mark = span.ctxt.glob_adjust(expansion, glob_ctxt); + let mark = span.ctxt.glob_adjust(expansion, glob_span); *self = Span::new(span.lo, span.hi, span.ctxt); mark } #[inline] - pub fn reverse_glob_adjust(&mut self, expansion: Mark, glob_ctxt: SyntaxContext) + pub fn reverse_glob_adjust(&mut self, expansion: Mark, glob_span: Span) -> Option> { let mut span = self.data(); - let mark = span.ctxt.reverse_glob_adjust(expansion, glob_ctxt); + let mark = span.ctxt.reverse_glob_adjust(expansion, glob_span); *self = Span::new(span.lo, span.hi, span.ctxt); mark } -- cgit 1.4.1-3-g733a5