From 93931311ff1d034ef92e35f36c900bbd74176179 Mon Sep 17 00:00:00 2001
From: Brian Anderson <banderson@mozilla.com>
Date: Thu, 17 Nov 2011 17:33:54 -0800
Subject: rt: Add FIXMEs about races in rust_task

---
 src/rt/rust_task.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

(limited to 'src/rt/rust_task.cpp')

diff --git a/src/rt/rust_task.cpp b/src/rt/rust_task.cpp
index a152ecb8d3b..b2d9c4d64cd 100644
--- a/src/rt/rust_task.cpp
+++ b/src/rt/rust_task.cpp
@@ -278,6 +278,10 @@ rust_task::yield(size_t time_in_us) {
         unblock();
         fail();
     }
+
+    // FIXME: If we are blocked, and get killed right here then we may never
+    // know it.
+
     yield_timer.reset_us(time_in_us);
 
     // Return to the scheduler.
@@ -468,8 +472,11 @@ rust_task::die() {
 
 void
 rust_task::unblock() {
-    if (blocked())
+    if (blocked()) {
+        // FIXME: What if another thread unblocks the task between when
+        // we checked and here?
         wakeup(cond);
+    }
 }
 
 rust_crate_cache *
-- 
cgit 1.4.1-3-g733a5