From 9ea6b3a32e808c4cf1e2d45cc26363e700944ef9 Mon Sep 17 00:00:00 2001 From: Patrick Walton Date: Fri, 17 Aug 2012 15:54:18 -0700 Subject: rustc: Remove a few allocations from metadata. Shaves a few milliseconds off compilation of hello world. --- src/rustc/metadata/decoder.rs | 4 ++-- src/rustc/metadata/tydecode.rs | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) (limited to 'src/rustc/metadata') diff --git a/src/rustc/metadata/decoder.rs b/src/rustc/metadata/decoder.rs index 9f7b95f2bfa..ea5405cc510 100644 --- a/src/rustc/metadata/decoder.rs +++ b/src/rustc/metadata/decoder.rs @@ -72,7 +72,7 @@ fn lookup_hash(d: ebml::doc, eq_fn: fn(x:&[u8]) -> bool, hash: uint) -> let belt = tag_index_buckets_bucket_elt; for ebml::tagged_docs(bucket, belt) |elt| { let pos = io::u64_from_be_bytes(*elt.data, elt.start, 4u) as uint; - if eq_fn(vec::slice(*elt.data, elt.start + 4u, elt.end)) { + if eq_fn(vec::view(*elt.data, elt.start + 4u, elt.end)) { return some(ebml::doc_at(d.data, pos).doc); } }; @@ -81,7 +81,7 @@ fn lookup_hash(d: ebml::doc, eq_fn: fn(x:&[u8]) -> bool, hash: uint) -> fn maybe_find_item(item_id: int, items: ebml::doc) -> option { fn eq_item(bytes: &[u8], item_id: int) -> bool { - return io::u64_from_be_bytes(vec::slice(bytes, 0u, 4u), 0u, 4u) as int + return io::u64_from_be_bytes(vec::view(bytes, 0u, 4u), 0u, 4u) as int == item_id; } lookup_hash(items, diff --git a/src/rustc/metadata/tydecode.rs b/src/rustc/metadata/tydecode.rs index 90be808b229..cb9a6b0ad13 100644 --- a/src/rustc/metadata/tydecode.rs +++ b/src/rustc/metadata/tydecode.rs @@ -391,8 +391,9 @@ fn parse_def_id(buf: &[u8]) -> ast::def_id { error!{"didn't find ':' when parsing def id"}; fail; } - let crate_part = vec::slice(buf, 0u, colon_idx); - let def_part = vec::slice(buf, colon_idx + 1u, len); + + let crate_part = vec::view(buf, 0u, colon_idx); + let def_part = vec::view(buf, colon_idx + 1u, len); let crate_num = match uint::parse_buf(crate_part, 10u) { some(cn) => cn as int, -- cgit 1.4.1-3-g733a5