From 4f01329e0eb48c9481e91ff1749367a4c0048d70 Mon Sep 17 00:00:00 2001 From: Jake Goulding Date: Thu, 9 Jun 2016 09:41:17 -0400 Subject: Reflect supporting only LLVM 3.7+ in the LLVM wrappers --- src/rustllvm/ArchiveWrapper.cpp | 25 ------------------------- 1 file changed, 25 deletions(-) (limited to 'src/rustllvm/ArchiveWrapper.cpp') diff --git a/src/rustllvm/ArchiveWrapper.cpp b/src/rustllvm/ArchiveWrapper.cpp index d3f2907bfc3..1de0f59109e 100644 --- a/src/rustllvm/ArchiveWrapper.cpp +++ b/src/rustllvm/ArchiveWrapper.cpp @@ -11,10 +11,7 @@ #include "rustllvm.h" #include "llvm/Object/Archive.h" - -#if LLVM_VERSION_MINOR >= 7 #include "llvm/Object/ArchiveWriter.h" -#endif using namespace llvm; using namespace llvm::object; @@ -34,13 +31,8 @@ struct LLVMRustArchiveMember { ~LLVMRustArchiveMember() {} }; -#if LLVM_VERSION_MINOR >= 6 typedef OwningBinary RustArchive; #define GET_ARCHIVE(a) ((a)->getBinary()) -#else -typedef Archive RustArchive; -#define GET_ARCHIVE(a) (a) -#endif extern "C" void* LLVMRustOpenArchive(char *path) { @@ -52,7 +44,6 @@ LLVMRustOpenArchive(char *path) { return nullptr; } -#if LLVM_VERSION_MINOR >= 6 ErrorOr> archive_or = Archive::create(buf_or.get()->getMemBufferRef()); @@ -63,14 +54,6 @@ LLVMRustOpenArchive(char *path) { OwningBinary *ret = new OwningBinary( std::move(archive_or.get()), std::move(buf_or.get())); -#else - std::error_code err; - Archive *ret = new Archive(std::move(buf_or.get()), err); - if (err) { - LLVMRustSetLastError(err.message().c_str()); - return nullptr; - } -#endif return ret; } @@ -137,16 +120,12 @@ LLVMRustArchiveChildName(const Archive::Child *child, size_t *size) { extern "C" const char* LLVMRustArchiveChildData(Archive::Child *child, size_t *size) { StringRef buf; -#if LLVM_VERSION_MINOR >= 7 ErrorOr buf_or_err = child->getBuffer(); if (buf_or_err.getError()) { LLVMRustSetLastError(buf_or_err.getError().message().c_str()); return NULL; } buf = buf_or_err.get(); -#else - buf = child->getBuffer(); -#endif *size = buf.size(); return buf.data(); } @@ -172,7 +151,6 @@ LLVMRustWriteArchive(char *Dst, const LLVMRustArchiveMember **NewMembers, bool WriteSymbtab, Archive::Kind Kind) { -#if LLVM_VERSION_MINOR >= 7 std::vector Members; for (size_t i = 0; i < NumMembers; i++) { @@ -196,8 +174,5 @@ LLVMRustWriteArchive(char *Dst, if (!pair.second) return 0; LLVMRustSetLastError(pair.second.message().c_str()); -#else - LLVMRustSetLastError("writing archives not supported with this LLVM version"); -#endif return -1; } -- cgit 1.4.1-3-g733a5 From f3d9de4528e7be9428b5afddec25d9ed4622f305 Mon Sep 17 00:00:00 2001 From: Jake Goulding Date: Thu, 9 Jun 2016 09:57:22 -0400 Subject: Remove unneeded indirection of GET_ARCHIVE --- src/rustllvm/ArchiveWrapper.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/rustllvm/ArchiveWrapper.cpp') diff --git a/src/rustllvm/ArchiveWrapper.cpp b/src/rustllvm/ArchiveWrapper.cpp index 1de0f59109e..1e7b04c814c 100644 --- a/src/rustllvm/ArchiveWrapper.cpp +++ b/src/rustllvm/ArchiveWrapper.cpp @@ -32,7 +32,6 @@ struct LLVMRustArchiveMember { }; typedef OwningBinary RustArchive; -#define GET_ARCHIVE(a) ((a)->getBinary()) extern "C" void* LLVMRustOpenArchive(char *path) { @@ -70,7 +69,7 @@ struct RustArchiveIterator { extern "C" RustArchiveIterator* LLVMRustArchiveIteratorNew(RustArchive *ra) { - Archive *ar = GET_ARCHIVE(ra); + Archive *ar = ra->getBinary(); RustArchiveIterator *rai = new RustArchiveIterator(); rai->cur = ar->child_begin(); rai->end = ar->child_end(); -- cgit 1.4.1-3-g733a5