From 4ca769ad091ef0018f5a20effaf4b4f428a034d7 Mon Sep 17 00:00:00 2001 From: Krishna Sai Veera Reddy Date: Fri, 29 Nov 2019 15:22:44 -0700 Subject: Optimize Ord trait implementation for bool Casting the booleans to `i8`s and converting their difference into `Ordering` generates better assembly than casting them to `u8`s and comparing them. --- src/test/codegen/bool-cmp.rs | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 src/test/codegen/bool-cmp.rs (limited to 'src/test/codegen') diff --git a/src/test/codegen/bool-cmp.rs b/src/test/codegen/bool-cmp.rs new file mode 100644 index 00000000000..8769a4cb5e1 --- /dev/null +++ b/src/test/codegen/bool-cmp.rs @@ -0,0 +1,17 @@ +// This is a test for optimal Ord trait implementation for bool. +// See for more info. + +// compile-flags: -C opt-level=3 + +#![crate_type = "lib"] + +use std::cmp::Ordering; + +// CHECK-LABEL: @cmp_bool +#[no_mangle] +pub fn cmp_bool(a: bool, b: bool) -> Ordering { +// CHECK: zext i1 +// CHECK: zext i1 +// CHECK: sub nsw + a.cmp(&b) +} -- cgit 1.4.1-3-g733a5