From 3aec9f46d3fee9c5fa0d44d1ee40e76f8eaec2ed Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Tue, 5 Aug 2014 11:49:34 -0700 Subject: native, rustuv: Fix spawning with empty args There was a bug in both libnative and libuv which prevented child processes from being spawned correctly on windows when one of the arguments was an empty string. The libuv bug has since been fixed upstream, and the libnative bug was fixed as part of this commit. When updating libuv, this also includes a fix for #15149. Closes #15149 Closes #16272 --- src/test/run-pass/issue-15149.rs | 4 +--- src/test/run-pass/issue-16272.rs | 45 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 3 deletions(-) create mode 100644 src/test/run-pass/issue-16272.rs (limited to 'src/test') diff --git a/src/test/run-pass/issue-15149.rs b/src/test/run-pass/issue-15149.rs index d76a7109ced..cb4410cc1aa 100644 --- a/src/test/run-pass/issue-15149.rs +++ b/src/test/run-pass/issue-15149.rs @@ -18,9 +18,7 @@ use std::io::{TempDir, Command, fs}; use std::os; use std::task::TaskBuilder; -// FIXME(#15149) libgreen still needs to be update. There is an open PR for it -// but it is not yet merged. -// green_start!(main) +green_start!(main) fn main() { // If we're the child, make sure we were invoked correctly diff --git a/src/test/run-pass/issue-16272.rs b/src/test/run-pass/issue-16272.rs new file mode 100644 index 00000000000..86427f5e9dd --- /dev/null +++ b/src/test/run-pass/issue-16272.rs @@ -0,0 +1,45 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(phase)] +#[phase(plugin)] +extern crate green; +extern crate native; + +use native::NativeTaskBuilder; +use std::io::{process, Command}; +use std::os; +use std::task::TaskBuilder; + +green_start!(main) + +fn main() { + let len = os::args().len(); + + if len == 1 { + test(); + let (tx, rx) = channel(); + TaskBuilder::new().native().spawn(proc() { + tx.send(test()); + }); + rx.recv(); + } else { + assert_eq!(len, 3); + } +} + +fn test() { + let status = Command::new(os::self_exe_name().unwrap()) + .arg("foo").arg("") + .stdout(process::InheritFd(1)) + .stderr(process::InheritFd(2)) + .status().unwrap(); + assert!(status.success()); +} -- cgit 1.4.1-3-g733a5