From 7fdf06cdde49c8cd87e34e85a95c1fe90ebdb0c3 Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Sun, 26 Aug 2018 15:19:34 +0200 Subject: Report const eval error inside the query --- src/test/compile-fail/const-fn-error.rs | 4 +- src/test/compile-fail/issue-52443.rs | 2 +- src/test/ui/array_const_index-0.rs | 5 +- src/test/ui/array_const_index-0.stderr | 19 +++- src/test/ui/array_const_index-1.rs | 5 +- src/test/ui/array_const_index-1.stderr | 19 +++- src/test/ui/consts/const-array-oob.rs | 2 +- src/test/ui/consts/const-array-oob.stderr | 16 +-- src/test/ui/consts/const-call.stderr | 8 +- src/test/ui/consts/const-err-early.rs | 13 +-- src/test/ui/consts/const-err-early.stderr | 65 ++++++++++-- src/test/ui/consts/const-err-multi.rs | 7 +- src/test/ui/consts/const-err-multi.stderr | 56 ++++------ src/test/ui/consts/const-err.rs | 13 +-- src/test/ui/consts/const-err.stderr | 33 +++--- src/test/ui/consts/const-err4.rs | 2 +- src/test/ui/consts/const-err4.stderr | 2 +- .../conditional_array_execution.nll.stderr | 29 ++++++ .../const-eval/conditional_array_execution.rs | 3 +- .../const-eval/conditional_array_execution.stderr | 15 +-- .../consts/const-eval/const-eval-overflow-2.stderr | 6 +- .../consts/const-eval/const-eval-overflow-3.stderr | 16 +-- .../ui/consts/const-eval/const-eval-overflow-4.rs | 3 +- .../consts/const-eval/const-eval-overflow-4.stderr | 16 +-- .../ui/consts/const-eval/const-eval-overflow2.rs | 41 +++----- .../consts/const-eval/const-eval-overflow2.stderr | 115 +++++++++++++++------ .../ui/consts/const-eval/const-eval-overflow2b.rs | 41 +++----- .../consts/const-eval/const-eval-overflow2b.stderr | 115 +++++++++++++++------ .../ui/consts/const-eval/const-eval-overflow2c.rs | 41 +++----- .../consts/const-eval/const-eval-overflow2c.stderr | 115 +++++++++++++++------ .../const-pointer-values-in-various-types.rs | 44 ++++---- src/test/ui/consts/const-eval/const_panic.rs | 15 ++- src/test/ui/consts/const-eval/const_panic.stderr | 36 +++---- .../ui/consts/const-eval/const_panic_libcore.rs | 6 +- .../consts/const-eval/const_panic_libcore.stderr | 6 +- .../consts/const-eval/const_panic_libcore_main.rs | 6 +- .../const-eval/const_panic_libcore_main.stderr | 12 +-- src/test/ui/consts/const-eval/const_raw_ptr_ops.rs | 8 +- .../ui/consts/const-eval/const_raw_ptr_ops.stderr | 16 +-- src/test/ui/consts/const-eval/double_check2.stderr | 2 +- src/test/ui/consts/const-eval/infinite_loop.rs | 2 +- src/test/ui/consts/const-eval/infinite_loop.stderr | 23 ++--- .../ui/consts/const-eval/issue-43197.nll.stderr | 43 ++++++++ src/test/ui/consts/const-eval/issue-43197.rs | 10 +- src/test/ui/consts/const-eval/issue-43197.stderr | 36 ++----- .../ui/consts/const-eval/issue-44578.nll.stderr | 15 +++ src/test/ui/consts/const-eval/issue-44578.rs | 3 +- src/test/ui/consts/const-eval/issue-44578.stderr | 13 +-- src/test/ui/consts/const-eval/issue-50814-2.rs | 5 +- src/test/ui/consts/const-eval/issue-50814-2.stderr | 19 ++-- src/test/ui/consts/const-eval/issue-50814.rs | 5 +- src/test/ui/consts/const-eval/issue-50814.stderr | 19 ++-- src/test/ui/consts/const-eval/issue-52443.stderr | 49 +++++++++ .../ui/consts/const-eval/match-test-ptr-null.rs | 3 +- .../consts/const-eval/match-test-ptr-null.stderr | 16 +-- .../ui/consts/const-eval/promoted_const_fn_fail.rs | 2 +- .../promoted_const_fn_fail_deny_const_err.rs | 36 +++++++ .../promoted_const_fn_fail_deny_const_err.stderr | 19 ++++ .../ui/consts/const-eval/promoted_errors.stderr | 12 +++ src/test/ui/consts/const-eval/pub_const_err.rs | 2 +- src/test/ui/consts/const-eval/pub_const_err.stderr | 14 +-- src/test/ui/consts/const-eval/pub_const_err_bin.rs | 2 +- .../ui/consts/const-eval/pub_const_err_bin.stderr | 14 +-- .../ui/consts/const-eval/shift_overflow.stderr | 2 +- src/test/ui/consts/const-eval/ub-enum.rs | 6 +- src/test/ui/consts/const-eval/ub-enum.stderr | 6 +- .../ui/consts/const-eval/union-const-eval-field.rs | 5 +- .../const-eval/union-const-eval-field.stderr | 32 +++++- src/test/ui/consts/const-eval/union-ice.rs | 6 +- src/test/ui/consts/const-eval/union-ice.stderr | 12 +-- src/test/ui/consts/const-eval/union-ub-fat-ptr.rs | 29 +++--- .../ui/consts/const-eval/union-ub-fat-ptr.stderr | 38 +++---- src/test/ui/consts/const-eval/union-ub.rs | 2 +- src/test/ui/consts/const-eval/union-ub.stderr | 2 +- src/test/ui/consts/const-fn-error.stderr | 41 ++++++++ src/test/ui/consts/const-integer-bool-ops.rs | 10 ++ src/test/ui/consts/const-integer-bool-ops.stderr | 95 ++++++++++++++--- .../consts/const-len-underflow-separate-spans.rs | 4 +- .../const-len-underflow-separate-spans.stderr | 36 ++----- src/test/ui/consts/const-len-underflow-subspans.rs | 2 +- .../ui/consts/const-len-underflow-subspans.stderr | 16 +-- src/test/ui/consts/const-size_of-cycle.stderr | 5 + src/test/ui/consts/const-slice-oob.rs | 4 +- src/test/ui/consts/const-slice-oob.stderr | 19 +++- src/test/ui/consts/const-tup-index-span.rs | 1 + src/test/ui/consts/const-tup-index-span.stderr | 11 +- src/test/ui/error-codes/E0080.rs | 3 - src/test/ui/error-codes/E0080.stderr | 28 +---- src/test/ui/error-codes/E0396-fixed.rs | 2 +- src/test/ui/error-codes/E0396-fixed.stderr | 2 +- src/test/ui/eval-enum.rs | 6 +- src/test/ui/eval-enum.stderr | 34 +----- .../ui/infinite/infinite-recursion-const-fn.rs | 4 +- .../ui/infinite/infinite-recursion-const-fn.stderr | 14 ++- src/test/ui/issues/issue-39559-2.stderr | 14 ++- src/test/ui/issues/issue-41394.rs | 1 + src/test/ui/issues/issue-41394.stderr | 11 +- src/test/ui/issues/issue-43105.rs | 3 +- src/test/ui/issues/issue-43105.stderr | 18 +++- src/test/ui/issues/issue-44415.stderr | 5 + src/test/ui/issues/issue-50599.rs | 1 + src/test/ui/issues/issue-50599.stderr | 11 +- .../recursion/recursive-static-definition.stderr | 5 + src/test/ui/type/type-dependent-def-issue-49241.rs | 1 + .../ui/type/type-dependent-def-issue-49241.stderr | 11 +- 105 files changed, 1173 insertions(+), 725 deletions(-) create mode 100644 src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr create mode 100644 src/test/ui/consts/const-eval/issue-43197.nll.stderr create mode 100644 src/test/ui/consts/const-eval/issue-44578.nll.stderr create mode 100644 src/test/ui/consts/const-eval/issue-52443.stderr create mode 100644 src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs create mode 100644 src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr create mode 100644 src/test/ui/consts/const-fn-error.stderr (limited to 'src/test') diff --git a/src/test/compile-fail/const-fn-error.rs b/src/test/compile-fail/const-fn-error.rs index 6eda41730b3..0eee0b4c7b8 100644 --- a/src/test/compile-fail/const-fn-error.rs +++ b/src/test/compile-fail/const-fn-error.rs @@ -16,7 +16,7 @@ const fn f(x: usize) -> usize { let mut sum = 0; //~^ let bindings in constant functions are unstable //~| statements in constant functions are unstable - for i in 0..x { + for i in 0..x { //~ ERROR E0080 //~^ ERROR E0015 //~| ERROR E0019 sum += i; @@ -26,5 +26,5 @@ const fn f(x: usize) -> usize { #[allow(unused_variables)] fn main() { - let a : [i32; f(X)]; //~ ERROR E0080 + let a : [i32; f(X)]; } diff --git a/src/test/compile-fail/issue-52443.rs b/src/test/compile-fail/issue-52443.rs index 2ae94f6d642..1ed513033fd 100644 --- a/src/test/compile-fail/issue-52443.rs +++ b/src/test/compile-fail/issue-52443.rs @@ -14,5 +14,5 @@ fn main() { [(); {while true {break}; 0}]; //~ ERROR constant contains unimplemented expression type [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions //~^ ERROR constant contains unimplemented expression type - //~| ERROR could not evaluate repeat length + //~| ERROR evaluation of constant value failed } diff --git a/src/test/ui/array_const_index-0.rs b/src/test/ui/array_const_index-0.rs index 91007fcd63a..2403d50db39 100644 --- a/src/test/ui/array_const_index-0.rs +++ b/src/test/ui/array_const_index-0.rs @@ -11,8 +11,9 @@ const A: &'static [i32] = &[]; const B: i32 = (&A)[1]; //~^ index out of bounds: the len is 0 but the index is 1 -//~| ERROR this constant cannot be used +//~| ERROR any use of this value will cause an error +//~| ERROR any use of this value will cause an error fn main() { - let _ = B; + let _ = B; //~ ERROR erroneous constant used } diff --git a/src/test/ui/array_const_index-0.stderr b/src/test/ui/array_const_index-0.stderr index b71d224f4f0..95ed88bde10 100644 --- a/src/test/ui/array_const_index-0.stderr +++ b/src/test/ui/array_const_index-0.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/array_const_index-0.rs:12:1 | LL | const B: i32 = (&A)[1]; @@ -8,5 +8,20 @@ LL | const B: i32 = (&A)[1]; | = note: #[deny(const_err)] on by default -error: aborting due to previous error +error: any use of this value will cause an error + --> $DIR/array_const_index-0.rs:12:1 + | +LL | const B: i32 = (&A)[1]; + | ^^^^^^^^^^^^^^^-------^ + | | + | index out of bounds: the len is 0 but the index is 1 + +error[E0080]: erroneous constant used + --> $DIR/array_const_index-0.rs:18:13 + | +LL | let _ = B; //~ ERROR erroneous constant used + | ^ referenced constant has errors + +error: aborting due to 3 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/array_const_index-1.rs b/src/test/ui/array_const_index-1.rs index 66739d308a7..0a49348761c 100644 --- a/src/test/ui/array_const_index-1.rs +++ b/src/test/ui/array_const_index-1.rs @@ -11,8 +11,9 @@ const A: [i32; 0] = []; const B: i32 = A[1]; //~^ index out of bounds: the len is 0 but the index is 1 -//~| ERROR this constant cannot be used +//~| ERROR any use of this value will cause an error +//~| ERROR any use of this value will cause an error fn main() { - let _ = B; + let _ = B; //~ ERROR erroneous constant used } diff --git a/src/test/ui/array_const_index-1.stderr b/src/test/ui/array_const_index-1.stderr index 02f86a693af..5fcfc14e2c0 100644 --- a/src/test/ui/array_const_index-1.stderr +++ b/src/test/ui/array_const_index-1.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/array_const_index-1.rs:12:1 | LL | const B: i32 = A[1]; @@ -8,5 +8,20 @@ LL | const B: i32 = A[1]; | = note: #[deny(const_err)] on by default -error: aborting due to previous error +error: any use of this value will cause an error + --> $DIR/array_const_index-1.rs:12:1 + | +LL | const B: i32 = A[1]; + | ^^^^^^^^^^^^^^^----^ + | | + | index out of bounds: the len is 0 but the index is 1 + +error[E0080]: erroneous constant used + --> $DIR/array_const_index-1.rs:18:13 + | +LL | let _ = B; //~ ERROR erroneous constant used + | ^ referenced constant has errors + +error: aborting due to 3 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-array-oob.rs b/src/test/ui/consts/const-array-oob.rs index 22a3c5ceeb7..227364cffd1 100644 --- a/src/test/ui/consts/const-array-oob.rs +++ b/src/test/ui/consts/const-array-oob.rs @@ -16,7 +16,7 @@ const FOO: [usize; 3] = [1, 2, 3]; const BAR: usize = FOO[5]; // no error, because the error below occurs before regular const eval const BLUB: [u32; FOO[4]] = [5, 6]; -//~^ ERROR could not evaluate constant expression [E0080] +//~^ ERROR evaluation of constant value failed [E0080] //~| index out of bounds: the len is 3 but the index is 4 fn main() { diff --git a/src/test/ui/consts/const-array-oob.stderr b/src/test/ui/consts/const-array-oob.stderr index 19ec9a4aa17..5986376938b 100644 --- a/src/test/ui/consts/const-array-oob.stderr +++ b/src/test/ui/consts/const-array-oob.stderr @@ -1,19 +1,9 @@ -error: index out of bounds: the len is 3 but the index is 4 +error[E0080]: evaluation of constant value failed --> $DIR/const-array-oob.rs:18:19 | LL | const BLUB: [u32; FOO[4]] = [5, 6]; - | ^^^^^^ - | - = note: #[deny(const_err)] on by default - -error[E0080]: could not evaluate constant expression - --> $DIR/const-array-oob.rs:18:13 - | -LL | const BLUB: [u32; FOO[4]] = [5, 6]; - | ^^^^^^------^ - | | - | index out of bounds: the len is 3 but the index is 4 + | ^^^^^^ index out of bounds: the len is 3 but the index is 4 -error: aborting due to 2 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-call.stderr b/src/test/ui/consts/const-call.stderr index 81be93e916e..e0427d0d04c 100644 --- a/src/test/ui/consts/const-call.stderr +++ b/src/test/ui/consts/const-call.stderr @@ -4,6 +4,12 @@ error[E0015]: calls in constants are limited to constant functions, tuple struct LL | let _ = [0; f(2)]; | ^^^^ -error: aborting due to previous error +error[E0080]: evaluation of constant value failed + --> $DIR/const-call.rs:16:17 + | +LL | let _ = [0; f(2)]; + | ^^^^ calling non-const fn `f` + +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0015`. diff --git a/src/test/ui/consts/const-err-early.rs b/src/test/ui/consts/const-err-early.rs index 39b1b342eac..488e6f49e14 100644 --- a/src/test/ui/consts/const-err-early.rs +++ b/src/test/ui/consts/const-err-early.rs @@ -11,16 +11,17 @@ #![deny(const_err)] pub const A: i8 = -std::i8::MIN; //~ ERROR const_err +//~^ ERROR const_err pub const B: u8 = 200u8 + 200u8; //~ ERROR const_err pub const C: u8 = 200u8 * 4; //~ ERROR const_err pub const D: u8 = 42u8 - (42u8 + 1); //~ ERROR const_err pub const E: u8 = [5u8][1]; //~ ERROR const_err fn main() { - let _a = A; - let _b = B; - let _c = C; - let _d = D; - let _e = E; - let _e = [6u8][1]; + let _a = A; //~ ERROR erroneous constant used + let _b = B; //~ ERROR erroneous constant used + let _c = C; //~ ERROR erroneous constant used + let _d = D; //~ ERROR erroneous constant used + let _e = E; //~ ERROR erroneous constant used + let _e = [6u8][1]; //~ ERROR index out of bounds } diff --git a/src/test/ui/consts/const-err-early.stderr b/src/test/ui/consts/const-err-early.stderr index 36f3ac1a9bc..21c7bf0a70a 100644 --- a/src/test/ui/consts/const-err-early.stderr +++ b/src/test/ui/consts/const-err-early.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-err-early.rs:13:1 | LL | pub const A: i8 = -std::i8::MIN; //~ ERROR const_err @@ -12,37 +12,82 @@ note: lint level defined here LL | #![deny(const_err)] | ^^^^^^^^^ -error: this constant cannot be used - --> $DIR/const-err-early.rs:14:1 +error: any use of this value will cause an error + --> $DIR/const-err-early.rs:15:1 | LL | pub const B: u8 = 200u8 + 200u8; //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^-------------^ | | | attempt to add with overflow -error: this constant cannot be used - --> $DIR/const-err-early.rs:15:1 +error: any use of this value will cause an error + --> $DIR/const-err-early.rs:16:1 | LL | pub const C: u8 = 200u8 * 4; //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^---------^ | | | attempt to multiply with overflow -error: this constant cannot be used - --> $DIR/const-err-early.rs:16:1 +error: any use of this value will cause an error + --> $DIR/const-err-early.rs:17:1 | LL | pub const D: u8 = 42u8 - (42u8 + 1); //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^-----------------^ | | | attempt to subtract with overflow -error: this constant cannot be used - --> $DIR/const-err-early.rs:17:1 +error: any use of this value will cause an error + --> $DIR/const-err-early.rs:18:1 | LL | pub const E: u8 = [5u8][1]; //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^--------^ | | | index out of bounds: the len is 1 but the index is 1 -error: aborting due to 5 previous errors +error: any use of this value will cause an error + --> $DIR/const-err-early.rs:13:1 + | +LL | pub const A: i8 = -std::i8::MIN; //~ ERROR const_err + | ^^^^^^^^^^^^^^^^^^-------------^ + | | + | attempt to negate with overflow + +error[E0080]: erroneous constant used + --> $DIR/const-err-early.rs:21:14 + | +LL | let _a = A; //~ ERROR erroneous constant used + | ^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-err-early.rs:22:14 + | +LL | let _b = B; //~ ERROR erroneous constant used + | ^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-err-early.rs:23:14 + | +LL | let _c = C; //~ ERROR erroneous constant used + | ^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-err-early.rs:24:14 + | +LL | let _d = D; //~ ERROR erroneous constant used + | ^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-err-early.rs:25:14 + | +LL | let _e = E; //~ ERROR erroneous constant used + | ^ referenced constant has errors + +error: index out of bounds: the len is 1 but the index is 1 + --> $DIR/const-err-early.rs:26:14 + | +LL | let _e = [6u8][1]; //~ ERROR index out of bounds + | ^^^^^^^^ + +error: aborting due to 12 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err-multi.rs b/src/test/ui/consts/const-err-multi.rs index f2ee8a7078c..c3960b83992 100644 --- a/src/test/ui/consts/const-err-multi.rs +++ b/src/test/ui/consts/const-err-multi.rs @@ -11,17 +11,16 @@ #![deny(const_err)] pub const A: i8 = -std::i8::MIN; -//~^ ERROR this constant cannot be used -pub const B: i8 = A; //~^ ERROR const_err //~| ERROR const_err +pub const B: i8 = A; +//~^ ERROR const_err pub const C: u8 = A as u8; //~^ ERROR const_err -//~| ERROR const_err pub const D: i8 = 50 - A; //~^ ERROR const_err -//~| ERROR const_err fn main() { let _ = (A, B, C, D); + //~^ ERROR erroneous constant used } diff --git a/src/test/ui/consts/const-err-multi.stderr b/src/test/ui/consts/const-err-multi.stderr index dd3eaa4c47b..0717302dbf9 100644 --- a/src/test/ui/consts/const-err-multi.stderr +++ b/src/test/ui/consts/const-err-multi.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-err-multi.rs:13:1 | LL | pub const A: i8 = -std::i8::MIN; @@ -12,33 +12,15 @@ note: lint level defined here LL | #![deny(const_err)] | ^^^^^^^^^ -error: referenced constant has errors - --> $DIR/const-err-multi.rs:15:1 - | -LL | pub const A: i8 = -std::i8::MIN; - | ------------- attempt to negate with overflow -LL | //~^ ERROR this constant cannot be used -LL | pub const B: i8 = A; - | ^^^^^^^^^^^^^^^^^^^^ - -error: this constant cannot be used - --> $DIR/const-err-multi.rs:15:1 +error: any use of this value will cause an error + --> $DIR/const-err-multi.rs:16:1 | LL | pub const B: i8 = A; | ^^^^^^^^^^^^^^^^^^-^ | | | referenced constant has errors -error: referenced constant has errors - --> $DIR/const-err-multi.rs:18:1 - | -LL | pub const A: i8 = -std::i8::MIN; - | ------------- attempt to negate with overflow -... -LL | pub const C: u8 = A as u8; - | ^^^^^^^^^^^^^^^^^^^^^^^^^^ - -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-err-multi.rs:18:1 | LL | pub const C: u8 = A as u8; @@ -46,22 +28,28 @@ LL | pub const C: u8 = A as u8; | | | referenced constant has errors -error: referenced constant has errors - --> $DIR/const-err-multi.rs:21:1 - | -LL | pub const A: i8 = -std::i8::MIN; - | ------------- attempt to negate with overflow -... -LL | pub const D: i8 = 50 - A; - | ^^^^^^^^^^^^^^^^^^^^^^^^^ - -error: this constant cannot be used - --> $DIR/const-err-multi.rs:21:1 +error: any use of this value will cause an error + --> $DIR/const-err-multi.rs:20:1 | LL | pub const D: i8 = 50 - A; | ^^^^^^^^^^^^^^^^^^------^ | | | referenced constant has errors -error: aborting due to 7 previous errors +error: any use of this value will cause an error + --> $DIR/const-err-multi.rs:13:1 + | +LL | pub const A: i8 = -std::i8::MIN; + | ^^^^^^^^^^^^^^^^^^-------------^ + | | + | attempt to negate with overflow + +error[E0080]: erroneous constant used + --> $DIR/const-err-multi.rs:24:13 + | +LL | let _ = (A, B, C, D); + | ^^^^^^^^^^^^ referenced constant has errors + +error: aborting due to 6 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err.rs b/src/test/ui/consts/const-err.rs index 8683f6a0231..7c59e8b9535 100644 --- a/src/test/ui/consts/const-err.rs +++ b/src/test/ui/consts/const-err.rs @@ -10,23 +10,18 @@ // compile-flags: -Zforce-overflow-checks=on -// these errors are not actually "const_err", they occur in codegen/consts -// and are unconditional warnings that can't be denied or allowed - #![allow(exceeding_bitshifts)] -#![allow(const_err)] +#![warn(const_err)] fn black_box(_: T) { unimplemented!() } -// Make sure that the two uses get two errors. const FOO: u8 = [5u8][1]; -//~^ ERROR constant evaluation error -//~| index out of bounds: the len is 1 but the index is 1 +//~^ WARN any use of this value will cause an error +//~| WARN any use of this value will cause an error fn main() { black_box((FOO, FOO)); - //~^ ERROR referenced constant has errors - //~| ERROR could not evaluate constant + //~^ ERROR erroneous constant used } diff --git a/src/test/ui/consts/const-err.stderr b/src/test/ui/consts/const-err.stderr index 1674f99b682..b46277f4b01 100644 --- a/src/test/ui/consts/const-err.stderr +++ b/src/test/ui/consts/const-err.stderr @@ -1,26 +1,31 @@ -error[E0080]: referenced constant has errors - --> $DIR/const-err.rs:29:15 +warning: any use of this value will cause an error + --> $DIR/const-err.rs:20:1 | LL | const FOO: u8 = [5u8][1]; - | -------- index out of bounds: the len is 1 but the index is 1 -... -LL | black_box((FOO, FOO)); - | ^^^^^^^^^^ - -error[E0080]: could not evaluate constant - --> $DIR/const-err.rs:29:15 + | ^^^^^^^^^^^^^^^^--------^ + | | + | index out of bounds: the len is 1 but the index is 1 | -LL | black_box((FOO, FOO)); - | ^^^^^^^^^^ referenced constant has errors +note: lint level defined here + --> $DIR/const-err.rs:14:9 + | +LL | #![warn(const_err)] + | ^^^^^^^^^ -error[E0080]: constant evaluation error - --> $DIR/const-err.rs:24:1 +warning: any use of this value will cause an error + --> $DIR/const-err.rs:20:1 | LL | const FOO: u8 = [5u8][1]; | ^^^^^^^^^^^^^^^^--------^ | | | index out of bounds: the len is 1 but the index is 1 -error: aborting due to 3 previous errors +error[E0080]: erroneous constant used + --> $DIR/const-err.rs:25:15 + | +LL | black_box((FOO, FOO)); + | ^^^^^^^^^^ referenced constant has errors + +error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err4.rs b/src/test/ui/consts/const-err4.rs index 10376d57809..0bbc254453c 100644 --- a/src/test/ui/consts/const-err4.rs +++ b/src/test/ui/consts/const-err4.rs @@ -16,7 +16,7 @@ union Foo { enum Bar { Boo = [unsafe { Foo { b: () }.a }; 4][3], - //~^ ERROR could not evaluate enum discriminant + //~^ ERROR evaluation of constant value failed } fn main() { diff --git a/src/test/ui/consts/const-err4.stderr b/src/test/ui/consts/const-err4.stderr index dc64737b22f..bb50f38062e 100644 --- a/src/test/ui/consts/const-err4.stderr +++ b/src/test/ui/consts/const-err4.stderr @@ -1,4 +1,4 @@ -error[E0080]: could not evaluate enum discriminant +error[E0080]: evaluation of constant value failed --> $DIR/const-err4.rs:18:11 | LL | Boo = [unsafe { Foo { b: () }.a }; 4][3], diff --git a/src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr b/src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr new file mode 100644 index 00000000000..b6c35b8ebbd --- /dev/null +++ b/src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr @@ -0,0 +1,29 @@ +warning: any use of this value will cause an error + --> $DIR/conditional_array_execution.rs:15:1 + | +LL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize]; + | ^^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^ + | | + | attempt to subtract with overflow + | +note: lint level defined here + --> $DIR/conditional_array_execution.rs:11:9 + | +LL | #![warn(const_err)] + | ^^^^^^^^^ + +error[E0080]: evaluation of constant expression failed + --> $DIR/conditional_array_execution.rs:19:14 + | +LL | println!("{}", FOO); + | ^^^^ --- referenced constant has errors + +error[E0080]: evaluation of constant expression failed + --> $DIR/conditional_array_execution.rs:19:20 + | +LL | println!("{}", FOO); + | ^^^ referenced constant has errors + +error: aborting due to 2 previous errors + +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/conditional_array_execution.rs b/src/test/ui/consts/const-eval/conditional_array_execution.rs index 8142ed0155a..4e245c6b9e8 100644 --- a/src/test/ui/consts/const-eval/conditional_array_execution.rs +++ b/src/test/ui/consts/const-eval/conditional_array_execution.rs @@ -13,10 +13,9 @@ const X: u32 = 5; const Y: u32 = 6; const FOO: u32 = [X - Y, Y - X][(X < Y) as usize]; -//~^ WARN this constant cannot be used +//~^ WARN any use of this value will cause an error fn main() { println!("{}", FOO); //~^ ERROR - //~| ERROR } diff --git a/src/test/ui/consts/const-eval/conditional_array_execution.stderr b/src/test/ui/consts/const-eval/conditional_array_execution.stderr index 29f5f8e2ade..90131080ed1 100644 --- a/src/test/ui/consts/const-eval/conditional_array_execution.stderr +++ b/src/test/ui/consts/const-eval/conditional_array_execution.stderr @@ -1,4 +1,4 @@ -warning: this constant cannot be used +warning: any use of this value will cause an error --> $DIR/conditional_array_execution.rs:15:1 | LL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize]; @@ -12,21 +12,12 @@ note: lint level defined here LL | #![warn(const_err)] | ^^^^^^^^^ -error[E0080]: referenced constant has errors - --> $DIR/conditional_array_execution.rs:19:20 - | -LL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize]; - | ----- attempt to subtract with overflow -... -LL | println!("{}", FOO); - | ^^^ - -error[E0080]: erroneous constant used +error[E0080]: evaluation of constant expression failed --> $DIR/conditional_array_execution.rs:19:20 | LL | println!("{}", FOO); | ^^^ referenced constant has errors -error: aborting due to 2 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow-2.stderr b/src/test/ui/consts/const-eval/const-eval-overflow-2.stderr index e99d409880e..70c98977301 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow-2.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow-2.stderr @@ -1,12 +1,8 @@ -error[E0080]: could not evaluate constant pattern +error: could not evaluate constant pattern --> $DIR/const-eval-overflow-2.rs:25:9 | -LL | const NEG_NEG_128: i8 = -NEG_128; - | -------- attempt to negate with overflow -... LL | NEG_NEG_128 => println!("A"), | ^^^^^^^^^^^ error: aborting due to previous error -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow-3.stderr b/src/test/ui/consts/const-eval/const-eval-overflow-3.stderr index f2b4e6b3b56..bcef9eff2f8 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow-3.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow-3.stderr @@ -1,19 +1,9 @@ -error: attempt to add with overflow +error[E0080]: evaluation of constant value failed --> $DIR/const-eval-overflow-3.rs:30:11 | LL | = [0; (i8::MAX + 1) as usize]; - | ^^^^^^^^^^^^^ - | - = note: #[deny(const_err)] on by default - -error[E0080]: could not evaluate repeat length - --> $DIR/const-eval-overflow-3.rs:30:11 - | -LL | = [0; (i8::MAX + 1) as usize]; - | -------------^^^^^^^^^ - | | - | attempt to add with overflow + | ^^^^^^^^^^^^^ attempt to add with overflow -error: aborting due to 2 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow-4.rs b/src/test/ui/consts/const-eval/const-eval-overflow-4.rs index e9fc8ec0c37..5d692d9d7fc 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow-4.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow-4.rs @@ -21,8 +21,7 @@ use std::{u8, u16, u32, u64, usize}; const A_I8_T : [u32; (i8::MAX as i8 + 1i8) as usize] - //~^ ERROR attempt to add with overflow - //~| ERROR could not evaluate constant expression + //~^ ERROR evaluation of constant value failed = [0; (i8::MAX as usize) + 1]; fn main() { diff --git a/src/test/ui/consts/const-eval/const-eval-overflow-4.stderr b/src/test/ui/consts/const-eval/const-eval-overflow-4.stderr index b12aa032b60..fd186dc719c 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow-4.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow-4.stderr @@ -1,19 +1,9 @@ -error: attempt to add with overflow +error[E0080]: evaluation of constant value failed --> $DIR/const-eval-overflow-4.rs:23:13 | LL | : [u32; (i8::MAX as i8 + 1i8) as usize] - | ^^^^^^^^^^^^^^^^^^^^^ - | - = note: #[deny(const_err)] on by default - -error[E0080]: could not evaluate constant expression - --> $DIR/const-eval-overflow-4.rs:23:7 - | -LL | : [u32; (i8::MAX as i8 + 1i8) as usize] - | ^^^^^^---------------------^^^^^^^^^^ - | | - | attempt to add with overflow + | ^^^^^^^^^^^^^^^^^^^^^ attempt to add with overflow -error: aborting due to 2 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2.rs b/src/test/ui/consts/const-eval/const-eval-overflow2.rs index 88fc5182775..ee29423a90c 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2.rs @@ -21,62 +21,55 @@ use std::fmt; use std::{i8, i16, i32, i64, isize}; use std::{u8, u16, u32, u64, usize}; -const VALS_I8: (i8,) = - //~^ ERROR this constant cannot be used +const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error + //~^ const_err ( i8::MIN - 1, ); -const VALS_I16: (i16,) = - //~^ ERROR this constant cannot be used +const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error ( i16::MIN - 1, ); -const VALS_I32: (i32,) = - //~^ ERROR this constant cannot be used +const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error ( i32::MIN - 1, ); -const VALS_I64: (i64,) = - //~^ ERROR this constant cannot be used +const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error ( i64::MIN - 1, ); -const VALS_U8: (u8,) = - //~^ ERROR this constant cannot be used +const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error ( u8::MIN - 1, ); -const VALS_U16: (u16,) = ( - //~^ ERROR this constant cannot be used +const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error u16::MIN - 1, ); -const VALS_U32: (u32,) = ( - //~^ ERROR this constant cannot be used +const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error u32::MIN - 1, ); -const VALS_U64: (u64,) = - //~^ ERROR this constant cannot be used +const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error ( u64::MIN - 1, ); fn main() { - foo(VALS_I8); - foo(VALS_I16); - foo(VALS_I32); - foo(VALS_I64); + foo(VALS_I8); //~ ERROR erroneous constant used + foo(VALS_I16); //~ ERROR erroneous constant used + foo(VALS_I32); //~ ERROR erroneous constant used + foo(VALS_I64); //~ ERROR erroneous constant used - foo(VALS_U8); - foo(VALS_U16); - foo(VALS_U32); - foo(VALS_U64); + foo(VALS_U8); //~ ERROR erroneous constant used + foo(VALS_U16); //~ ERROR erroneous constant used + foo(VALS_U32); //~ ERROR erroneous constant used + foo(VALS_U64); //~ ERROR erroneous constant used } fn foo(_: T) { diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2.stderr index 5cf5ce367e2..f10a6eee6de 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2.stderr @@ -1,8 +1,8 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-eval-overflow2.rs:24:1 | -LL | / const VALS_I8: (i8,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error +LL | | //~^ const_err LL | | ( LL | | i8::MIN - 1, | | ----------- attempt to subtract with overflow @@ -15,80 +15,133 @@ note: lint level defined here LL | #![deny(const_err)] | ^^^^^^^^^ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-eval-overflow2.rs:30:1 | -LL | / const VALS_I16: (i16,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i16::MIN - 1, | | ------------ attempt to subtract with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2.rs:36:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2.rs:35:1 | -LL | / const VALS_I32: (i32,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i32::MIN - 1, | | ------------ attempt to subtract with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2.rs:42:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2.rs:40:1 | -LL | / const VALS_I64: (i64,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i64::MIN - 1, | | ------------ attempt to subtract with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2.rs:48:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2.rs:45:1 | -LL | / const VALS_U8: (u8,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | u8::MIN - 1, | | ----------- attempt to subtract with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2.rs:54:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2.rs:50:1 | -LL | / const VALS_U16: (u16,) = ( -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error LL | | u16::MIN - 1, | | ------------ attempt to subtract with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2.rs:59:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2.rs:54:1 | -LL | / const VALS_U32: (u32,) = ( -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error LL | | u32::MIN - 1, | | ------------ attempt to subtract with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2.rs:64:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2.rs:58:1 | -LL | / const VALS_U64: (u64,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | u64::MIN - 1, | | ------------ attempt to subtract with overflow LL | | ); | |_______^ -error: aborting due to 8 previous errors +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2.rs:24:1 + | +LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error +LL | | //~^ const_err +LL | | ( +LL | | i8::MIN - 1, + | | ----------- attempt to subtract with overflow +LL | | ); + | |_______^ + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:64:5 + | +LL | foo(VALS_I8); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:65:5 + | +LL | foo(VALS_I16); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:66:5 + | +LL | foo(VALS_I32); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:67:5 + | +LL | foo(VALS_I64); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:69:5 + | +LL | foo(VALS_U8); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:70:5 + | +LL | foo(VALS_U16); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:71:5 + | +LL | foo(VALS_U32); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2.rs:72:5 + | +LL | foo(VALS_U64); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error: aborting due to 17 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2b.rs b/src/test/ui/consts/const-eval/const-eval-overflow2b.rs index 1878daea931..55dc2a89405 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2b.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2b.rs @@ -21,62 +21,55 @@ use std::fmt; use std::{i8, i16, i32, i64, isize}; use std::{u8, u16, u32, u64, usize}; -const VALS_I8: (i8,) = - //~^ ERROR this constant cannot be used +const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error + //~^ const_err ( i8::MAX + 1, ); -const VALS_I16: (i16,) = - //~^ ERROR this constant cannot be used +const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error ( i16::MAX + 1, ); -const VALS_I32: (i32,) = - //~^ ERROR this constant cannot be used +const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error ( i32::MAX + 1, ); -const VALS_I64: (i64,) = - //~^ ERROR this constant cannot be used +const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error ( i64::MAX + 1, ); -const VALS_U8: (u8,) = - //~^ ERROR this constant cannot be used +const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error ( u8::MAX + 1, ); -const VALS_U16: (u16,) = ( - //~^ ERROR this constant cannot be used +const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error u16::MAX + 1, ); -const VALS_U32: (u32,) = ( - //~^ ERROR this constant cannot be used +const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error u32::MAX + 1, ); -const VALS_U64: (u64,) = - //~^ ERROR this constant cannot be used +const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error ( u64::MAX + 1, ); fn main() { - foo(VALS_I8); - foo(VALS_I16); - foo(VALS_I32); - foo(VALS_I64); + foo(VALS_I8); //~ ERROR erroneous constant used + foo(VALS_I16); //~ ERROR erroneous constant used + foo(VALS_I32); //~ ERROR erroneous constant used + foo(VALS_I64); //~ ERROR erroneous constant used - foo(VALS_U8); - foo(VALS_U16); - foo(VALS_U32); - foo(VALS_U64); + foo(VALS_U8); //~ ERROR erroneous constant used + foo(VALS_U16); //~ ERROR erroneous constant used + foo(VALS_U32); //~ ERROR erroneous constant used + foo(VALS_U64); //~ ERROR erroneous constant used } fn foo(_: T) { diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr index 458a9e11e75..3b78fb51a62 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr @@ -1,8 +1,8 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-eval-overflow2b.rs:24:1 | -LL | / const VALS_I8: (i8,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error +LL | | //~^ const_err LL | | ( LL | | i8::MAX + 1, | | ----------- attempt to add with overflow @@ -15,80 +15,133 @@ note: lint level defined here LL | #![deny(const_err)] | ^^^^^^^^^ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-eval-overflow2b.rs:30:1 | -LL | / const VALS_I16: (i16,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i16::MAX + 1, | | ------------ attempt to add with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2b.rs:36:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2b.rs:35:1 | -LL | / const VALS_I32: (i32,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i32::MAX + 1, | | ------------ attempt to add with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2b.rs:42:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2b.rs:40:1 | -LL | / const VALS_I64: (i64,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i64::MAX + 1, | | ------------ attempt to add with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2b.rs:48:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2b.rs:45:1 | -LL | / const VALS_U8: (u8,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | u8::MAX + 1, | | ----------- attempt to add with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2b.rs:54:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2b.rs:50:1 | -LL | / const VALS_U16: (u16,) = ( -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error LL | | u16::MAX + 1, | | ------------ attempt to add with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2b.rs:59:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2b.rs:54:1 | -LL | / const VALS_U32: (u32,) = ( -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error LL | | u32::MAX + 1, | | ------------ attempt to add with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2b.rs:64:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2b.rs:58:1 | -LL | / const VALS_U64: (u64,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | u64::MAX + 1, | | ------------ attempt to add with overflow LL | | ); | |_______^ -error: aborting due to 8 previous errors +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2b.rs:24:1 + | +LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error +LL | | //~^ const_err +LL | | ( +LL | | i8::MAX + 1, + | | ----------- attempt to add with overflow +LL | | ); + | |_______^ + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:64:5 + | +LL | foo(VALS_I8); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:65:5 + | +LL | foo(VALS_I16); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:66:5 + | +LL | foo(VALS_I32); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:67:5 + | +LL | foo(VALS_I64); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:69:5 + | +LL | foo(VALS_U8); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:70:5 + | +LL | foo(VALS_U16); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:71:5 + | +LL | foo(VALS_U32); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2b.rs:72:5 + | +LL | foo(VALS_U64); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error: aborting due to 17 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2c.rs b/src/test/ui/consts/const-eval/const-eval-overflow2c.rs index f3d28295bf8..93ba11efc59 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2c.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2c.rs @@ -21,62 +21,55 @@ use std::fmt; use std::{i8, i16, i32, i64, isize}; use std::{u8, u16, u32, u64, usize}; -const VALS_I8: (i8,) = - //~^ ERROR this constant cannot be used +const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error + //~^ const_err ( i8::MIN * 2, ); -const VALS_I16: (i16,) = - //~^ ERROR this constant cannot be used +const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error ( i16::MIN * 2, ); -const VALS_I32: (i32,) = - //~^ ERROR this constant cannot be used +const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error ( i32::MIN * 2, ); -const VALS_I64: (i64,) = - //~^ ERROR this constant cannot be used +const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error ( i64::MIN * 2, ); -const VALS_U8: (u8,) = - //~^ ERROR this constant cannot be used +const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error ( u8::MAX * 2, ); -const VALS_U16: (u16,) = ( - //~^ ERROR this constant cannot be used +const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error u16::MAX * 2, ); -const VALS_U32: (u32,) = ( - //~^ ERROR this constant cannot be used +const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error u32::MAX * 2, ); -const VALS_U64: (u64,) = - //~^ ERROR this constant cannot be used +const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error ( u64::MAX * 2, ); fn main() { - foo(VALS_I8); - foo(VALS_I16); - foo(VALS_I32); - foo(VALS_I64); + foo(VALS_I8); //~ ERROR erroneous constant used + foo(VALS_I16); //~ ERROR erroneous constant used + foo(VALS_I32); //~ ERROR erroneous constant used + foo(VALS_I64); //~ ERROR erroneous constant used - foo(VALS_U8); - foo(VALS_U16); - foo(VALS_U32); - foo(VALS_U64); + foo(VALS_U8); //~ ERROR erroneous constant used + foo(VALS_U16); //~ ERROR erroneous constant used + foo(VALS_U32); //~ ERROR erroneous constant used + foo(VALS_U64); //~ ERROR erroneous constant used } fn foo(_: T) { diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr index 866860281cf..abaae4bd542 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr @@ -1,8 +1,8 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-eval-overflow2c.rs:24:1 | -LL | / const VALS_I8: (i8,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error +LL | | //~^ const_err LL | | ( LL | | i8::MIN * 2, | | ----------- attempt to multiply with overflow @@ -15,80 +15,133 @@ note: lint level defined here LL | #![deny(const_err)] | ^^^^^^^^^ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-eval-overflow2c.rs:30:1 | -LL | / const VALS_I16: (i16,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i16::MIN * 2, | | ------------ attempt to multiply with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2c.rs:36:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2c.rs:35:1 | -LL | / const VALS_I32: (i32,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i32::MIN * 2, | | ------------ attempt to multiply with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2c.rs:42:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2c.rs:40:1 | -LL | / const VALS_I64: (i64,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | i64::MIN * 2, | | ------------ attempt to multiply with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2c.rs:48:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2c.rs:45:1 | -LL | / const VALS_U8: (u8,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | u8::MAX * 2, | | ----------- attempt to multiply with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2c.rs:54:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2c.rs:50:1 | -LL | / const VALS_U16: (u16,) = ( -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error LL | | u16::MAX * 2, | | ------------ attempt to multiply with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2c.rs:59:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2c.rs:54:1 | -LL | / const VALS_U32: (u32,) = ( -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error LL | | u32::MAX * 2, | | ------------ attempt to multiply with overflow LL | | ); | |_______^ -error: this constant cannot be used - --> $DIR/const-eval-overflow2c.rs:64:1 +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2c.rs:58:1 | -LL | / const VALS_U64: (u64,) = -LL | | //~^ ERROR this constant cannot be used +LL | / const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error LL | | ( LL | | u64::MAX * 2, | | ------------ attempt to multiply with overflow LL | | ); | |_______^ -error: aborting due to 8 previous errors +error: any use of this value will cause an error + --> $DIR/const-eval-overflow2c.rs:24:1 + | +LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error +LL | | //~^ const_err +LL | | ( +LL | | i8::MIN * 2, + | | ----------- attempt to multiply with overflow +LL | | ); + | |_______^ + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:64:5 + | +LL | foo(VALS_I8); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:65:5 + | +LL | foo(VALS_I16); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:66:5 + | +LL | foo(VALS_I32); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:67:5 + | +LL | foo(VALS_I64); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:69:5 + | +LL | foo(VALS_U8); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:70:5 + | +LL | foo(VALS_U16); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:71:5 + | +LL | foo(VALS_U32); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error[E0080]: erroneous constant used + --> $DIR/const-eval-overflow2c.rs:72:5 + | +LL | foo(VALS_U64); //~ ERROR erroneous constant used + | ^^^^^^^^^^^^^ referenced constant has errors + +error: aborting due to 17 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs b/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs index dc84e2a88d6..05d79a7d633 100644 --- a/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs +++ b/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs @@ -25,86 +25,86 @@ fn main() { //~^ ERROR this constant likely exhibits undefined behavior const I32_REF_U8_UNION: u8 = unsafe { Nonsense { int_32_ref: &3 }.uint_8 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_U16_UNION: u16 = unsafe { Nonsense { int_32_ref: &3 }.uint_16 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_U32_UNION: u32 = unsafe { Nonsense { int_32_ref: &3 }.uint_32 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_U64_UNION: u64 = unsafe { Nonsense { int_32_ref: &3 }.uint_64 }; //~^ ERROR this constant likely exhibits undefined behavior const I32_REF_U128_UNION: u128 = unsafe { Nonsense { int_32_ref: &3 }.uint_128 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_I8_UNION: i8 = unsafe { Nonsense { int_32_ref: &3 }.int_8 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_I16_UNION: i16 = unsafe { Nonsense { int_32_ref: &3 }.int_16 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_I32_UNION: i32 = unsafe { Nonsense { int_32_ref: &3 }.int_32 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_I64_UNION: i64 = unsafe { Nonsense { int_32_ref: &3 }.int_64 }; //~^ ERROR this constant likely exhibits undefined behavior const I32_REF_I128_UNION: i128 = unsafe { Nonsense { int_32_ref: &3 }.int_128 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_F32_UNION: f32 = unsafe { Nonsense { int_32_ref: &3 }.float_32 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_F64_UNION: f64 = unsafe { Nonsense { int_32_ref: &3 }.float_64 }; //~^ ERROR this constant likely exhibits undefined behavior const I32_REF_BOOL_UNION: bool = unsafe { Nonsense { int_32_ref: &3 }.truthy_falsey }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const I32_REF_CHAR_UNION: char = unsafe { Nonsense { int_32_ref: &3 }.character }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_U8_UNION: u8 = unsafe { Nonsense { stringy: "3" }.uint_8 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_U16_UNION: u16 = unsafe { Nonsense { stringy: "3" }.uint_16 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_U32_UNION: u32 = unsafe { Nonsense { stringy: "3" }.uint_32 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_U64_UNION: u64 = unsafe { Nonsense { stringy: "3" }.uint_64 }; //~^ ERROR this constant likely exhibits undefined behavior const STR_U128_UNION: u128 = unsafe { Nonsense { stringy: "3" }.uint_128 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_I8_UNION: i8 = unsafe { Nonsense { stringy: "3" }.int_8 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_I16_UNION: i16 = unsafe { Nonsense { stringy: "3" }.int_16 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_I32_UNION: i32 = unsafe { Nonsense { stringy: "3" }.int_32 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_I64_UNION: i64 = unsafe { Nonsense { stringy: "3" }.int_64 }; //~^ ERROR this constant likely exhibits undefined behavior const STR_I128_UNION: i128 = unsafe { Nonsense { stringy: "3" }.int_128 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_F32_UNION: f32 = unsafe { Nonsense { stringy: "3" }.float_32 }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_F64_UNION: f64 = unsafe { Nonsense { stringy: "3" }.float_64 }; //~^ ERROR this constant likely exhibits undefined behavior const STR_BOOL_UNION: bool = unsafe { Nonsense { stringy: "3" }.truthy_falsey }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error const STR_CHAR_UNION: char = unsafe { Nonsense { stringy: "3" }.character }; - //~^ ERROR this constant cannot be used + //~^ ERROR any use of this value will cause an error } diff --git a/src/test/ui/consts/const-eval/const_panic.rs b/src/test/ui/consts/const-eval/const_panic.rs index f2170f509eb..9af631afed4 100644 --- a/src/test/ui/consts/const-eval/const_panic.rs +++ b/src/test/ui/consts/const-eval/const_panic.rs @@ -9,14 +9,13 @@ // except according to those terms. #![feature(const_panic)] +#![crate_type = "lib"] -fn main() {} +pub const Z: () = panic!("cheese"); +//~^ ERROR any use of this value will cause an error -const Z: () = panic!("cheese"); -//~^ ERROR this constant cannot be used +pub const Y: () = unreachable!(); +//~^ ERROR any use of this value will cause an error -const Y: () = unreachable!(); -//~^ ERROR this constant cannot be used - -const X: () = unimplemented!(); -//~^ ERROR this constant cannot be used +pub const X: () = unimplemented!(); +//~^ ERROR any use of this value will cause an error diff --git a/src/test/ui/consts/const-eval/const_panic.stderr b/src/test/ui/consts/const-eval/const_panic.stderr index c11146f4882..fcdbcbf5bfa 100644 --- a/src/test/ui/consts/const-eval/const_panic.stderr +++ b/src/test/ui/consts/const-eval/const_panic.stderr @@ -1,31 +1,31 @@ -error: this constant cannot be used - --> $DIR/const_panic.rs:15:1 +error: any use of this value will cause an error + --> $DIR/const_panic.rs:14:1 | -LL | const Z: () = panic!("cheese"); - | ^^^^^^^^^^^^^^----------------^ - | | - | the evaluated program panicked at 'cheese', $DIR/const_panic.rs:15:15 +LL | pub const Z: () = panic!("cheese"); + | ^^^^^^^^^^^^^^^^^^----------------^ + | | + | the evaluated program panicked at 'cheese', $DIR/const_panic.rs:14:19 | = note: #[deny(const_err)] on by default = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) -error: this constant cannot be used - --> $DIR/const_panic.rs:18:1 +error: any use of this value will cause an error + --> $DIR/const_panic.rs:17:1 | -LL | const Y: () = unreachable!(); - | ^^^^^^^^^^^^^^--------------^ - | | - | the evaluated program panicked at 'internal error: entered unreachable code', $DIR/const_panic.rs:18:15 +LL | pub const Y: () = unreachable!(); + | ^^^^^^^^^^^^^^^^^^--------------^ + | | + | the evaluated program panicked at 'internal error: entered unreachable code', $DIR/const_panic.rs:17:19 | = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) -error: this constant cannot be used - --> $DIR/const_panic.rs:21:1 +error: any use of this value will cause an error + --> $DIR/const_panic.rs:20:1 | -LL | const X: () = unimplemented!(); - | ^^^^^^^^^^^^^^----------------^ - | | - | the evaluated program panicked at 'not yet implemented', $DIR/const_panic.rs:21:15 +LL | pub const X: () = unimplemented!(); + | ^^^^^^^^^^^^^^^^^^----------------^ + | | + | the evaluated program panicked at 'not yet implemented', $DIR/const_panic.rs:20:19 | = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) diff --git a/src/test/ui/consts/const-eval/const_panic_libcore.rs b/src/test/ui/consts/const-eval/const_panic_libcore.rs index 59aeca18129..11da8742b10 100644 --- a/src/test/ui/consts/const-eval/const_panic_libcore.rs +++ b/src/test/ui/consts/const-eval/const_panic_libcore.rs @@ -13,10 +13,10 @@ #![feature(const_panic)] const Z: () = panic!("cheese"); -//~^ ERROR this constant cannot be used +//~^ ERROR any use of this value will cause an error const Y: () = unreachable!(); -//~^ ERROR this constant cannot be used +//~^ ERROR any use of this value will cause an error const X: () = unimplemented!(); -//~^ ERROR this constant cannot be used +//~^ ERROR any use of this value will cause an error diff --git a/src/test/ui/consts/const-eval/const_panic_libcore.stderr b/src/test/ui/consts/const-eval/const_panic_libcore.stderr index 45f2ee7744e..a8f04b96a8b 100644 --- a/src/test/ui/consts/const-eval/const_panic_libcore.stderr +++ b/src/test/ui/consts/const-eval/const_panic_libcore.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const_panic_libcore.rs:15:1 | LL | const Z: () = panic!("cheese"); @@ -9,7 +9,7 @@ LL | const Z: () = panic!("cheese"); = note: #[deny(const_err)] on by default = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const_panic_libcore.rs:18:1 | LL | const Y: () = unreachable!(); @@ -19,7 +19,7 @@ LL | const Y: () = unreachable!(); | = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const_panic_libcore.rs:21:1 | LL | const X: () = unimplemented!(); diff --git a/src/test/ui/consts/const-eval/const_panic_libcore_main.rs b/src/test/ui/consts/const-eval/const_panic_libcore_main.rs index 0364123994d..03365ae46ab 100644 --- a/src/test/ui/consts/const-eval/const_panic_libcore_main.rs +++ b/src/test/ui/consts/const-eval/const_panic_libcore_main.rs @@ -17,13 +17,13 @@ use core::panic::PanicInfo; const Z: () = panic!("cheese"); -//~^ ERROR this constant cannot be used +//~^ ERROR any use of this value will cause an error const Y: () = unreachable!(); -//~^ ERROR this constant cannot be used +//~^ ERROR any use of this value will cause an error const X: () = unimplemented!(); -//~^ ERROR this constant cannot be used +//~^ ERROR any use of this value will cause an error #[lang = "eh_personality"] fn eh() {} diff --git a/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr b/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr index 44b30c08cde..9a7c510029c 100644 --- a/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr +++ b/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr @@ -1,5 +1,5 @@ -error: this constant cannot be used - --> $DIR/const_panic_libcore_main.rs:19:1 +error: any use of this value will cause an error + --> $DIR/const_panic_libcore_main.rs:20:1 | LL | const Z: () = panic!("cheese"); | ^^^^^^^^^^^^^^----------------^ @@ -9,8 +9,8 @@ LL | const Z: () = panic!("cheese"); = note: #[deny(const_err)] on by default = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) -error: this constant cannot be used - --> $DIR/const_panic_libcore_main.rs:22:1 +error: any use of this value will cause an error + --> $DIR/const_panic_libcore_main.rs:23:1 | LL | const Y: () = unreachable!(); | ^^^^^^^^^^^^^^--------------^ @@ -19,8 +19,8 @@ LL | const Y: () = unreachable!(); | = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) -error: this constant cannot be used - --> $DIR/const_panic_libcore_main.rs:25:1 +error: any use of this value will cause an error + --> $DIR/const_panic_libcore_main.rs:26:1 | LL | const X: () = unimplemented!(); | ^^^^^^^^^^^^^^----------------^ diff --git a/src/test/ui/consts/const-eval/const_raw_ptr_ops.rs b/src/test/ui/consts/const-eval/const_raw_ptr_ops.rs index 2aff6a7c55c..3cd2c04c9f1 100644 --- a/src/test/ui/consts/const-eval/const_raw_ptr_ops.rs +++ b/src/test/ui/consts/const-eval/const_raw_ptr_ops.rs @@ -13,15 +13,15 @@ fn main() {} // unconst and bad, will thus error in miri -const X: bool = &1 as *const i32 == &2 as *const i32; //~ ERROR cannot be used +const X: bool = &1 as *const i32 == &2 as *const i32; //~ ERROR any use of this value will cause // unconst and fine const X2: bool = 42 as *const i32 == 43 as *const i32; // unconst and fine const Y: usize = 42usize as *const i32 as usize + 1; // unconst and bad, will thus error in miri -const Y2: usize = &1 as *const i32 as usize + 1; //~ ERROR cannot be used +const Y2: usize = &1 as *const i32 as usize + 1; //~ ERROR any use of this value will cause // unconst and fine const Z: i32 = unsafe { *(&1 as *const i32) }; // unconst and bad, will thus error in miri -const Z2: i32 = unsafe { *(42 as *const i32) }; //~ ERROR cannot be used -const Z3: i32 = unsafe { *(44 as *const i32) }; //~ ERROR cannot be used +const Z2: i32 = unsafe { *(42 as *const i32) }; //~ ERROR any use of this value will cause +const Z3: i32 = unsafe { *(44 as *const i32) }; //~ ERROR any use of this value will cause diff --git a/src/test/ui/consts/const-eval/const_raw_ptr_ops.stderr b/src/test/ui/consts/const-eval/const_raw_ptr_ops.stderr index df1e6f8e4c4..72bbdeb0183 100644 --- a/src/test/ui/consts/const-eval/const_raw_ptr_ops.stderr +++ b/src/test/ui/consts/const-eval/const_raw_ptr_ops.stderr @@ -1,33 +1,33 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const_raw_ptr_ops.rs:16:1 | -LL | const X: bool = &1 as *const i32 == &2 as *const i32; //~ ERROR cannot be used +LL | const X: bool = &1 as *const i32 == &2 as *const i32; //~ ERROR any use of this value will cause | ^^^^^^^^^^^^^^^^------------------------------------^ | | | "pointer arithmetic or comparison" needs an rfc before being allowed inside constants | = note: #[deny(const_err)] on by default -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const_raw_ptr_ops.rs:22:1 | -LL | const Y2: usize = &1 as *const i32 as usize + 1; //~ ERROR cannot be used +LL | const Y2: usize = &1 as *const i32 as usize + 1; //~ ERROR any use of this value will cause | ^^^^^^^^^^^^^^^^^^-----------------------------^ | | | "pointer arithmetic or comparison" needs an rfc before being allowed inside constants -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const_raw_ptr_ops.rs:26:1 | -LL | const Z2: i32 = unsafe { *(42 as *const i32) }; //~ ERROR cannot be used +LL | const Z2: i32 = unsafe { *(42 as *const i32) }; //~ ERROR any use of this value will cause | ^^^^^^^^^^^^^^^^^^^^^^^^^-------------------^^^ | | | a memory access tried to interpret some bytes as a pointer -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const_raw_ptr_ops.rs:27:1 | -LL | const Z3: i32 = unsafe { *(44 as *const i32) }; //~ ERROR cannot be used +LL | const Z3: i32 = unsafe { *(44 as *const i32) }; //~ ERROR any use of this value will cause | ^^^^^^^^^^^^^^^^^^^^^^^^^-------------------^^^ | | | a memory access tried to interpret some bytes as a pointer diff --git a/src/test/ui/consts/const-eval/double_check2.stderr b/src/test/ui/consts/const-eval/double_check2.stderr index 21025877340..9dd7570232d 100644 --- a/src/test/ui/consts/const-eval/double_check2.stderr +++ b/src/test/ui/consts/const-eval/double_check2.stderr @@ -1,4 +1,4 @@ -error[E0080]: this static likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/double_check2.rs:25:1 | LL | / static FOO: (&Foo, &Bar) = unsafe {( //~ undefined behavior diff --git a/src/test/ui/consts/const-eval/infinite_loop.rs b/src/test/ui/consts/const-eval/infinite_loop.rs index a1f8ab7f878..d23b6250b4d 100644 --- a/src/test/ui/consts/const-eval/infinite_loop.rs +++ b/src/test/ui/consts/const-eval/infinite_loop.rs @@ -15,10 +15,10 @@ fn main() { // The value of `n` will loop indefinitely (4 - 2 - 1 - 4). let _ = [(); { //~^ WARNING Constant evaluating a complex constant, this might take some time - //~| ERROR could not evaluate repeat length let mut n = 113383; // #20 in https://oeis.org/A006884 while n != 0 { //~ ERROR constant contains unimplemented expression type n = if n % 2 == 0 { n/2 } else { 3*n + 1 }; + //~^ ERROR evaluation of constant value failed } n }]; diff --git a/src/test/ui/consts/const-eval/infinite_loop.stderr b/src/test/ui/consts/const-eval/infinite_loop.stderr index f69aae29203..2ff80e5efb5 100644 --- a/src/test/ui/consts/const-eval/infinite_loop.stderr +++ b/src/test/ui/consts/const-eval/infinite_loop.stderr @@ -1,8 +1,9 @@ error[E0019]: constant contains unimplemented expression type - --> $DIR/infinite_loop.rs:20:9 + --> $DIR/infinite_loop.rs:19:9 | LL | / while n != 0 { //~ ERROR constant contains unimplemented expression type LL | | n = if n % 2 == 0 { n/2 } else { 3*n + 1 }; +LL | | //~^ ERROR evaluation of constant value failed LL | | } | |_________^ @@ -12,28 +13,18 @@ warning: Constant evaluating a complex constant, this might take some time LL | let _ = [(); { | __________________^ LL | | //~^ WARNING Constant evaluating a complex constant, this might take some time -LL | | //~| ERROR could not evaluate repeat length LL | | let mut n = 113383; // #20 in https://oeis.org/A006884 +LL | | while n != 0 { //~ ERROR constant contains unimplemented expression type ... | LL | | n LL | | }]; | |_____^ -error[E0080]: could not evaluate repeat length - --> $DIR/infinite_loop.rs:16:18 +error[E0080]: evaluation of constant value failed + --> $DIR/infinite_loop.rs:20:20 | -LL | let _ = [(); { - | __________________^ -LL | | //~^ WARNING Constant evaluating a complex constant, this might take some time -LL | | //~| ERROR could not evaluate repeat length -LL | | let mut n = 113383; // #20 in https://oeis.org/A006884 -LL | | while n != 0 { //~ ERROR constant contains unimplemented expression type -LL | | n = if n % 2 == 0 { n/2 } else { 3*n + 1 }; - | | ---------- duplicate interpreter state observed here, const evaluation will never terminate -LL | | } -LL | | n -LL | | }]; - | |_____^ +LL | n = if n % 2 == 0 { n/2 } else { 3*n + 1 }; + | ^^^^^^^^^^ duplicate interpreter state observed here, const evaluation will never terminate error: aborting due to 2 previous errors diff --git a/src/test/ui/consts/const-eval/issue-43197.nll.stderr b/src/test/ui/consts/const-eval/issue-43197.nll.stderr new file mode 100644 index 00000000000..86a86922d3b --- /dev/null +++ b/src/test/ui/consts/const-eval/issue-43197.nll.stderr @@ -0,0 +1,43 @@ +warning: any use of this value will cause an error + --> $DIR/issue-43197.rs:20:5 + | +LL | const X: u32 = 0-1; + | ^^^^^^^^^^^^^^^---^ + | | + | attempt to subtract with overflow + | +note: lint level defined here + --> $DIR/issue-43197.rs:11:9 + | +LL | #![warn(const_err)] + | ^^^^^^^^^ + +warning: any use of this value will cause an error + --> $DIR/issue-43197.rs:22:5 + | +LL | const Y: u32 = foo(0-1); + | ^^^^^^^^^^^^^^^^^^^---^^ + | | + | attempt to subtract with overflow + +error[E0080]: evaluation of constant expression failed + --> $DIR/issue-43197.rs:24:14 + | +LL | println!("{} {}", X, Y); + | ^^^^^^^ - referenced constant has errors + +error[E0080]: evaluation of constant expression failed + --> $DIR/issue-43197.rs:24:26 + | +LL | println!("{} {}", X, Y); + | ^ referenced constant has errors + +error[E0080]: evaluation of constant expression failed + --> $DIR/issue-43197.rs:24:23 + | +LL | println!("{} {}", X, Y); + | ^ referenced constant has errors + +error: aborting due to 3 previous errors + +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/issue-43197.rs b/src/test/ui/consts/const-eval/issue-43197.rs index 6e60fd834d4..125b5e4d208 100644 --- a/src/test/ui/consts/const-eval/issue-43197.rs +++ b/src/test/ui/consts/const-eval/issue-43197.rs @@ -16,12 +16,10 @@ const fn foo(x: u32) -> u32 { fn main() { const X: u32 = 0-1; - //~^ WARN this constant cannot be used + //~^ WARN any use of this value will cause const Y: u32 = foo(0-1); - //~^ WARN this constant cannot be used + //~^ WARN any use of this value will cause println!("{} {}", X, Y); - //~^ ERROR erroneous constant used - //~| ERROR erroneous constant used - //~| ERROR E0080 - //~| ERROR E0080 + //~^ ERROR evaluation of constant expression failed + //~| ERROR evaluation of constant expression failed } diff --git a/src/test/ui/consts/const-eval/issue-43197.stderr b/src/test/ui/consts/const-eval/issue-43197.stderr index 6229790f8ad..95d43581830 100644 --- a/src/test/ui/consts/const-eval/issue-43197.stderr +++ b/src/test/ui/consts/const-eval/issue-43197.stderr @@ -1,5 +1,5 @@ -warning: this constant cannot be used - --> $DIR/issue-43197.rs:18:5 +warning: any use of this value will cause an error + --> $DIR/issue-43197.rs:20:5 | LL | const X: u32 = 0-1; | ^^^^^^^^^^^^^^^---^ @@ -12,44 +12,26 @@ note: lint level defined here LL | #![warn(const_err)] | ^^^^^^^^^ -warning: this constant cannot be used - --> $DIR/issue-43197.rs:20:5 +warning: any use of this value will cause an error + --> $DIR/issue-43197.rs:22:5 | LL | const Y: u32 = foo(0-1); | ^^^^^^^^^^^^^^^^^^^---^^ | | | attempt to subtract with overflow -error[E0080]: referenced constant has errors - --> $DIR/issue-43197.rs:22:26 - | -LL | const Y: u32 = foo(0-1); - | --- attempt to subtract with overflow -LL | //~^ WARN this constant cannot be used -LL | println!("{} {}", X, Y); - | ^ - -error[E0080]: erroneous constant used - --> $DIR/issue-43197.rs:22:26 +error[E0080]: evaluation of constant expression failed + --> $DIR/issue-43197.rs:24:26 | LL | println!("{} {}", X, Y); | ^ referenced constant has errors -error[E0080]: referenced constant has errors - --> $DIR/issue-43197.rs:22:23 - | -LL | const X: u32 = 0-1; - | --- attempt to subtract with overflow -... -LL | println!("{} {}", X, Y); - | ^ - -error[E0080]: erroneous constant used - --> $DIR/issue-43197.rs:22:23 +error[E0080]: evaluation of constant expression failed + --> $DIR/issue-43197.rs:24:23 | LL | println!("{} {}", X, Y); | ^ referenced constant has errors -error: aborting due to 4 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/issue-44578.nll.stderr b/src/test/ui/consts/const-eval/issue-44578.nll.stderr new file mode 100644 index 00000000000..71e06e36361 --- /dev/null +++ b/src/test/ui/consts/const-eval/issue-44578.nll.stderr @@ -0,0 +1,15 @@ +error[E0080]: evaluation of constant expression failed + --> $DIR/issue-44578.rs:35:14 + | +LL | println!("{}", as Foo>::AMT); + | ^^^^ -------------------------- referenced constant has errors + +error[E0080]: evaluation of constant expression failed + --> $DIR/issue-44578.rs:35:20 + | +LL | println!("{}", as Foo>::AMT); + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ referenced constant has errors + +error: aborting due to 2 previous errors + +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/issue-44578.rs b/src/test/ui/consts/const-eval/issue-44578.rs index 59ac4ab311c..9bd84b91d7f 100644 --- a/src/test/ui/consts/const-eval/issue-44578.rs +++ b/src/test/ui/consts/const-eval/issue-44578.rs @@ -33,6 +33,5 @@ impl Foo for u16 { fn main() { println!("{}", as Foo>::AMT); - //~^ ERROR erroneous constant used - //~| ERROR E0080 + //~^ ERROR E0080 } diff --git a/src/test/ui/consts/const-eval/issue-44578.stderr b/src/test/ui/consts/const-eval/issue-44578.stderr index 06174f37dca..570a8960164 100644 --- a/src/test/ui/consts/const-eval/issue-44578.stderr +++ b/src/test/ui/consts/const-eval/issue-44578.stderr @@ -1,18 +1,9 @@ -error[E0080]: referenced constant has errors - --> $DIR/issue-44578.rs:35:20 - | -LL | const AMT: usize = [A::AMT][(A::AMT > B::AMT) as usize]; - | ------------------------------------ index out of bounds: the len is 1 but the index is 1 -... -LL | println!("{}", as Foo>::AMT); - | ^^^^^^^^^^^^^^^^^^^^^^^^^^ - -error[E0080]: erroneous constant used +error[E0080]: evaluation of constant expression failed --> $DIR/issue-44578.rs:35:20 | LL | println!("{}", as Foo>::AMT); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ referenced constant has errors -error: aborting due to 2 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/issue-50814-2.rs b/src/test/ui/consts/const-eval/issue-50814-2.rs index af627ee5fbe..9a59ffd65ac 100644 --- a/src/test/ui/consts/const-eval/issue-50814-2.rs +++ b/src/test/ui/consts/const-eval/issue-50814-2.rs @@ -19,12 +19,11 @@ trait Foo { struct A(T); impl Foo for A { - const BAR: usize = [5, 6, 7][T::BOO]; + const BAR: usize = [5, 6, 7][T::BOO]; //~ ERROR any use of this value will cause an error } fn foo() -> &'static usize { - & as Foo>::BAR //~ ERROR erroneous constant used -//~| ERROR E0080 + & as Foo>::BAR //~ ERROR E0080 } impl C for () { diff --git a/src/test/ui/consts/const-eval/issue-50814-2.stderr b/src/test/ui/consts/const-eval/issue-50814-2.stderr index 1e37e949812..b36b3cf526c 100644 --- a/src/test/ui/consts/const-eval/issue-50814-2.stderr +++ b/src/test/ui/consts/const-eval/issue-50814-2.stderr @@ -1,16 +1,17 @@ -error[E0080]: referenced constant has errors - --> $DIR/issue-50814-2.rs:26:5 +error: any use of this value will cause an error + --> $DIR/issue-50814-2.rs:22:5 + | +LL | const BAR: usize = [5, 6, 7][T::BOO]; //~ ERROR any use of this value will cause an error + | ^^^^^^^^^^^^^^^^^^^-----------------^ + | | + | index out of bounds: the len is 3 but the index is 42 | -LL | const BAR: usize = [5, 6, 7][T::BOO]; - | ----------------- index out of bounds: the len is 3 but the index is 42 -... -LL | & as Foo>::BAR //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^^^^^^^^^^ + = note: #[deny(const_err)] on by default -error[E0080]: erroneous constant used +error[E0080]: evaluation of constant expression failed --> $DIR/issue-50814-2.rs:26:5 | -LL | & as Foo>::BAR //~ ERROR erroneous constant used +LL | & as Foo>::BAR //~ ERROR E0080 | ^--------------------- | | | referenced constant has errors diff --git a/src/test/ui/consts/const-eval/issue-50814.rs b/src/test/ui/consts/const-eval/issue-50814.rs index 8f2752453b5..3c7f1826449 100644 --- a/src/test/ui/consts/const-eval/issue-50814.rs +++ b/src/test/ui/consts/const-eval/issue-50814.rs @@ -20,12 +20,11 @@ impl Unsigned for U8 { struct Sum(A,B); impl Unsigned for Sum { - const MAX: u8 = A::MAX + B::MAX; + const MAX: u8 = A::MAX + B::MAX; //~ ERROR any use of this value will cause an error } fn foo(_: T) -> &'static u8 { - &Sum::::MAX //~ ERROR erroneous constant used -//~| ERROR E0080 + &Sum::::MAX //~ ERROR E0080 } fn main() { diff --git a/src/test/ui/consts/const-eval/issue-50814.stderr b/src/test/ui/consts/const-eval/issue-50814.stderr index 16160207c57..ebd0e34ab7e 100644 --- a/src/test/ui/consts/const-eval/issue-50814.stderr +++ b/src/test/ui/consts/const-eval/issue-50814.stderr @@ -1,16 +1,17 @@ -error[E0080]: referenced constant has errors - --> $DIR/issue-50814.rs:27:5 +error: any use of this value will cause an error + --> $DIR/issue-50814.rs:23:5 + | +LL | const MAX: u8 = A::MAX + B::MAX; //~ ERROR any use of this value will cause an error + | ^^^^^^^^^^^^^^^^---------------^ + | | + | attempt to add with overflow | -LL | const MAX: u8 = A::MAX + B::MAX; - | --------------- attempt to add with overflow -... -LL | &Sum::::MAX //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^^^^^^ + = note: #[deny(const_err)] on by default -error[E0080]: erroneous constant used +error[E0080]: evaluation of constant expression failed --> $DIR/issue-50814.rs:27:5 | -LL | &Sum::::MAX //~ ERROR erroneous constant used +LL | &Sum::::MAX //~ ERROR E0080 | ^----------------- | | | referenced constant has errors diff --git a/src/test/ui/consts/const-eval/issue-52443.stderr b/src/test/ui/consts/const-eval/issue-52443.stderr new file mode 100644 index 00000000000..807a70dd201 --- /dev/null +++ b/src/test/ui/consts/const-eval/issue-52443.stderr @@ -0,0 +1,49 @@ +error[E0308]: mismatched types + --> $DIR/issue-52443.rs:12:10 + | +LL | [(); & { loop { continue } } ]; //~ ERROR mismatched types + | ^^^^^^^^^^^^^^^^^^^^^^^ + | | + | expected usize, found reference + | help: consider removing the borrow: `{ loop { continue } }` + | + = note: expected type `usize` + found type `&_` + +error[E0308]: mismatched types + --> $DIR/issue-52443.rs:13:17 + | +LL | [(); loop { break }]; //~ ERROR mismatched types + | ^^^^^ expected (), found usize + | + = note: expected type `()` + found type `usize` + +error[E0019]: constant contains unimplemented expression type + --> $DIR/issue-52443.rs:14:11 + | +LL | [(); {while true {break}; 0}]; //~ ERROR constant contains unimplemented expression type + | ^^^^^^^^^^^^^^^^^^ + +error[E0015]: calls in constants are limited to constant functions, tuple structs and tuple variants + --> $DIR/issue-52443.rs:15:21 + | +LL | [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions + | ^^^^^^^^ + +error[E0019]: constant contains unimplemented expression type + --> $DIR/issue-52443.rs:15:21 + | +LL | [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions + | ^^^^^^^^ + +error[E0080]: evaluation of constant value failed + --> $DIR/issue-52443.rs:15:21 + | +LL | [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions + | ^^^^^^^^ calling non-const fn `>::into_iter` + +error: aborting due to 6 previous errors + +Some errors occurred: E0015, E0019, E0080, E0308. +For more information about an error, try `rustc --explain E0015`. diff --git a/src/test/ui/consts/const-eval/match-test-ptr-null.rs b/src/test/ui/consts/const-eval/match-test-ptr-null.rs index 81fcd23fb78..1a3164b0b03 100644 --- a/src/test/ui/consts/const-eval/match-test-ptr-null.rs +++ b/src/test/ui/consts/const-eval/match-test-ptr-null.rs @@ -12,10 +12,11 @@ fn main() { // Make sure match uses the usual pointer comparison code path -- i.e., it should complain // that pointer comparison is disallowed, not that parts of a pointer are accessed as raw // bytes. - let _: [u8; 0] = [4; { //~ ERROR could not evaluate repeat length + let _: [u8; 0] = [4; { match &1 as *const i32 as usize { //~ ERROR casting pointers to integers in constants 0 => 42, //~ ERROR constant contains unimplemented expression type //~^ NOTE "pointer arithmetic or comparison" needs an rfc before being allowed + //~| ERROR evaluation of constant value failed n => n, } }]; diff --git a/src/test/ui/consts/const-eval/match-test-ptr-null.stderr b/src/test/ui/consts/const-eval/match-test-ptr-null.stderr index 26577948fae..86812b6c493 100644 --- a/src/test/ui/consts/const-eval/match-test-ptr-null.stderr +++ b/src/test/ui/consts/const-eval/match-test-ptr-null.stderr @@ -12,19 +12,11 @@ error[E0019]: constant contains unimplemented expression type LL | 0 => 42, //~ ERROR constant contains unimplemented expression type | ^ -error[E0080]: could not evaluate repeat length - --> $DIR/match-test-ptr-null.rs:15:26 +error[E0080]: evaluation of constant value failed + --> $DIR/match-test-ptr-null.rs:17:13 | -LL | let _: [u8; 0] = [4; { //~ ERROR could not evaluate repeat length - | __________________________^ -LL | | match &1 as *const i32 as usize { //~ ERROR casting pointers to integers in constants -LL | | 0 => 42, //~ ERROR constant contains unimplemented expression type - | | - "pointer arithmetic or comparison" needs an rfc before being allowed inside constants -LL | | //~^ NOTE "pointer arithmetic or comparison" needs an rfc before being allowed -LL | | n => n, -LL | | } -LL | | }]; - | |_____^ +LL | 0 => 42, //~ ERROR constant contains unimplemented expression type + | ^ "pointer arithmetic or comparison" needs an rfc before being allowed inside constants error: aborting due to 3 previous errors diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail.rs b/src/test/ui/consts/const-eval/promoted_const_fn_fail.rs index 9b03ddd1891..aa6cd888018 100644 --- a/src/test/ui/consts/const-eval/promoted_const_fn_fail.rs +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail.rs @@ -10,7 +10,7 @@ #![feature(const_fn, const_fn_union)] -#![deny(const_err)] +#![allow(const_err)] union Bar { a: &'static u8, diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs new file mode 100644 index 00000000000..9f19e68f2a8 --- /dev/null +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs @@ -0,0 +1,36 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(const_fn, const_fn_union)] + +#![deny(const_err)] + +union Bar { + a: &'static u8, + b: usize, +} + +const fn bar() -> u8 { + unsafe { + // this will error as long as this test + // is run on a system whose pointers need more + // than 8 bits + Bar { a: &42 }.b as u8 + } +} + +fn main() { + // FIXME(oli-obk): this should panic at runtime + // this will actually compile, but then + // abort at runtime (not panic, hard abort). + let x: &'static u8 = &(bar() + 1); + let y = *x; + unreachable!(); +} diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr new file mode 100644 index 00000000000..3eeacbf842a --- /dev/null +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr @@ -0,0 +1,19 @@ +error: reaching this expression at runtime will panic or abort + --> $DIR/promoted_const_fn_fail_deny_const_err.rs:33:26 + | +LL | Bar { a: &42 }.b as u8 + | ---------------------- a raw memory access tried to access part of a pointer value as raw bytes +... +LL | let x: &'static u8 = &(bar() + 1); + | ^^-----^^^^^ + | | + | inside call to `bar` + | +note: lint level defined here + --> $DIR/promoted_const_fn_fail_deny_const_err.rs:13:9 + | +LL | #![deny(const_err)] + | ^^^^^^^^^ + +error: aborting due to previous error + diff --git a/src/test/ui/consts/const-eval/promoted_errors.stderr b/src/test/ui/consts/const-eval/promoted_errors.stderr index 85b5696be94..26499fcb9b5 100644 --- a/src/test/ui/consts/const-eval/promoted_errors.stderr +++ b/src/test/ui/consts/const-eval/promoted_errors.stderr @@ -46,3 +46,15 @@ warning: this expression will panic at runtime LL | let _x = 1/(false as u32); | ^^^^^^^^^^^^^^^^ attempt to divide by zero +warning: reaching this expression at runtime will panic or abort + --> $DIR/promoted_errors.rs:24:20 + | +LL | println!("{}", 1/(false as u32)); + | ^^^^^^^^^^^^^^^^ attempt to divide by zero + +warning: reaching this expression at runtime will panic or abort + --> $DIR/promoted_errors.rs:19:20 + | +LL | println!("{}", 1/(1-1)); + | ^^^^^^^ attempt to divide by zero + diff --git a/src/test/ui/consts/const-eval/pub_const_err.rs b/src/test/ui/consts/const-eval/pub_const_err.rs index b7cfa949bac..48c172b5e31 100644 --- a/src/test/ui/consts/const-eval/pub_const_err.rs +++ b/src/test/ui/consts/const-eval/pub_const_err.rs @@ -14,7 +14,7 @@ #![crate_type = "lib"] pub const Z: u32 = 0 - 1; -//~^ WARN this constant cannot be used +//~^ WARN any use of this value will cause an error pub type Foo = [i32; 0 - 1]; //~^ WARN attempt to subtract with overflow diff --git a/src/test/ui/consts/const-eval/pub_const_err.stderr b/src/test/ui/consts/const-eval/pub_const_err.stderr index fa3a79a5f17..2194180c2ef 100644 --- a/src/test/ui/consts/const-eval/pub_const_err.stderr +++ b/src/test/ui/consts/const-eval/pub_const_err.stderr @@ -1,4 +1,4 @@ -warning: this constant cannot be used +warning: any use of this value will cause an error --> $DIR/pub_const_err.rs:16:1 | LL | pub const Z: u32 = 0 - 1; @@ -12,15 +12,3 @@ note: lint level defined here LL | #![warn(const_err)] | ^^^^^^^^^ -warning: attempt to subtract with overflow - --> $DIR/pub_const_err.rs:19:22 - | -LL | pub type Foo = [i32; 0 - 1]; - | ^^^^^ - -warning: this array length cannot be used - --> $DIR/pub_const_err.rs:19:22 - | -LL | pub type Foo = [i32; 0 - 1]; - | ^^^^^ attempt to subtract with overflow - diff --git a/src/test/ui/consts/const-eval/pub_const_err_bin.rs b/src/test/ui/consts/const-eval/pub_const_err_bin.rs index bafa5b2f4da..849d40cf107 100644 --- a/src/test/ui/consts/const-eval/pub_const_err_bin.rs +++ b/src/test/ui/consts/const-eval/pub_const_err_bin.rs @@ -12,7 +12,7 @@ #![warn(const_err)] pub const Z: u32 = 0 - 1; -//~^ WARN this constant cannot be used +//~^ WARN any use of this value will cause an error pub type Foo = [i32; 0 - 1]; //~^ WARN attempt to subtract with overflow diff --git a/src/test/ui/consts/const-eval/pub_const_err_bin.stderr b/src/test/ui/consts/const-eval/pub_const_err_bin.stderr index 73229c60d14..60834e00650 100644 --- a/src/test/ui/consts/const-eval/pub_const_err_bin.stderr +++ b/src/test/ui/consts/const-eval/pub_const_err_bin.stderr @@ -1,4 +1,4 @@ -warning: this constant cannot be used +warning: any use of this value will cause an error --> $DIR/pub_const_err_bin.rs:14:1 | LL | pub const Z: u32 = 0 - 1; @@ -12,15 +12,3 @@ note: lint level defined here LL | #![warn(const_err)] | ^^^^^^^^^ -warning: attempt to subtract with overflow - --> $DIR/pub_const_err_bin.rs:17:22 - | -LL | pub type Foo = [i32; 0 - 1]; - | ^^^^^ - -warning: this array length cannot be used - --> $DIR/pub_const_err_bin.rs:17:22 - | -LL | pub type Foo = [i32; 0 - 1]; - | ^^^^^ attempt to subtract with overflow - diff --git a/src/test/ui/consts/const-eval/shift_overflow.stderr b/src/test/ui/consts/const-eval/shift_overflow.stderr index 00a748249ea..f1d30394d38 100644 --- a/src/test/ui/consts/const-eval/shift_overflow.stderr +++ b/src/test/ui/consts/const-eval/shift_overflow.stderr @@ -1,4 +1,4 @@ -error[E0080]: could not evaluate enum discriminant +error[E0080]: evaluation of constant value failed --> $DIR/shift_overflow.rs:13:9 | LL | X = 1 << ((u32::max_value() as u64) + 1), //~ ERROR E0080 diff --git a/src/test/ui/consts/const-eval/ub-enum.rs b/src/test/ui/consts/const-eval/ub-enum.rs index bcb71af54af..2f7a5dda9ff 100644 --- a/src/test/ui/consts/const-eval/ub-enum.rs +++ b/src/test/ui/consts/const-eval/ub-enum.rs @@ -20,7 +20,7 @@ union TransmuteEnum { // A pointer is guaranteed non-null const BAD_ENUM: Enum = unsafe { TransmuteEnum { a: &1 }.b }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR is undefined behavior // Invalid enum discriminant #[repr(usize)] @@ -33,7 +33,7 @@ union TransmuteEnum2 { b: Enum2, } const BAD_ENUM2 : Enum2 = unsafe { TransmuteEnum2 { a: 0 }.b }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR is undefined behavior // Invalid enum field content (mostly to test printing of apths for enum tuple // variants and tuples). @@ -43,7 +43,7 @@ union TransmuteChar { } // Need to create something which does not clash with enum layout optimizations. const BAD_ENUM_CHAR : Option<(char, char)> = Some(('x', unsafe { TransmuteChar { a: !0 }.b })); -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR is undefined behavior fn main() { } diff --git a/src/test/ui/consts/const-eval/ub-enum.stderr b/src/test/ui/consts/const-eval/ub-enum.stderr index 243343c94b0..4cbaa2f3a90 100644 --- a/src/test/ui/consts/const-eval/ub-enum.stderr +++ b/src/test/ui/consts/const-eval/ub-enum.stderr @@ -1,4 +1,4 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-enum.rs:22:1 | LL | const BAD_ENUM: Enum = unsafe { TransmuteEnum { a: &1 }.b }; @@ -6,7 +6,7 @@ LL | const BAD_ENUM: Enum = unsafe { TransmuteEnum { a: &1 }.b }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-enum.rs:35:1 | LL | const BAD_ENUM2 : Enum2 = unsafe { TransmuteEnum2 { a: 0 }.b }; @@ -14,7 +14,7 @@ LL | const BAD_ENUM2 : Enum2 = unsafe { TransmuteEnum2 { a: 0 }.b }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-enum.rs:45:1 | LL | const BAD_ENUM_CHAR : Option<(char, char)> = Some(('x', unsafe { TransmuteChar { a: !0 }.b })); diff --git a/src/test/ui/consts/const-eval/union-const-eval-field.rs b/src/test/ui/consts/const-eval/union-const-eval-field.rs index 5723f4a4159..40d1f97a807 100644 --- a/src/test/ui/consts/const-eval/union-const-eval-field.rs +++ b/src/test/ui/consts/const-eval/union-const-eval-field.rs @@ -34,12 +34,15 @@ const fn read_field2() -> Field2 { } const fn read_field3() -> Field3 { - const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR cannot be used + const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of this value + //~^ ERROR any use of this value FIELD3 + //~^ erroneous constant used } fn main() { assert_eq!(read_field1(), FLOAT1_AS_I32); assert_eq!(read_field2(), 1.0); assert_eq!(read_field3(), unsafe { UNION.field3 }); + //~^ ERROR evaluation of constant expression failed } diff --git a/src/test/ui/consts/const-eval/union-const-eval-field.stderr b/src/test/ui/consts/const-eval/union-const-eval-field.stderr index 811450c8cba..39320791a3f 100644 --- a/src/test/ui/consts/const-eval/union-const-eval-field.stderr +++ b/src/test/ui/consts/const-eval/union-const-eval-field.stderr @@ -1,10 +1,36 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/union-const-eval-field.rs:37:5 | -LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR cannot be used +LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of this value | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempted to read undefined bytes | = note: #[deny(const_err)] on by default -error: aborting due to previous error +error: any use of this value will cause an error + --> $DIR/union-const-eval-field.rs:37:5 + | +LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of this value + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempted to read undefined bytes + +error[E0080]: erroneous constant used + --> $DIR/union-const-eval-field.rs:39:5 + | +LL | FIELD3 + | ^^^^^^ referenced constant has errors + +error[E0080]: evaluation of constant expression failed + --> $DIR/union-const-eval-field.rs:46:5 + | +LL | FIELD3 + | ------ referenced constant has errors +... +LL | assert_eq!(read_field3(), unsafe { UNION.field3 }); + | ^^^^^^^^^^^-------------^^^^^^^^^^^^^^^^^^^^^^^^^^^ + | | + | inside call to `read_field3` + | + = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) + +error: aborting due to 4 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/union-ice.rs b/src/test/ui/consts/const-eval/union-ice.rs index 5d50004e554..5a8ea711d86 100644 --- a/src/test/ui/consts/const-eval/union-ice.rs +++ b/src/test/ui/consts/const-eval/union-ice.rs @@ -20,9 +20,9 @@ union DummyUnion { const UNION: DummyUnion = DummyUnion { field1: 1065353216 }; -const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR this constant cannot be used +const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR will cause an error -const FIELD_PATH: Struct = Struct { //~ ERROR this constant likely exhibits undefined behavior +const FIELD_PATH: Struct = Struct { //~ ERROR any use of this value will cause an error a: 42, b: unsafe { UNION.field3 }, }; @@ -32,7 +32,7 @@ struct Struct { b: Field3, } -const FIELD_PATH2: Struct2 = Struct2 { //~ ERROR this constant likely exhibits undefined behavior +const FIELD_PATH2: Struct2 = Struct2 { //~ ERROR it is undefined behavior to use this value b: [ 21, unsafe { UNION.field3 }, diff --git a/src/test/ui/consts/const-eval/union-ice.stderr b/src/test/ui/consts/const-eval/union-ice.stderr index 4484dd6a147..7f5cb731c8e 100644 --- a/src/test/ui/consts/const-eval/union-ice.stderr +++ b/src/test/ui/consts/const-eval/union-ice.stderr @@ -1,15 +1,15 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/union-ice.rs:23:1 | -LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR this constant cannot be used +LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR will cause an error | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempted to read undefined bytes | = note: #[deny(const_err)] on by default -error[E0080]: this constant likely exhibits undefined behavior +error: any use of this value will cause an error --> $DIR/union-ice.rs:25:1 | -LL | / const FIELD_PATH: Struct = Struct { //~ ERROR this constant likely exhibits undefined behavior +LL | / const FIELD_PATH: Struct = Struct { //~ ERROR any use of this value will cause an error LL | | a: 42, LL | | b: unsafe { UNION.field3 }, LL | | }; @@ -17,10 +17,10 @@ LL | | }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ice.rs:35:1 | -LL | / const FIELD_PATH2: Struct2 = Struct2 { //~ ERROR this constant likely exhibits undefined behavior +LL | / const FIELD_PATH2: Struct2 = Struct2 { //~ ERROR it is undefined behavior to use this value LL | | b: [ LL | | 21, LL | | unsafe { UNION.field3 }, diff --git a/src/test/ui/consts/const-eval/union-ub-fat-ptr.rs b/src/test/ui/consts/const-eval/union-ub-fat-ptr.rs index 0c42d28eb00..479cee92b94 100644 --- a/src/test/ui/consts/const-eval/union-ub-fat-ptr.rs +++ b/src/test/ui/consts/const-eval/union-ub-fat-ptr.rs @@ -85,55 +85,56 @@ type MySliceBool = MySlice<[bool]>; const A: &str = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len: 1 } }.str}; // bad str const B: &str = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len: 999 } }.str}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad str const C: &str = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, len: &3 } }.str}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad str in user-defined unsized type const C2: &MyStr = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, len: &3 } }.my_str}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // OK const A2: &[u8] = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len: 1 } }.slice}; // bad slice const B2: &[u8] = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len: 999 } }.slice}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad slice const C3: &[u8] = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, len: &3 } }.slice}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad trait object const D: &Trait = unsafe { DynTransmute { repr: DynRepr { ptr: &92, vtable: &3 } }.rust}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad trait object const E: &Trait = unsafe { DynTransmute { repr2: DynRepr2 { ptr: &92, vtable: &3 } }.rust}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad trait object const F: &Trait = unsafe { DynTransmute { bad: BadDynRepr { ptr: &92, vtable: 3 } }.rust}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad data *inside* the trait object const G: &Trait = &unsafe { BoolTransmute { val: 3 }.bl }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value + // bad data *inside* the slice const H: &[bool] = &[unsafe { BoolTransmute { val: 3 }.bl }]; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // good MySliceBool const I1: &MySliceBool = &MySlice(true, [false]); // bad: sized field is not okay const I2: &MySliceBool = &MySlice(unsafe { BoolTransmute { val: 3 }.bl }, [false]); -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // bad: unsized part is not okay const I3: &MySliceBool = &MySlice(true, [unsafe { BoolTransmute { val: 3 }.bl }]); -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // invalid UTF-8 const J1: &str = unsafe { SliceTransmute { slice: &[0xFF] }.str }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // invalid UTF-8 in user-defined str-like const J2: &MyStr = unsafe { SliceTransmute { slice: &[0xFF] }.my_str }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value fn main() { } diff --git a/src/test/ui/consts/const-eval/union-ub-fat-ptr.stderr b/src/test/ui/consts/const-eval/union-ub-fat-ptr.stderr index c4632ffe309..b61ea9ca6f9 100644 --- a/src/test/ui/consts/const-eval/union-ub-fat-ptr.stderr +++ b/src/test/ui/consts/const-eval/union-ub-fat-ptr.stderr @@ -1,4 +1,4 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:87:1 | LL | const B: &str = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len: 999 } }.str}; @@ -6,7 +6,7 @@ LL | const B: &str = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len: | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:90:1 | LL | const C: &str = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, len: &3 } }.str}; @@ -14,7 +14,7 @@ LL | const C: &str = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, len | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:93:1 | LL | const C2: &MyStr = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, len: &3 } }.my_str}; @@ -22,7 +22,7 @@ LL | const C2: &MyStr = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:99:1 | LL | const B2: &[u8] = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len: 999 } }.slice}; @@ -30,7 +30,7 @@ LL | const B2: &[u8] = unsafe { SliceTransmute { repr: SliceRepr { ptr: &42, len | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:102:1 | LL | const C3: &[u8] = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, len: &3 } }.slice}; @@ -38,7 +38,7 @@ LL | const C3: &[u8] = unsafe { SliceTransmute { bad: BadSliceRepr { ptr: &42, l | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:106:1 | LL | const D: &Trait = unsafe { DynTransmute { repr: DynRepr { ptr: &92, vtable: &3 } }.rust}; @@ -46,7 +46,7 @@ LL | const D: &Trait = unsafe { DynTransmute { repr: DynRepr { ptr: &92, vtable: | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:109:1 | LL | const E: &Trait = unsafe { DynTransmute { repr2: DynRepr2 { ptr: &92, vtable: &3 } }.rust}; @@ -54,7 +54,7 @@ LL | const E: &Trait = unsafe { DynTransmute { repr2: DynRepr2 { ptr: &92, vtabl | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:112:1 | LL | const F: &Trait = unsafe { DynTransmute { bad: BadDynRepr { ptr: &92, vtable: 3 } }.rust}; @@ -62,7 +62,7 @@ LL | const F: &Trait = unsafe { DynTransmute { bad: BadDynRepr { ptr: &92, vtabl | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub-fat-ptr.rs:116:1 | LL | const G: &Trait = &unsafe { BoolTransmute { val: 3 }.bl }; @@ -70,40 +70,40 @@ LL | const G: &Trait = &unsafe { BoolTransmute { val: 3 }.bl }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior - --> $DIR/union-ub-fat-ptr.rs:119:1 +error[E0080]: it is undefined behavior to use this value + --> $DIR/union-ub-fat-ptr.rs:120:1 | LL | const H: &[bool] = &[unsafe { BoolTransmute { val: 3 }.bl }]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered 3 at .[0], but expected something in the range 0..=1 | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior - --> $DIR/union-ub-fat-ptr.rs:125:1 +error[E0080]: it is undefined behavior to use this value + --> $DIR/union-ub-fat-ptr.rs:126:1 | LL | const I2: &MySliceBool = &MySlice(unsafe { BoolTransmute { val: 3 }.bl }, [false]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered 3 at ..0, but expected something in the range 0..=1 | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior - --> $DIR/union-ub-fat-ptr.rs:128:1 +error[E0080]: it is undefined behavior to use this value + --> $DIR/union-ub-fat-ptr.rs:129:1 | LL | const I3: &MySliceBool = &MySlice(true, [unsafe { BoolTransmute { val: 3 }.bl }]); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered 3 at ..1[0], but expected something in the range 0..=1 | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior - --> $DIR/union-ub-fat-ptr.rs:132:1 +error[E0080]: it is undefined behavior to use this value + --> $DIR/union-ub-fat-ptr.rs:133:1 | LL | const J1: &str = unsafe { SliceTransmute { slice: &[0xFF] }.str }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered uninitialized or non-UTF-8 data in str at . | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior - --> $DIR/union-ub-fat-ptr.rs:135:1 +error[E0080]: it is undefined behavior to use this value + --> $DIR/union-ub-fat-ptr.rs:136:1 | LL | const J2: &MyStr = unsafe { SliceTransmute { slice: &[0xFF] }.my_str }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered uninitialized or non-UTF-8 data in str at ..0 diff --git a/src/test/ui/consts/const-eval/union-ub.rs b/src/test/ui/consts/const-eval/union-ub.rs index 86b3bdaa6b7..008f1f23648 100644 --- a/src/test/ui/consts/const-eval/union-ub.rs +++ b/src/test/ui/consts/const-eval/union-ub.rs @@ -34,7 +34,7 @@ union Bar { // the value is not valid for bools const BAD_BOOL: bool = unsafe { DummyUnion { u8: 42 }.bool}; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value // The value is not valid for any union variant, but that's fine // unions are just a convenient way to transmute bits around diff --git a/src/test/ui/consts/const-eval/union-ub.stderr b/src/test/ui/consts/const-eval/union-ub.stderr index 2a04dae337b..bb916ddbbcf 100644 --- a/src/test/ui/consts/const-eval/union-ub.stderr +++ b/src/test/ui/consts/const-eval/union-ub.stderr @@ -1,4 +1,4 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ub.rs:36:1 | LL | const BAD_BOOL: bool = unsafe { DummyUnion { u8: 42 }.bool}; diff --git a/src/test/ui/consts/const-fn-error.stderr b/src/test/ui/consts/const-fn-error.stderr new file mode 100644 index 00000000000..a7b757f2d00 --- /dev/null +++ b/src/test/ui/consts/const-fn-error.stderr @@ -0,0 +1,41 @@ +error[E0658]: let bindings in constant functions are unstable (see issue #48821) + --> $DIR/const-fn-error.rs:16:19 + | +LL | let mut sum = 0; + | ^ + | + = help: add #![feature(const_let)] to the crate attributes to enable + +error[E0658]: statements in constant functions are unstable (see issue #48821) + --> $DIR/const-fn-error.rs:16:19 + | +LL | let mut sum = 0; + | ^ + | + = help: add #![feature(const_let)] to the crate attributes to enable + +error[E0015]: calls in constant functions are limited to constant functions, tuple structs and tuple variants + --> $DIR/const-fn-error.rs:19:14 + | +LL | for i in 0..x { //~ ERROR E0080 + | ^^^^ + +error[E0019]: constant function contains unimplemented expression type + --> $DIR/const-fn-error.rs:19:14 + | +LL | for i in 0..x { //~ ERROR E0080 + | ^^^^ + +error[E0080]: evaluation of constant value failed + --> $DIR/const-fn-error.rs:19:14 + | +LL | for i in 0..x { //~ ERROR E0080 + | ^^^^ calling non-const fn `>::into_iter` +... +LL | let a : [i32; f(X)]; + | ---- inside call to `f` + +error: aborting due to 5 previous errors + +Some errors occurred: E0015, E0019, E0080, E0658. +For more information about an error, try `rustc --explain E0015`. diff --git a/src/test/ui/consts/const-integer-bool-ops.rs b/src/test/ui/consts/const-integer-bool-ops.rs index 29bc665a22e..5f0829eb358 100644 --- a/src/test/ui/consts/const-integer-bool-ops.rs +++ b/src/test/ui/consts/const-integer-bool-ops.rs @@ -16,6 +16,7 @@ const X: usize = 42 && 39; //~| ERROR mismatched types //~| expected usize, found bool const ARR: [i32; X] = [99; 34]; +//~^ ERROR evaluation of constant value failed const X1: usize = 42 || 39; //~^ ERROR mismatched types @@ -25,6 +26,7 @@ const X1: usize = 42 || 39; //~| ERROR mismatched types //~| expected usize, found bool const ARR1: [i32; X1] = [99; 47]; +//~^ ERROR evaluation of constant value failed const X2: usize = -42 || -39; //~^ ERROR mismatched types @@ -34,6 +36,7 @@ const X2: usize = -42 || -39; //~| ERROR mismatched types //~| expected usize, found bool const ARR2: [i32; X2] = [99; 18446744073709551607]; +//~^ ERROR evaluation of constant value failed const X3: usize = -42 && -39; //~^ ERROR mismatched types @@ -43,36 +46,43 @@ const X3: usize = -42 && -39; //~| ERROR mismatched types //~| expected usize, found bool const ARR3: [i32; X3] = [99; 6]; +//~^ ERROR evaluation of constant value failed const Y: usize = 42.0 == 42.0; //~^ ERROR mismatched types //~| expected usize, found bool const ARRR: [i32; Y] = [99; 1]; +//~^ ERROR evaluation of constant value failed const Y1: usize = 42.0 >= 42.0; //~^ ERROR mismatched types //~| expected usize, found bool const ARRR1: [i32; Y1] = [99; 1]; +//~^ ERROR evaluation of constant value failed const Y2: usize = 42.0 <= 42.0; //~^ ERROR mismatched types //~| expected usize, found bool const ARRR2: [i32; Y2] = [99; 1]; +//~^ ERROR evaluation of constant value failed const Y3: usize = 42.0 > 42.0; //~^ ERROR mismatched types //~| expected usize, found bool const ARRR3: [i32; Y3] = [99; 0]; +//~^ ERROR evaluation of constant value failed const Y4: usize = 42.0 < 42.0; //~^ ERROR mismatched types //~| expected usize, found bool const ARRR4: [i32; Y4] = [99; 0]; +//~^ ERROR evaluation of constant value failed const Y5: usize = 42.0 != 42.0; //~^ ERROR mismatched types //~| expected usize, found bool const ARRR5: [i32; Y5] = [99; 0]; +//~^ ERROR evaluation of constant value failed fn main() { let _ = ARR; diff --git a/src/test/ui/consts/const-integer-bool-ops.stderr b/src/test/ui/consts/const-integer-bool-ops.stderr index 8075a3f0863..1bcb3ea719d 100644 --- a/src/test/ui/consts/const-integer-bool-ops.stderr +++ b/src/test/ui/consts/const-integer-bool-ops.stderr @@ -22,8 +22,14 @@ error[E0308]: mismatched types LL | const X: usize = 42 && 39; | ^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:18:18 + | +LL | const ARR: [i32; X] = [99; 34]; + | ^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:20:19 + --> $DIR/const-integer-bool-ops.rs:21:19 | LL | const X1: usize = 42 || 39; | ^^ expected bool, found integral variable @@ -32,7 +38,7 @@ LL | const X1: usize = 42 || 39; found type `{integer}` error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:20:25 + --> $DIR/const-integer-bool-ops.rs:21:25 | LL | const X1: usize = 42 || 39; | ^^ expected bool, found integral variable @@ -41,13 +47,19 @@ LL | const X1: usize = 42 || 39; found type `{integer}` error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:20:19 + --> $DIR/const-integer-bool-ops.rs:21:19 | LL | const X1: usize = 42 || 39; | ^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:28:19 + | +LL | const ARR1: [i32; X1] = [99; 47]; + | ^^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:29:19 + --> $DIR/const-integer-bool-ops.rs:31:19 | LL | const X2: usize = -42 || -39; | ^^^ expected bool, found integral variable @@ -56,7 +68,7 @@ LL | const X2: usize = -42 || -39; found type `{integer}` error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:29:26 + --> $DIR/const-integer-bool-ops.rs:31:26 | LL | const X2: usize = -42 || -39; | ^^^ expected bool, found integral variable @@ -65,14 +77,20 @@ LL | const X2: usize = -42 || -39; found type `{integer}` error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:29:19 + --> $DIR/const-integer-bool-ops.rs:31:19 | LL | const X2: usize = -42 || -39; | ^^^^^^^^^^ expected usize, found bool -error[E0308]: mismatched types +error[E0080]: evaluation of constant value failed --> $DIR/const-integer-bool-ops.rs:38:19 | +LL | const ARR2: [i32; X2] = [99; 18446744073709551607]; + | ^^ referenced constant has errors + +error[E0308]: mismatched types + --> $DIR/const-integer-bool-ops.rs:41:19 + | LL | const X3: usize = -42 && -39; | ^^^ expected bool, found integral variable | @@ -80,7 +98,7 @@ LL | const X3: usize = -42 && -39; found type `{integer}` error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:38:26 + --> $DIR/const-integer-bool-ops.rs:41:26 | LL | const X3: usize = -42 && -39; | ^^^ expected bool, found integral variable @@ -89,47 +107,90 @@ LL | const X3: usize = -42 && -39; found type `{integer}` error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:38:19 + --> $DIR/const-integer-bool-ops.rs:41:19 | LL | const X3: usize = -42 && -39; | ^^^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:48:19 + | +LL | const ARR3: [i32; X3] = [99; 6]; + | ^^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:47:18 + --> $DIR/const-integer-bool-ops.rs:51:18 | LL | const Y: usize = 42.0 == 42.0; | ^^^^^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:54:19 + | +LL | const ARRR: [i32; Y] = [99; 1]; + | ^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:52:19 + --> $DIR/const-integer-bool-ops.rs:57:19 | LL | const Y1: usize = 42.0 >= 42.0; | ^^^^^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:60:20 + | +LL | const ARRR1: [i32; Y1] = [99; 1]; + | ^^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:57:19 + --> $DIR/const-integer-bool-ops.rs:63:19 | LL | const Y2: usize = 42.0 <= 42.0; | ^^^^^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:66:20 + | +LL | const ARRR2: [i32; Y2] = [99; 1]; + | ^^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:62:19 + --> $DIR/const-integer-bool-ops.rs:69:19 | LL | const Y3: usize = 42.0 > 42.0; | ^^^^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:72:20 + | +LL | const ARRR3: [i32; Y3] = [99; 0]; + | ^^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:67:19 + --> $DIR/const-integer-bool-ops.rs:75:19 | LL | const Y4: usize = 42.0 < 42.0; | ^^^^^^^^^^^ expected usize, found bool +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:78:20 + | +LL | const ARRR4: [i32; Y4] = [99; 0]; + | ^^ referenced constant has errors + error[E0308]: mismatched types - --> $DIR/const-integer-bool-ops.rs:72:19 + --> $DIR/const-integer-bool-ops.rs:81:19 | LL | const Y5: usize = 42.0 != 42.0; | ^^^^^^^^^^^^ expected usize, found bool -error: aborting due to 18 previous errors +error[E0080]: evaluation of constant value failed + --> $DIR/const-integer-bool-ops.rs:84:20 + | +LL | const ARRR5: [i32; Y5] = [99; 0]; + | ^^ referenced constant has errors + +error: aborting due to 28 previous errors -For more information about this error, try `rustc --explain E0308`. +Some errors occurred: E0080, E0308. +For more information about an error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-len-underflow-separate-spans.rs b/src/test/ui/consts/const-len-underflow-separate-spans.rs index 8db1411005e..68452082ef3 100644 --- a/src/test/ui/consts/const-len-underflow-separate-spans.rs +++ b/src/test/ui/consts/const-len-underflow-separate-spans.rs @@ -15,11 +15,9 @@ const ONE: usize = 1; const TWO: usize = 2; const LEN: usize = ONE - TWO; +//~^ ERROR any use of this value will cause an error fn main() { let a: [i8; LEN] = unimplemented!(); //~^ ERROR E0080 -//~| ERROR E0080 -//~| ERROR E0080 -//~| ERROR E0080 } diff --git a/src/test/ui/consts/const-len-underflow-separate-spans.stderr b/src/test/ui/consts/const-len-underflow-separate-spans.stderr index cf97a0dc555..da39fa2e6f2 100644 --- a/src/test/ui/consts/const-len-underflow-separate-spans.stderr +++ b/src/test/ui/consts/const-len-underflow-separate-spans.stderr @@ -1,35 +1,19 @@ -error[E0080]: referenced constant has errors - --> $DIR/const-len-underflow-separate-spans.rs:20:17 +error: any use of this value will cause an error + --> $DIR/const-len-underflow-separate-spans.rs:17:1 | LL | const LEN: usize = ONE - TWO; - | --------- attempt to subtract with overflow -... -LL | let a: [i8; LEN] = unimplemented!(); - | ^^^ - -error[E0080]: could not evaluate constant - --> $DIR/const-len-underflow-separate-spans.rs:20:17 + | ^^^^^^^^^^^^^^^^^^^---------^ + | | + | attempt to subtract with overflow | -LL | let a: [i8; LEN] = unimplemented!(); - | ^^^ referenced constant has errors + = note: #[deny(const_err)] on by default -error[E0080]: referenced constant has errors - --> $DIR/const-len-underflow-separate-spans.rs:20:12 +error[E0080]: evaluation of constant value failed + --> $DIR/const-len-underflow-separate-spans.rs:21:17 | -LL | const LEN: usize = ONE - TWO; - | --------- attempt to subtract with overflow -... LL | let a: [i8; LEN] = unimplemented!(); - | ^^^^^^^^^ - -error[E0080]: could not evaluate constant expression - --> $DIR/const-len-underflow-separate-spans.rs:20:12 - | -LL | let a: [i8; LEN] = unimplemented!(); - | ^^^^^---^ - | | - | referenced constant has errors + | ^^^ referenced constant has errors -error: aborting due to 4 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-len-underflow-subspans.rs b/src/test/ui/consts/const-len-underflow-subspans.rs index 054c272a3d3..10180f36489 100644 --- a/src/test/ui/consts/const-len-underflow-subspans.rs +++ b/src/test/ui/consts/const-len-underflow-subspans.rs @@ -16,6 +16,6 @@ const TWO: usize = 2; fn main() { let a: [i8; ONE - TWO] = unimplemented!(); - //~^ ERROR could not evaluate constant expression + //~^ ERROR evaluation of constant value failed //~| attempt to subtract with overflow } diff --git a/src/test/ui/consts/const-len-underflow-subspans.stderr b/src/test/ui/consts/const-len-underflow-subspans.stderr index 860716c1f38..3fca7ecb19a 100644 --- a/src/test/ui/consts/const-len-underflow-subspans.stderr +++ b/src/test/ui/consts/const-len-underflow-subspans.stderr @@ -1,19 +1,9 @@ -error: attempt to subtract with overflow +error[E0080]: evaluation of constant value failed --> $DIR/const-len-underflow-subspans.rs:18:17 | LL | let a: [i8; ONE - TWO] = unimplemented!(); - | ^^^^^^^^^ - | - = note: #[deny(const_err)] on by default - -error[E0080]: could not evaluate constant expression - --> $DIR/const-len-underflow-subspans.rs:18:12 - | -LL | let a: [i8; ONE - TWO] = unimplemented!(); - | ^^^^^---------^ - | | - | attempt to subtract with overflow + | ^^^^^^^^^ attempt to subtract with overflow -error: aborting due to 2 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-size_of-cycle.stderr b/src/test/ui/consts/const-size_of-cycle.stderr index ab8b5792e68..ea5d7c176ff 100644 --- a/src/test/ui/consts/const-size_of-cycle.stderr +++ b/src/test/ui/consts/const-size_of-cycle.stderr @@ -1,6 +1,11 @@ error[E0391]: cycle detected when computing layout of `Foo` | note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... +note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... + --> $DIR/const-size_of-cycle.rs:16:17 + | +LL | bytes: [u8; std::mem::size_of::()] + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ note: ...which requires const-evaluating `Foo::bytes::{{constant}}`... --> $SRC_DIR/libcore/mem.rs:LL:COL | diff --git a/src/test/ui/consts/const-slice-oob.rs b/src/test/ui/consts/const-slice-oob.rs index 6d51ff30998..b71556735d9 100644 --- a/src/test/ui/consts/const-slice-oob.rs +++ b/src/test/ui/consts/const-slice-oob.rs @@ -13,8 +13,10 @@ const FOO: &'static[u32] = &[1, 2, 3]; const BAR: u32 = FOO[5]; //~^ index out of bounds: the len is 3 but the index is 5 -//~| ERROR this constant cannot be used +//~| ERROR any use of this value will cause an error +//~| ERROR any use of this value will cause an error fn main() { let _ = BAR; + //~^ ERROR erroneous constant used } diff --git a/src/test/ui/consts/const-slice-oob.stderr b/src/test/ui/consts/const-slice-oob.stderr index 30260c36ffd..8fd298a18d2 100644 --- a/src/test/ui/consts/const-slice-oob.stderr +++ b/src/test/ui/consts/const-slice-oob.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-slice-oob.rs:14:1 | LL | const BAR: u32 = FOO[5]; @@ -8,5 +8,20 @@ LL | const BAR: u32 = FOO[5]; | = note: #[deny(const_err)] on by default -error: aborting due to previous error +error: any use of this value will cause an error + --> $DIR/const-slice-oob.rs:14:1 + | +LL | const BAR: u32 = FOO[5]; + | ^^^^^^^^^^^^^^^^^------^ + | | + | index out of bounds: the len is 3 but the index is 5 + +error[E0080]: erroneous constant used + --> $DIR/const-slice-oob.rs:20:13 + | +LL | let _ = BAR; + | ^^^ referenced constant has errors + +error: aborting due to 3 previous errors +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-tup-index-span.rs b/src/test/ui/consts/const-tup-index-span.rs index b42c440f87d..e1d58116481 100644 --- a/src/test/ui/consts/const-tup-index-span.rs +++ b/src/test/ui/consts/const-tup-index-span.rs @@ -14,6 +14,7 @@ const TUP: (usize,) = 5usize << 64; //~^ ERROR mismatched types //~| expected tuple, found usize const ARR: [i32; TUP.0] = []; +//~^ ERROR evaluation of constant value failed fn main() { } diff --git a/src/test/ui/consts/const-tup-index-span.stderr b/src/test/ui/consts/const-tup-index-span.stderr index e9248629656..3018baac5a5 100644 --- a/src/test/ui/consts/const-tup-index-span.stderr +++ b/src/test/ui/consts/const-tup-index-span.stderr @@ -7,6 +7,13 @@ LL | const TUP: (usize,) = 5usize << 64; = note: expected type `(usize,)` found type `usize` -error: aborting due to previous error +error[E0080]: evaluation of constant value failed + --> $DIR/const-tup-index-span.rs:16:18 + | +LL | const ARR: [i32; TUP.0] = []; + | ^^^ referenced constant has errors + +error: aborting due to 2 previous errors -For more information about this error, try `rustc --explain E0308`. +Some errors occurred: E0080, E0308. +For more information about an error, try `rustc --explain E0080`. diff --git a/src/test/ui/error-codes/E0080.rs b/src/test/ui/error-codes/E0080.rs index 7f3e6eaad9b..2ab15dfedca 100644 --- a/src/test/ui/error-codes/E0080.rs +++ b/src/test/ui/error-codes/E0080.rs @@ -12,9 +12,6 @@ enum Enum { X = (1 << 500), //~ ERROR E0080 //~| shift left with overflow Y = (1 / 0) //~ ERROR E0080 - //~| const_err - //~| const_err - //~| const_err } fn main() { diff --git a/src/test/ui/error-codes/E0080.stderr b/src/test/ui/error-codes/E0080.stderr index a213c2b1b20..e60c905587d 100644 --- a/src/test/ui/error-codes/E0080.stderr +++ b/src/test/ui/error-codes/E0080.stderr @@ -1,37 +1,15 @@ -error: attempt to shift left with overflow - --> $DIR/E0080.rs:12:9 - | -LL | X = (1 << 500), //~ ERROR E0080 - | ^^^^^^^^^^ - | - = note: #[deny(exceeding_bitshifts)] on by default - -error[E0080]: could not evaluate enum discriminant +error[E0080]: evaluation of constant value failed --> $DIR/E0080.rs:12:9 | LL | X = (1 << 500), //~ ERROR E0080 | ^^^^^^^^^^ attempt to shift left with overflow -error: attempt to divide by zero - --> $DIR/E0080.rs:14:9 - | -LL | Y = (1 / 0) //~ ERROR E0080 - | ^^^^^^^ - | - = note: #[deny(const_err)] on by default - -error: this expression will panic at runtime - --> $DIR/E0080.rs:14:9 - | -LL | Y = (1 / 0) //~ ERROR E0080 - | ^^^^^^^ attempt to divide by zero - -error[E0080]: could not evaluate enum discriminant +error[E0080]: evaluation of constant value failed --> $DIR/E0080.rs:14:9 | LL | Y = (1 / 0) //~ ERROR E0080 | ^^^^^^^ attempt to divide by zero -error: aborting due to 5 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/error-codes/E0396-fixed.rs b/src/test/ui/error-codes/E0396-fixed.rs index 08d20e7850d..005f2c36688 100644 --- a/src/test/ui/error-codes/E0396-fixed.rs +++ b/src/test/ui/error-codes/E0396-fixed.rs @@ -13,7 +13,7 @@ const REG_ADDR: *const u8 = 0x5f3759df as *const u8; const VALUE: u8 = unsafe { *REG_ADDR }; -//~^ ERROR this constant cannot be used +//~^ ERROR any use of this value will cause an error fn main() { } diff --git a/src/test/ui/error-codes/E0396-fixed.stderr b/src/test/ui/error-codes/E0396-fixed.stderr index 7d3c98c8ea8..e868d5a33fa 100644 --- a/src/test/ui/error-codes/E0396-fixed.stderr +++ b/src/test/ui/error-codes/E0396-fixed.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/E0396-fixed.rs:15:1 | LL | const VALUE: u8 = unsafe { *REG_ADDR }; diff --git a/src/test/ui/eval-enum.rs b/src/test/ui/eval-enum.rs index ada038114d8..f8a87db88b1 100644 --- a/src/test/ui/eval-enum.rs +++ b/src/test/ui/eval-enum.rs @@ -11,12 +11,10 @@ enum Test { DivZero = 1/0, //~^ attempt to divide by zero - //~| ERROR could not evaluate enum discriminant - //~| ERROR this expression will panic at runtime + //~| ERROR evaluation of constant value failed RemZero = 1%0, //~^ attempt to calculate the remainder with a divisor of zero - //~| ERROR could not evaluate enum discriminant - //~| ERROR this expression will panic at runtime + //~| ERROR evaluation of constant value failed } fn main() {} diff --git a/src/test/ui/eval-enum.stderr b/src/test/ui/eval-enum.stderr index f26c48f1a72..59c5ec10f6a 100644 --- a/src/test/ui/eval-enum.stderr +++ b/src/test/ui/eval-enum.stderr @@ -1,41 +1,15 @@ -error: attempt to divide by zero - --> $DIR/eval-enum.rs:12:15 - | -LL | DivZero = 1/0, - | ^^^ - | - = note: #[deny(const_err)] on by default - -error: this expression will panic at runtime +error[E0080]: evaluation of constant value failed --> $DIR/eval-enum.rs:12:15 | LL | DivZero = 1/0, | ^^^ attempt to divide by zero -error[E0080]: could not evaluate enum discriminant - --> $DIR/eval-enum.rs:12:15 - | -LL | DivZero = 1/0, - | ^^^ attempt to divide by zero - -error: attempt to calculate the remainder with a divisor of zero - --> $DIR/eval-enum.rs:16:15 - | -LL | RemZero = 1%0, - | ^^^ - -error: this expression will panic at runtime - --> $DIR/eval-enum.rs:16:15 - | -LL | RemZero = 1%0, - | ^^^ attempt to calculate the remainder with a divisor of zero - -error[E0080]: could not evaluate enum discriminant - --> $DIR/eval-enum.rs:16:15 +error[E0080]: evaluation of constant value failed + --> $DIR/eval-enum.rs:15:15 | LL | RemZero = 1%0, | ^^^ attempt to calculate the remainder with a divisor of zero -error: aborting due to 6 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/infinite/infinite-recursion-const-fn.rs b/src/test/ui/infinite/infinite-recursion-const-fn.rs index f99a080a9f0..ccf67ca3138 100644 --- a/src/test/ui/infinite/infinite-recursion-const-fn.rs +++ b/src/test/ui/infinite/infinite-recursion-const-fn.rs @@ -10,8 +10,8 @@ //https://github.com/rust-lang/rust/issues/31364 -const fn a() -> usize { b() } +const fn a() -> usize { b() } //~ ERROR evaluation of constant value failed const fn b() -> usize { a() } -const ARR: [i32; a()] = [5; 6]; //~ ERROR could not evaluate constant expression +const ARR: [i32; a()] = [5; 6]; fn main(){} diff --git a/src/test/ui/infinite/infinite-recursion-const-fn.stderr b/src/test/ui/infinite/infinite-recursion-const-fn.stderr index c77452d9abe..82da89f1aa7 100644 --- a/src/test/ui/infinite/infinite-recursion-const-fn.stderr +++ b/src/test/ui/infinite/infinite-recursion-const-fn.stderr @@ -1,8 +1,8 @@ -error[E0080]: could not evaluate constant expression - --> $DIR/infinite-recursion-const-fn.rs:15:12 +error[E0080]: evaluation of constant value failed + --> $DIR/infinite-recursion-const-fn.rs:14:25 | -LL | const fn a() -> usize { b() } - | --- +LL | const fn a() -> usize { b() } //~ ERROR evaluation of constant value failed + | ^^^ | | | reached the configured maximum number of stack frames | inside call to `b` @@ -58,10 +58,8 @@ LL | const fn b() -> usize { a() } | inside call to `a` | inside call to `a` | inside call to `a` -LL | const ARR: [i32; a()] = [5; 6]; //~ ERROR could not evaluate constant expression - | ^^^^^^---^ - | | - | inside call to `a` +LL | const ARR: [i32; a()] = [5; 6]; + | --- inside call to `a` error: aborting due to previous error diff --git a/src/test/ui/issues/issue-39559-2.stderr b/src/test/ui/issues/issue-39559-2.stderr index ca9da096b6c..d7efcc52494 100644 --- a/src/test/ui/issues/issue-39559-2.stderr +++ b/src/test/ui/issues/issue-39559-2.stderr @@ -4,12 +4,24 @@ error[E0015]: calls in constants are limited to constant functions, tuple struct LL | let array: [usize; Dim3::dim()] | ^^^^^^^^^^^ +error[E0080]: evaluation of constant value failed + --> $DIR/issue-39559-2.rs:24:24 + | +LL | let array: [usize; Dim3::dim()] + | ^^^^^^^^^^^ calling non-const fn `::dim` + error[E0015]: calls in constants are limited to constant functions, tuple structs and tuple variants --> $DIR/issue-39559-2.rs:26:15 | LL | = [0; Dim3::dim()]; | ^^^^^^^^^^^ -error: aborting due to 2 previous errors +error[E0080]: evaluation of constant value failed + --> $DIR/issue-39559-2.rs:27:15 + | +LL | = [0; Dim3::dim()]; + | ^^^^^^^^^^^ calling non-const fn `::dim` + +error: aborting due to 4 previous errors For more information about this error, try `rustc --explain E0015`. diff --git a/src/test/ui/issues/issue-41394.rs b/src/test/ui/issues/issue-41394.rs index 89f11edaec8..539b8d2aab3 100644 --- a/src/test/ui/issues/issue-41394.rs +++ b/src/test/ui/issues/issue-41394.rs @@ -15,6 +15,7 @@ enum Foo { enum Bar { A = Foo::A as isize + //~^ ERROR evaluation of constant value failed } fn main() {} diff --git a/src/test/ui/issues/issue-41394.stderr b/src/test/ui/issues/issue-41394.stderr index 9e4afb3b28a..4f170f0ce3d 100644 --- a/src/test/ui/issues/issue-41394.stderr +++ b/src/test/ui/issues/issue-41394.stderr @@ -6,6 +6,13 @@ LL | A = "" + 1 | = note: an implementation of `std::ops::Add` might be missing for `&str` -error: aborting due to previous error +error[E0080]: evaluation of constant value failed + --> $DIR/issue-41394.rs:17:9 + | +LL | A = Foo::A as isize + | ^^^^^^^^^^^^^^^ referenced constant has errors + +error: aborting due to 2 previous errors -For more information about this error, try `rustc --explain E0369`. +Some errors occurred: E0080, E0369. +For more information about an error, try `rustc --explain E0080`. diff --git a/src/test/ui/issues/issue-43105.rs b/src/test/ui/issues/issue-43105.rs index 2bddc443d5b..2b0eb685497 100644 --- a/src/test/ui/issues/issue-43105.rs +++ b/src/test/ui/issues/issue-43105.rs @@ -12,10 +12,11 @@ fn xyz() -> u8 { 42 } const NUM: u8 = xyz(); //~^ ERROR calls in constants are limited to constant functions, tuple structs and tuple variants +//~| ERROR any use of this value will cause an error fn main() { match 1 { - NUM => unimplemented!(), + NUM => unimplemented!(), //~ ERROR could not evaluate constant pattern _ => unimplemented!(), } } diff --git a/src/test/ui/issues/issue-43105.stderr b/src/test/ui/issues/issue-43105.stderr index 67a6008cd8e..aba8351186b 100644 --- a/src/test/ui/issues/issue-43105.stderr +++ b/src/test/ui/issues/issue-43105.stderr @@ -4,6 +4,22 @@ error[E0015]: calls in constants are limited to constant functions, tuple struct LL | const NUM: u8 = xyz(); | ^^^^^ -error: aborting due to previous error +error: any use of this value will cause an error + --> $DIR/issue-43105.rs:13:1 + | +LL | const NUM: u8 = xyz(); + | ^^^^^^^^^^^^^^^^-----^ + | | + | calling non-const fn `xyz` + | + = note: #[deny(const_err)] on by default + +error: could not evaluate constant pattern + --> $DIR/issue-43105.rs:19:9 + | +LL | NUM => unimplemented!(), //~ ERROR could not evaluate constant pattern + | ^^^ + +error: aborting due to 3 previous errors For more information about this error, try `rustc --explain E0015`. diff --git a/src/test/ui/issues/issue-44415.stderr b/src/test/ui/issues/issue-44415.stderr index ac2072c513e..f20c2c73359 100644 --- a/src/test/ui/issues/issue-44415.stderr +++ b/src/test/ui/issues/issue-44415.stderr @@ -1,6 +1,11 @@ error[E0391]: cycle detected when computing layout of `Foo` | note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... +note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... + --> $DIR/issue-44415.rs:19:17 + | +LL | bytes: [u8; unsafe { intrinsics::size_of::() }], + | ^^^^^^ note: ...which requires const-evaluating `Foo::bytes::{{constant}}`... --> $DIR/issue-44415.rs:19:26 | diff --git a/src/test/ui/issues/issue-50599.rs b/src/test/ui/issues/issue-50599.rs index f46a562ce7a..417f8c8848e 100644 --- a/src/test/ui/issues/issue-50599.rs +++ b/src/test/ui/issues/issue-50599.rs @@ -12,4 +12,5 @@ fn main() { const N: u32 = 1_000; const M: usize = (f64::from(N) * std::f64::LOG10_2) as usize; //~ ERROR cannot find value let mut digits = [0u32; M]; + //~^ ERROR evaluation of constant value failed } diff --git a/src/test/ui/issues/issue-50599.stderr b/src/test/ui/issues/issue-50599.stderr index 8337a31ec14..5338f333d21 100644 --- a/src/test/ui/issues/issue-50599.stderr +++ b/src/test/ui/issues/issue-50599.stderr @@ -10,6 +10,13 @@ LL | use std::f32::consts::LOG10_2; LL | use std::f64::consts::LOG10_2; | -error: aborting due to previous error +error[E0080]: evaluation of constant value failed + --> $DIR/issue-50599.rs:14:29 + | +LL | let mut digits = [0u32; M]; + | ^ referenced constant has errors + +error: aborting due to 2 previous errors -For more information about this error, try `rustc --explain E0425`. +Some errors occurred: E0080, E0425. +For more information about an error, try `rustc --explain E0080`. diff --git a/src/test/ui/recursion/recursive-static-definition.stderr b/src/test/ui/recursion/recursive-static-definition.stderr index 2ab93bfd685..5bd0f90afbc 100644 --- a/src/test/ui/recursion/recursive-static-definition.stderr +++ b/src/test/ui/recursion/recursive-static-definition.stderr @@ -5,6 +5,11 @@ LL | pub static FOO: u32 = FOO; | ^^^ | = note: ...which again requires const-evaluating `FOO`, completing the cycle +note: cycle used when const-evaluating + checking `FOO` + --> $DIR/recursive-static-definition.rs:11:1 + | +LL | pub static FOO: u32 = FOO; + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ error: aborting due to previous error diff --git a/src/test/ui/type/type-dependent-def-issue-49241.rs b/src/test/ui/type/type-dependent-def-issue-49241.rs index db27ae89e69..e4797014926 100644 --- a/src/test/ui/type/type-dependent-def-issue-49241.rs +++ b/src/test/ui/type/type-dependent-def-issue-49241.rs @@ -12,4 +12,5 @@ fn main() { let v = vec![0]; const l: usize = v.count(); //~ ERROR can't capture dynamic environment in a fn item let s: [u32; l] = v.into_iter().collect(); + //~^ ERROR evaluation of constant value failed } diff --git a/src/test/ui/type/type-dependent-def-issue-49241.stderr b/src/test/ui/type/type-dependent-def-issue-49241.stderr index 361d28f274f..361c3c0c3d5 100644 --- a/src/test/ui/type/type-dependent-def-issue-49241.stderr +++ b/src/test/ui/type/type-dependent-def-issue-49241.stderr @@ -6,6 +6,13 @@ LL | const l: usize = v.count(); //~ ERROR can't capture dynamic environment | = help: use the `|| { ... }` closure form instead -error: aborting due to previous error +error[E0080]: evaluation of constant value failed + --> $DIR/type-dependent-def-issue-49241.rs:14:18 + | +LL | let s: [u32; l] = v.into_iter().collect(); + | ^ referenced constant has errors + +error: aborting due to 2 previous errors -For more information about this error, try `rustc --explain E0434`. +Some errors occurred: E0080, E0434. +For more information about an error, try `rustc --explain E0080`. -- cgit 1.4.1-3-g733a5 From 0f970486183084634b08f516531c55d2286a38af Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Fri, 31 Aug 2018 10:40:14 +0200 Subject: Deduplicate all the ~~things~~ errors --- src/librustc_mir/const_eval.rs | 21 +++++++++++ src/test/ui/array_const_index-0.rs | 1 - src/test/ui/array_const_index-0.stderr | 12 +----- src/test/ui/array_const_index-1.rs | 1 - src/test/ui/array_const_index-1.stderr | 12 +----- src/test/ui/consts/const-err-early.rs | 1 - src/test/ui/consts/const-err-early.stderr | 30 ++++++--------- src/test/ui/consts/const-err-multi.rs | 1 - src/test/ui/consts/const-err-multi.stderr | 18 +++------ src/test/ui/consts/const-err.rs | 1 - src/test/ui/consts/const-err.stderr | 10 +---- .../ui/consts/const-eval/const-eval-overflow2.rs | 1 - .../consts/const-eval/const-eval-overflow2.stderr | 44 ++++++++-------------- .../ui/consts/const-eval/const-eval-overflow2b.rs | 1 - .../consts/const-eval/const-eval-overflow2b.stderr | 44 ++++++++-------------- .../ui/consts/const-eval/const-eval-overflow2c.rs | 1 - .../consts/const-eval/const-eval-overflow2c.stderr | 44 ++++++++-------------- .../ui/consts/const-eval/transmute-const.stderr | 2 +- .../ui/consts/const-eval/union-const-eval-field.rs | 1 - .../const-eval/union-const-eval-field.stderr | 12 ++---- src/test/ui/consts/const-size_of-cycle.stderr | 27 +++++++------ src/test/ui/consts/const-slice-oob.rs | 1 - src/test/ui/consts/const-slice-oob.stderr | 12 +----- src/test/ui/issues/issue-44415.rs | 4 +- src/test/ui/issues/issue-44415.stderr | 25 +++++++----- .../recursion/recursive-static-definition.stderr | 5 +++ 26 files changed, 133 insertions(+), 199 deletions(-) (limited to 'src/test') diff --git a/src/librustc_mir/const_eval.rs b/src/librustc_mir/const_eval.rs index 6ad1536a630..861d0b2f7e1 100644 --- a/src/librustc_mir/const_eval.rs +++ b/src/librustc_mir/const_eval.rs @@ -23,6 +23,7 @@ use rustc::mir; use rustc::ty::{self, Ty, TyCtxt, Instance, query::TyCtxtAt}; use rustc::ty::layout::{self, Size, LayoutOf, TyLayout}; use rustc::ty::subst::Subst; +use rustc::traits::Reveal; use rustc::util::nodemap::FxHashSet; use rustc_data_structures::indexed_vec::IndexVec; use rustc_data_structures::fx::FxHashMap; @@ -576,6 +577,16 @@ pub fn const_eval_provider<'a, 'tcx>( tcx: TyCtxt<'a, 'tcx, 'tcx>, key: ty::ParamEnvAnd<'tcx, GlobalId<'tcx>>, ) -> ::rustc::mir::interpret::ConstEvalResult<'tcx> { + if key.param_env.reveal == Reveal::All { + let mut key = key.clone(); + key.param_env.reveal = Reveal::UserFacing; + match tcx.const_eval(key) { + // try again with reveal all as requested + Err(ErrorHandled::TooGeneric) => {}, + // dedupliate calls + other => return other, + } + } tcx.const_eval_raw(key).and_then(|val| { validate_const(tcx, val, key) }) @@ -585,6 +596,16 @@ pub fn const_eval_raw_provider<'a, 'tcx>( tcx: TyCtxt<'a, 'tcx, 'tcx>, key: ty::ParamEnvAnd<'tcx, GlobalId<'tcx>>, ) -> ::rustc::mir::interpret::ConstEvalResult<'tcx> { + if key.param_env.reveal == Reveal::All { + let mut key = key.clone(); + key.param_env.reveal = Reveal::UserFacing; + match tcx.const_eval_raw(key) { + // try again with reveal all as requested + Err(ErrorHandled::TooGeneric) => {}, + // dedupliate calls + other => return other, + } + } trace!("const eval: {:?}", key); let cid = key.value; let def_id = cid.instance.def.def_id(); diff --git a/src/test/ui/array_const_index-0.rs b/src/test/ui/array_const_index-0.rs index 2403d50db39..0ad297eeb5c 100644 --- a/src/test/ui/array_const_index-0.rs +++ b/src/test/ui/array_const_index-0.rs @@ -12,7 +12,6 @@ const A: &'static [i32] = &[]; const B: i32 = (&A)[1]; //~^ index out of bounds: the len is 0 but the index is 1 //~| ERROR any use of this value will cause an error -//~| ERROR any use of this value will cause an error fn main() { let _ = B; //~ ERROR erroneous constant used diff --git a/src/test/ui/array_const_index-0.stderr b/src/test/ui/array_const_index-0.stderr index 95ed88bde10..38163b1f4b1 100644 --- a/src/test/ui/array_const_index-0.stderr +++ b/src/test/ui/array_const_index-0.stderr @@ -8,20 +8,12 @@ LL | const B: i32 = (&A)[1]; | = note: #[deny(const_err)] on by default -error: any use of this value will cause an error - --> $DIR/array_const_index-0.rs:12:1 - | -LL | const B: i32 = (&A)[1]; - | ^^^^^^^^^^^^^^^-------^ - | | - | index out of bounds: the len is 0 but the index is 1 - error[E0080]: erroneous constant used - --> $DIR/array_const_index-0.rs:18:13 + --> $DIR/array_const_index-0.rs:17:13 | LL | let _ = B; //~ ERROR erroneous constant used | ^ referenced constant has errors -error: aborting due to 3 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/array_const_index-1.rs b/src/test/ui/array_const_index-1.rs index 0a49348761c..4c7dcfbb347 100644 --- a/src/test/ui/array_const_index-1.rs +++ b/src/test/ui/array_const_index-1.rs @@ -12,7 +12,6 @@ const A: [i32; 0] = []; const B: i32 = A[1]; //~^ index out of bounds: the len is 0 but the index is 1 //~| ERROR any use of this value will cause an error -//~| ERROR any use of this value will cause an error fn main() { let _ = B; //~ ERROR erroneous constant used diff --git a/src/test/ui/array_const_index-1.stderr b/src/test/ui/array_const_index-1.stderr index 5fcfc14e2c0..b122e590c88 100644 --- a/src/test/ui/array_const_index-1.stderr +++ b/src/test/ui/array_const_index-1.stderr @@ -8,20 +8,12 @@ LL | const B: i32 = A[1]; | = note: #[deny(const_err)] on by default -error: any use of this value will cause an error - --> $DIR/array_const_index-1.rs:12:1 - | -LL | const B: i32 = A[1]; - | ^^^^^^^^^^^^^^^----^ - | | - | index out of bounds: the len is 0 but the index is 1 - error[E0080]: erroneous constant used - --> $DIR/array_const_index-1.rs:18:13 + --> $DIR/array_const_index-1.rs:17:13 | LL | let _ = B; //~ ERROR erroneous constant used | ^ referenced constant has errors -error: aborting due to 3 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err-early.rs b/src/test/ui/consts/const-err-early.rs index 488e6f49e14..1cbfb918427 100644 --- a/src/test/ui/consts/const-err-early.rs +++ b/src/test/ui/consts/const-err-early.rs @@ -11,7 +11,6 @@ #![deny(const_err)] pub const A: i8 = -std::i8::MIN; //~ ERROR const_err -//~^ ERROR const_err pub const B: u8 = 200u8 + 200u8; //~ ERROR const_err pub const C: u8 = 200u8 * 4; //~ ERROR const_err pub const D: u8 = 42u8 - (42u8 + 1); //~ ERROR const_err diff --git a/src/test/ui/consts/const-err-early.stderr b/src/test/ui/consts/const-err-early.stderr index 21c7bf0a70a..8cc112191b5 100644 --- a/src/test/ui/consts/const-err-early.stderr +++ b/src/test/ui/consts/const-err-early.stderr @@ -13,7 +13,7 @@ LL | #![deny(const_err)] | ^^^^^^^^^ error: any use of this value will cause an error - --> $DIR/const-err-early.rs:15:1 + --> $DIR/const-err-early.rs:14:1 | LL | pub const B: u8 = 200u8 + 200u8; //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^-------------^ @@ -21,7 +21,7 @@ LL | pub const B: u8 = 200u8 + 200u8; //~ ERROR const_err | attempt to add with overflow error: any use of this value will cause an error - --> $DIR/const-err-early.rs:16:1 + --> $DIR/const-err-early.rs:15:1 | LL | pub const C: u8 = 200u8 * 4; //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^---------^ @@ -29,7 +29,7 @@ LL | pub const C: u8 = 200u8 * 4; //~ ERROR const_err | attempt to multiply with overflow error: any use of this value will cause an error - --> $DIR/const-err-early.rs:17:1 + --> $DIR/const-err-early.rs:16:1 | LL | pub const D: u8 = 42u8 - (42u8 + 1); //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^-----------------^ @@ -37,57 +37,49 @@ LL | pub const D: u8 = 42u8 - (42u8 + 1); //~ ERROR const_err | attempt to subtract with overflow error: any use of this value will cause an error - --> $DIR/const-err-early.rs:18:1 + --> $DIR/const-err-early.rs:17:1 | LL | pub const E: u8 = [5u8][1]; //~ ERROR const_err | ^^^^^^^^^^^^^^^^^^--------^ | | | index out of bounds: the len is 1 but the index is 1 -error: any use of this value will cause an error - --> $DIR/const-err-early.rs:13:1 - | -LL | pub const A: i8 = -std::i8::MIN; //~ ERROR const_err - | ^^^^^^^^^^^^^^^^^^-------------^ - | | - | attempt to negate with overflow - error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:21:14 + --> $DIR/const-err-early.rs:20:14 | LL | let _a = A; //~ ERROR erroneous constant used | ^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:22:14 + --> $DIR/const-err-early.rs:21:14 | LL | let _b = B; //~ ERROR erroneous constant used | ^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:23:14 + --> $DIR/const-err-early.rs:22:14 | LL | let _c = C; //~ ERROR erroneous constant used | ^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:24:14 + --> $DIR/const-err-early.rs:23:14 | LL | let _d = D; //~ ERROR erroneous constant used | ^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:25:14 + --> $DIR/const-err-early.rs:24:14 | LL | let _e = E; //~ ERROR erroneous constant used | ^ referenced constant has errors error: index out of bounds: the len is 1 but the index is 1 - --> $DIR/const-err-early.rs:26:14 + --> $DIR/const-err-early.rs:25:14 | LL | let _e = [6u8][1]; //~ ERROR index out of bounds | ^^^^^^^^ -error: aborting due to 12 previous errors +error: aborting due to 11 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err-multi.rs b/src/test/ui/consts/const-err-multi.rs index c3960b83992..20eaebfbe56 100644 --- a/src/test/ui/consts/const-err-multi.rs +++ b/src/test/ui/consts/const-err-multi.rs @@ -12,7 +12,6 @@ pub const A: i8 = -std::i8::MIN; //~^ ERROR const_err -//~| ERROR const_err pub const B: i8 = A; //~^ ERROR const_err pub const C: u8 = A as u8; diff --git a/src/test/ui/consts/const-err-multi.stderr b/src/test/ui/consts/const-err-multi.stderr index 0717302dbf9..da6f31a3886 100644 --- a/src/test/ui/consts/const-err-multi.stderr +++ b/src/test/ui/consts/const-err-multi.stderr @@ -13,7 +13,7 @@ LL | #![deny(const_err)] | ^^^^^^^^^ error: any use of this value will cause an error - --> $DIR/const-err-multi.rs:16:1 + --> $DIR/const-err-multi.rs:15:1 | LL | pub const B: i8 = A; | ^^^^^^^^^^^^^^^^^^-^ @@ -21,7 +21,7 @@ LL | pub const B: i8 = A; | referenced constant has errors error: any use of this value will cause an error - --> $DIR/const-err-multi.rs:18:1 + --> $DIR/const-err-multi.rs:17:1 | LL | pub const C: u8 = A as u8; | ^^^^^^^^^^^^^^^^^^-------^ @@ -29,27 +29,19 @@ LL | pub const C: u8 = A as u8; | referenced constant has errors error: any use of this value will cause an error - --> $DIR/const-err-multi.rs:20:1 + --> $DIR/const-err-multi.rs:19:1 | LL | pub const D: i8 = 50 - A; | ^^^^^^^^^^^^^^^^^^------^ | | | referenced constant has errors -error: any use of this value will cause an error - --> $DIR/const-err-multi.rs:13:1 - | -LL | pub const A: i8 = -std::i8::MIN; - | ^^^^^^^^^^^^^^^^^^-------------^ - | | - | attempt to negate with overflow - error[E0080]: erroneous constant used - --> $DIR/const-err-multi.rs:24:13 + --> $DIR/const-err-multi.rs:23:13 | LL | let _ = (A, B, C, D); | ^^^^^^^^^^^^ referenced constant has errors -error: aborting due to 6 previous errors +error: aborting due to 5 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err.rs b/src/test/ui/consts/const-err.rs index 7c59e8b9535..fff50c86646 100644 --- a/src/test/ui/consts/const-err.rs +++ b/src/test/ui/consts/const-err.rs @@ -19,7 +19,6 @@ fn black_box(_: T) { const FOO: u8 = [5u8][1]; //~^ WARN any use of this value will cause an error -//~| WARN any use of this value will cause an error fn main() { black_box((FOO, FOO)); diff --git a/src/test/ui/consts/const-err.stderr b/src/test/ui/consts/const-err.stderr index b46277f4b01..e2ef7c3d0d4 100644 --- a/src/test/ui/consts/const-err.stderr +++ b/src/test/ui/consts/const-err.stderr @@ -12,16 +12,8 @@ note: lint level defined here LL | #![warn(const_err)] | ^^^^^^^^^ -warning: any use of this value will cause an error - --> $DIR/const-err.rs:20:1 - | -LL | const FOO: u8 = [5u8][1]; - | ^^^^^^^^^^^^^^^^--------^ - | | - | index out of bounds: the len is 1 but the index is 1 - error[E0080]: erroneous constant used - --> $DIR/const-err.rs:25:15 + --> $DIR/const-err.rs:24:15 | LL | black_box((FOO, FOO)); | ^^^^^^^^^^ referenced constant has errors diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2.rs b/src/test/ui/consts/const-eval/const-eval-overflow2.rs index ee29423a90c..c61a1b3edb7 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2.rs @@ -22,7 +22,6 @@ use std::{i8, i16, i32, i64, isize}; use std::{u8, u16, u32, u64, usize}; const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error - //~^ const_err ( i8::MIN - 1, ); diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2.stderr index f10a6eee6de..0484335fd0c 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2.stderr @@ -2,7 +2,6 @@ error: any use of this value will cause an error --> $DIR/const-eval-overflow2.rs:24:1 | LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error -LL | | //~^ const_err LL | | ( LL | | i8::MIN - 1, | | ----------- attempt to subtract with overflow @@ -16,7 +15,7 @@ LL | #![deny(const_err)] | ^^^^^^^^^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:30:1 + --> $DIR/const-eval-overflow2.rs:29:1 | LL | / const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -26,7 +25,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:35:1 + --> $DIR/const-eval-overflow2.rs:34:1 | LL | / const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -36,7 +35,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:40:1 + --> $DIR/const-eval-overflow2.rs:39:1 | LL | / const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -46,7 +45,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:45:1 + --> $DIR/const-eval-overflow2.rs:44:1 | LL | / const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -56,7 +55,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:50:1 + --> $DIR/const-eval-overflow2.rs:49:1 | LL | / const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error LL | | u16::MIN - 1, @@ -65,7 +64,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:54:1 + --> $DIR/const-eval-overflow2.rs:53:1 | LL | / const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error LL | | u32::MIN - 1, @@ -74,7 +73,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:58:1 + --> $DIR/const-eval-overflow2.rs:57:1 | LL | / const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -83,65 +82,54 @@ LL | | u64::MIN - 1, LL | | ); | |_______^ -error: any use of this value will cause an error - --> $DIR/const-eval-overflow2.rs:24:1 - | -LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error -LL | | //~^ const_err -LL | | ( -LL | | i8::MIN - 1, - | | ----------- attempt to subtract with overflow -LL | | ); - | |_______^ - error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:64:5 + --> $DIR/const-eval-overflow2.rs:63:5 | LL | foo(VALS_I8); //~ ERROR erroneous constant used | ^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:65:5 + --> $DIR/const-eval-overflow2.rs:64:5 | LL | foo(VALS_I16); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:66:5 + --> $DIR/const-eval-overflow2.rs:65:5 | LL | foo(VALS_I32); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:67:5 + --> $DIR/const-eval-overflow2.rs:66:5 | LL | foo(VALS_I64); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:69:5 + --> $DIR/const-eval-overflow2.rs:68:5 | LL | foo(VALS_U8); //~ ERROR erroneous constant used | ^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:70:5 + --> $DIR/const-eval-overflow2.rs:69:5 | LL | foo(VALS_U16); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:71:5 + --> $DIR/const-eval-overflow2.rs:70:5 | LL | foo(VALS_U32); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:72:5 + --> $DIR/const-eval-overflow2.rs:71:5 | LL | foo(VALS_U64); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors -error: aborting due to 17 previous errors +error: aborting due to 16 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2b.rs b/src/test/ui/consts/const-eval/const-eval-overflow2b.rs index 55dc2a89405..47b0977ec1d 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2b.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2b.rs @@ -22,7 +22,6 @@ use std::{i8, i16, i32, i64, isize}; use std::{u8, u16, u32, u64, usize}; const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error - //~^ const_err ( i8::MAX + 1, ); diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr index 3b78fb51a62..8922b35a0b2 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr @@ -2,7 +2,6 @@ error: any use of this value will cause an error --> $DIR/const-eval-overflow2b.rs:24:1 | LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error -LL | | //~^ const_err LL | | ( LL | | i8::MAX + 1, | | ----------- attempt to add with overflow @@ -16,7 +15,7 @@ LL | #![deny(const_err)] | ^^^^^^^^^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:30:1 + --> $DIR/const-eval-overflow2b.rs:29:1 | LL | / const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -26,7 +25,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:35:1 + --> $DIR/const-eval-overflow2b.rs:34:1 | LL | / const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -36,7 +35,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:40:1 + --> $DIR/const-eval-overflow2b.rs:39:1 | LL | / const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -46,7 +45,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:45:1 + --> $DIR/const-eval-overflow2b.rs:44:1 | LL | / const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -56,7 +55,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:50:1 + --> $DIR/const-eval-overflow2b.rs:49:1 | LL | / const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error LL | | u16::MAX + 1, @@ -65,7 +64,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:54:1 + --> $DIR/const-eval-overflow2b.rs:53:1 | LL | / const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error LL | | u32::MAX + 1, @@ -74,7 +73,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:58:1 + --> $DIR/const-eval-overflow2b.rs:57:1 | LL | / const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -83,65 +82,54 @@ LL | | u64::MAX + 1, LL | | ); | |_______^ -error: any use of this value will cause an error - --> $DIR/const-eval-overflow2b.rs:24:1 - | -LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error -LL | | //~^ const_err -LL | | ( -LL | | i8::MAX + 1, - | | ----------- attempt to add with overflow -LL | | ); - | |_______^ - error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:64:5 + --> $DIR/const-eval-overflow2b.rs:63:5 | LL | foo(VALS_I8); //~ ERROR erroneous constant used | ^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:65:5 + --> $DIR/const-eval-overflow2b.rs:64:5 | LL | foo(VALS_I16); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:66:5 + --> $DIR/const-eval-overflow2b.rs:65:5 | LL | foo(VALS_I32); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:67:5 + --> $DIR/const-eval-overflow2b.rs:66:5 | LL | foo(VALS_I64); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:69:5 + --> $DIR/const-eval-overflow2b.rs:68:5 | LL | foo(VALS_U8); //~ ERROR erroneous constant used | ^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:70:5 + --> $DIR/const-eval-overflow2b.rs:69:5 | LL | foo(VALS_U16); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:71:5 + --> $DIR/const-eval-overflow2b.rs:70:5 | LL | foo(VALS_U32); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:72:5 + --> $DIR/const-eval-overflow2b.rs:71:5 | LL | foo(VALS_U64); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors -error: aborting due to 17 previous errors +error: aborting due to 16 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2c.rs b/src/test/ui/consts/const-eval/const-eval-overflow2c.rs index 93ba11efc59..b4e1a0bc099 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2c.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2c.rs @@ -22,7 +22,6 @@ use std::{i8, i16, i32, i64, isize}; use std::{u8, u16, u32, u64, usize}; const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error - //~^ const_err ( i8::MIN * 2, ); diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr index abaae4bd542..023156a40dd 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr @@ -2,7 +2,6 @@ error: any use of this value will cause an error --> $DIR/const-eval-overflow2c.rs:24:1 | LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error -LL | | //~^ const_err LL | | ( LL | | i8::MIN * 2, | | ----------- attempt to multiply with overflow @@ -16,7 +15,7 @@ LL | #![deny(const_err)] | ^^^^^^^^^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:30:1 + --> $DIR/const-eval-overflow2c.rs:29:1 | LL | / const VALS_I16: (i16,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -26,7 +25,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:35:1 + --> $DIR/const-eval-overflow2c.rs:34:1 | LL | / const VALS_I32: (i32,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -36,7 +35,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:40:1 + --> $DIR/const-eval-overflow2c.rs:39:1 | LL | / const VALS_I64: (i64,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -46,7 +45,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:45:1 + --> $DIR/const-eval-overflow2c.rs:44:1 | LL | / const VALS_U8: (u8,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -56,7 +55,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:50:1 + --> $DIR/const-eval-overflow2c.rs:49:1 | LL | / const VALS_U16: (u16,) = ( //~ ERROR any use of this value will cause an error LL | | u16::MAX * 2, @@ -65,7 +64,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:54:1 + --> $DIR/const-eval-overflow2c.rs:53:1 | LL | / const VALS_U32: (u32,) = ( //~ ERROR any use of this value will cause an error LL | | u32::MAX * 2, @@ -74,7 +73,7 @@ LL | | ); | |_______^ error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:58:1 + --> $DIR/const-eval-overflow2c.rs:57:1 | LL | / const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error LL | | ( @@ -83,65 +82,54 @@ LL | | u64::MAX * 2, LL | | ); | |_______^ -error: any use of this value will cause an error - --> $DIR/const-eval-overflow2c.rs:24:1 - | -LL | / const VALS_I8: (i8,) = //~ ERROR any use of this value will cause an error -LL | | //~^ const_err -LL | | ( -LL | | i8::MIN * 2, - | | ----------- attempt to multiply with overflow -LL | | ); - | |_______^ - error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:64:5 + --> $DIR/const-eval-overflow2c.rs:63:5 | LL | foo(VALS_I8); //~ ERROR erroneous constant used | ^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:65:5 + --> $DIR/const-eval-overflow2c.rs:64:5 | LL | foo(VALS_I16); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:66:5 + --> $DIR/const-eval-overflow2c.rs:65:5 | LL | foo(VALS_I32); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:67:5 + --> $DIR/const-eval-overflow2c.rs:66:5 | LL | foo(VALS_I64); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:69:5 + --> $DIR/const-eval-overflow2c.rs:68:5 | LL | foo(VALS_U8); //~ ERROR erroneous constant used | ^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:70:5 + --> $DIR/const-eval-overflow2c.rs:69:5 | LL | foo(VALS_U16); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:71:5 + --> $DIR/const-eval-overflow2c.rs:70:5 | LL | foo(VALS_U32); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:72:5 + --> $DIR/const-eval-overflow2c.rs:71:5 | LL | foo(VALS_U64); //~ ERROR erroneous constant used | ^^^^^^^^^^^^^ referenced constant has errors -error: aborting due to 17 previous errors +error: aborting due to 16 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/transmute-const.stderr b/src/test/ui/consts/const-eval/transmute-const.stderr index c9beca7aa30..91faa4684c3 100644 --- a/src/test/ui/consts/const-eval/transmute-const.stderr +++ b/src/test/ui/consts/const-eval/transmute-const.stderr @@ -1,4 +1,4 @@ -error[E0080]: this static likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/transmute-const.rs:15:1 | LL | static FOO: bool = unsafe { mem::transmute(3u8) }; diff --git a/src/test/ui/consts/const-eval/union-const-eval-field.rs b/src/test/ui/consts/const-eval/union-const-eval-field.rs index 40d1f97a807..759dab6c256 100644 --- a/src/test/ui/consts/const-eval/union-const-eval-field.rs +++ b/src/test/ui/consts/const-eval/union-const-eval-field.rs @@ -35,7 +35,6 @@ const fn read_field2() -> Field2 { const fn read_field3() -> Field3 { const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of this value - //~^ ERROR any use of this value FIELD3 //~^ erroneous constant used } diff --git a/src/test/ui/consts/const-eval/union-const-eval-field.stderr b/src/test/ui/consts/const-eval/union-const-eval-field.stderr index 39320791a3f..6a64f0c3671 100644 --- a/src/test/ui/consts/const-eval/union-const-eval-field.stderr +++ b/src/test/ui/consts/const-eval/union-const-eval-field.stderr @@ -6,20 +6,14 @@ LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of th | = note: #[deny(const_err)] on by default -error: any use of this value will cause an error - --> $DIR/union-const-eval-field.rs:37:5 - | -LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of this value - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempted to read undefined bytes - error[E0080]: erroneous constant used - --> $DIR/union-const-eval-field.rs:39:5 + --> $DIR/union-const-eval-field.rs:38:5 | LL | FIELD3 | ^^^^^^ referenced constant has errors error[E0080]: evaluation of constant expression failed - --> $DIR/union-const-eval-field.rs:46:5 + --> $DIR/union-const-eval-field.rs:45:5 | LL | FIELD3 | ------ referenced constant has errors @@ -31,6 +25,6 @@ LL | assert_eq!(read_field3(), unsafe { UNION.field3 }); | = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) -error: aborting due to 4 previous errors +error: aborting due to 3 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-size_of-cycle.stderr b/src/test/ui/consts/const-size_of-cycle.stderr index ea5d7c176ff..0c8fdfb6da2 100644 --- a/src/test/ui/consts/const-size_of-cycle.stderr +++ b/src/test/ui/consts/const-size_of-cycle.stderr @@ -1,22 +1,27 @@ -error[E0391]: cycle detected when computing layout of `Foo` - | -note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... -note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... +error[E0391]: cycle detected when const-evaluating + checking `Foo::bytes::{{constant}}` --> $DIR/const-size_of-cycle.rs:16:17 | LL | bytes: [u8; std::mem::size_of::()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ + | note: ...which requires const-evaluating `Foo::bytes::{{constant}}`... --> $SRC_DIR/libcore/mem.rs:LL:COL | -LL | intrinsics::size_of::() - | ^^^^^^^^^^^^^^^^^^^^^^^^^^ - = note: ...which again requires computing layout of `Foo`, completing the cycle -note: cycle used when const-evaluating `Foo::bytes::{{constant}}` - --> $SRC_DIR/libcore/mem.rs:LL:COL +LL | unsafe { intrinsics::size_of::() } + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ +note: ...which requires computing layout of `Foo`... +note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... +note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... + --> $DIR/const-size_of-cycle.rs:16:17 + | +LL | bytes: [u8; std::mem::size_of::()] + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ + = note: ...which again requires const-evaluating + checking `Foo::bytes::{{constant}}`, completing the cycle +note: cycle used when processing `Foo` + --> $DIR/const-size_of-cycle.rs:15:1 | -LL | intrinsics::size_of::() - | ^^^^^^^^^^^^^^^^^^^^^^^^^^ +LL | struct Foo { + | ^^^^^^^^^^ error: aborting due to previous error diff --git a/src/test/ui/consts/const-slice-oob.rs b/src/test/ui/consts/const-slice-oob.rs index b71556735d9..cc7f86f97a1 100644 --- a/src/test/ui/consts/const-slice-oob.rs +++ b/src/test/ui/consts/const-slice-oob.rs @@ -14,7 +14,6 @@ const FOO: &'static[u32] = &[1, 2, 3]; const BAR: u32 = FOO[5]; //~^ index out of bounds: the len is 3 but the index is 5 //~| ERROR any use of this value will cause an error -//~| ERROR any use of this value will cause an error fn main() { let _ = BAR; diff --git a/src/test/ui/consts/const-slice-oob.stderr b/src/test/ui/consts/const-slice-oob.stderr index 8fd298a18d2..763afae62ea 100644 --- a/src/test/ui/consts/const-slice-oob.stderr +++ b/src/test/ui/consts/const-slice-oob.stderr @@ -8,20 +8,12 @@ LL | const BAR: u32 = FOO[5]; | = note: #[deny(const_err)] on by default -error: any use of this value will cause an error - --> $DIR/const-slice-oob.rs:14:1 - | -LL | const BAR: u32 = FOO[5]; - | ^^^^^^^^^^^^^^^^^------^ - | | - | index out of bounds: the len is 3 but the index is 5 - error[E0080]: erroneous constant used - --> $DIR/const-slice-oob.rs:20:13 + --> $DIR/const-slice-oob.rs:19:13 | LL | let _ = BAR; | ^^^ referenced constant has errors -error: aborting due to 3 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/issues/issue-44415.rs b/src/test/ui/issues/issue-44415.rs index bd50f93945c..6d55422dea0 100644 --- a/src/test/ui/issues/issue-44415.rs +++ b/src/test/ui/issues/issue-44415.rs @@ -8,15 +8,13 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//~^^^^^^^^^^ ERROR cycle detected when computing layout of - - #![feature(core_intrinsics)] use std::intrinsics; struct Foo { bytes: [u8; unsafe { intrinsics::size_of::() }], + //~^ ERROR cycle detected when const-evaluating + checking x: usize, } diff --git a/src/test/ui/issues/issue-44415.stderr b/src/test/ui/issues/issue-44415.stderr index f20c2c73359..4345a5dbf43 100644 --- a/src/test/ui/issues/issue-44415.stderr +++ b/src/test/ui/issues/issue-44415.stderr @@ -1,22 +1,27 @@ -error[E0391]: cycle detected when computing layout of `Foo` - | -note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... -note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... - --> $DIR/issue-44415.rs:19:17 +error[E0391]: cycle detected when const-evaluating + checking `Foo::bytes::{{constant}}` + --> $DIR/issue-44415.rs:17:17 | LL | bytes: [u8; unsafe { intrinsics::size_of::() }], | ^^^^^^ + | note: ...which requires const-evaluating `Foo::bytes::{{constant}}`... - --> $DIR/issue-44415.rs:19:26 + --> $DIR/issue-44415.rs:17:26 | LL | bytes: [u8; unsafe { intrinsics::size_of::() }], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - = note: ...which again requires computing layout of `Foo`, completing the cycle -note: cycle used when const-evaluating `Foo::bytes::{{constant}}` - --> $DIR/issue-44415.rs:19:26 +note: ...which requires computing layout of `Foo`... +note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... +note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... + --> $DIR/issue-44415.rs:17:17 | LL | bytes: [u8; unsafe { intrinsics::size_of::() }], - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + | ^^^^^^ + = note: ...which again requires const-evaluating + checking `Foo::bytes::{{constant}}`, completing the cycle +note: cycle used when processing `Foo` + --> $DIR/issue-44415.rs:16:1 + | +LL | struct Foo { + | ^^^^^^^^^^ error: aborting due to previous error diff --git a/src/test/ui/recursion/recursive-static-definition.stderr b/src/test/ui/recursion/recursive-static-definition.stderr index 5bd0f90afbc..c9a5e5eb447 100644 --- a/src/test/ui/recursion/recursive-static-definition.stderr +++ b/src/test/ui/recursion/recursive-static-definition.stderr @@ -4,6 +4,11 @@ error[E0391]: cycle detected when const-evaluating `FOO` LL | pub static FOO: u32 = FOO; | ^^^ | +note: ...which requires const-evaluating `FOO`... + --> $DIR/recursive-static-definition.rs:11:1 + | +LL | pub static FOO: u32 = FOO; + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: ...which again requires const-evaluating `FOO`, completing the cycle note: cycle used when const-evaluating + checking `FOO` --> $DIR/recursive-static-definition.rs:11:1 -- cgit 1.4.1-3-g733a5 From 6a6b3309e63854cbd0f0e2a0b9bd305f6b96cf81 Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Tue, 4 Sep 2018 12:26:21 +0200 Subject: update tests to changes on rustc master --- .../const-pointer-values-in-various-types.rs | 14 +++--- .../const-pointer-values-in-various-types.stderr | 58 +++++++++++----------- src/test/ui/consts/const-eval/issue-52442.rs | 1 + src/test/ui/consts/const-eval/issue-52442.stderr | 13 ++++- src/test/ui/consts/const-eval/ref_to_int_match.rs | 4 +- .../ui/consts/const-eval/ref_to_int_match.stderr | 20 +++++--- src/test/ui/consts/const-size_of-cycle.stderr | 10 ++-- src/test/ui/issues/issue-44415.stderr | 8 +-- .../issues/issue-52023-array-size-pointer-cast.rs | 1 + .../issue-52023-array-size-pointer-cast.stderr | 13 ++++- 10 files changed, 85 insertions(+), 57 deletions(-) (limited to 'src/test') diff --git a/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs b/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs index 05d79a7d633..23e1ab013ef 100644 --- a/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs +++ b/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.rs @@ -22,7 +22,7 @@ union Nonsense { fn main() { const I32_REF_USIZE_UNION: usize = unsafe { Nonsense { int_32_ref: &3 }.u }; - //~^ ERROR this constant likely exhibits undefined behavior + //~^ ERROR it is undefined behavior to use this value const I32_REF_U8_UNION: u8 = unsafe { Nonsense { int_32_ref: &3 }.uint_8 }; //~^ ERROR any use of this value will cause an error @@ -34,7 +34,7 @@ fn main() { //~^ ERROR any use of this value will cause an error const I32_REF_U64_UNION: u64 = unsafe { Nonsense { int_32_ref: &3 }.uint_64 }; - //~^ ERROR this constant likely exhibits undefined behavior + //~^ ERROR it is undefined behavior to use this value const I32_REF_U128_UNION: u128 = unsafe { Nonsense { int_32_ref: &3 }.uint_128 }; //~^ ERROR any use of this value will cause an error @@ -49,7 +49,7 @@ fn main() { //~^ ERROR any use of this value will cause an error const I32_REF_I64_UNION: i64 = unsafe { Nonsense { int_32_ref: &3 }.int_64 }; - //~^ ERROR this constant likely exhibits undefined behavior + //~^ ERROR it is undefined behavior to use this value const I32_REF_I128_UNION: i128 = unsafe { Nonsense { int_32_ref: &3 }.int_128 }; //~^ ERROR any use of this value will cause an error @@ -58,7 +58,7 @@ fn main() { //~^ ERROR any use of this value will cause an error const I32_REF_F64_UNION: f64 = unsafe { Nonsense { int_32_ref: &3 }.float_64 }; - //~^ ERROR this constant likely exhibits undefined behavior + //~^ ERROR it is undefined behavior to use this value const I32_REF_BOOL_UNION: bool = unsafe { Nonsense { int_32_ref: &3 }.truthy_falsey }; //~^ ERROR any use of this value will cause an error @@ -76,7 +76,7 @@ fn main() { //~^ ERROR any use of this value will cause an error const STR_U64_UNION: u64 = unsafe { Nonsense { stringy: "3" }.uint_64 }; - //~^ ERROR this constant likely exhibits undefined behavior + //~^ ERROR it is undefined behavior to use this value const STR_U128_UNION: u128 = unsafe { Nonsense { stringy: "3" }.uint_128 }; //~^ ERROR any use of this value will cause an error @@ -91,7 +91,7 @@ fn main() { //~^ ERROR any use of this value will cause an error const STR_I64_UNION: i64 = unsafe { Nonsense { stringy: "3" }.int_64 }; - //~^ ERROR this constant likely exhibits undefined behavior + //~^ ERROR it is undefined behavior to use this value const STR_I128_UNION: i128 = unsafe { Nonsense { stringy: "3" }.int_128 }; //~^ ERROR any use of this value will cause an error @@ -100,7 +100,7 @@ fn main() { //~^ ERROR any use of this value will cause an error const STR_F64_UNION: f64 = unsafe { Nonsense { stringy: "3" }.float_64 }; - //~^ ERROR this constant likely exhibits undefined behavior + //~^ ERROR it is undefined behavior to use this value const STR_BOOL_UNION: bool = unsafe { Nonsense { stringy: "3" }.truthy_falsey }; //~^ ERROR any use of this value will cause an error diff --git a/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.stderr b/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.stderr index 7be9345b6b4..cc1db5db691 100644 --- a/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.stderr +++ b/src/test/ui/consts/const-eval/const-pointer-values-in-various-types.stderr @@ -1,4 +1,4 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/const-pointer-values-in-various-types.rs:24:5 | LL | const I32_REF_USIZE_UNION: usize = unsafe { Nonsense { int_32_ref: &3 }.u }; @@ -6,7 +6,7 @@ LL | const I32_REF_USIZE_UNION: usize = unsafe { Nonsense { int_32_ref: &3 } | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:27:5 | LL | const I32_REF_U8_UNION: u8 = unsafe { Nonsense { int_32_ref: &3 }.uint_8 }; @@ -16,7 +16,7 @@ LL | const I32_REF_U8_UNION: u8 = unsafe { Nonsense { int_32_ref: &3 }.uint_ | = note: #[deny(const_err)] on by default -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:30:5 | LL | const I32_REF_U16_UNION: u16 = unsafe { Nonsense { int_32_ref: &3 }.uint_16 }; @@ -24,7 +24,7 @@ LL | const I32_REF_U16_UNION: u16 = unsafe { Nonsense { int_32_ref: &3 }.uin | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:33:5 | LL | const I32_REF_U32_UNION: u32 = unsafe { Nonsense { int_32_ref: &3 }.uint_32 }; @@ -32,7 +32,7 @@ LL | const I32_REF_U32_UNION: u32 = unsafe { Nonsense { int_32_ref: &3 }.uin | | | a raw memory access tried to access part of a pointer value as raw bytes -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/const-pointer-values-in-various-types.rs:36:5 | LL | const I32_REF_U64_UNION: u64 = unsafe { Nonsense { int_32_ref: &3 }.uint_64 }; @@ -40,13 +40,13 @@ LL | const I32_REF_U64_UNION: u64 = unsafe { Nonsense { int_32_ref: &3 }.uin | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:39:5 | LL | const I32_REF_U128_UNION: u128 = unsafe { Nonsense { int_32_ref: &3 }.uint_128 }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempted to read undefined bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:42:5 | LL | const I32_REF_I8_UNION: i8 = unsafe { Nonsense { int_32_ref: &3 }.int_8 }; @@ -54,7 +54,7 @@ LL | const I32_REF_I8_UNION: i8 = unsafe { Nonsense { int_32_ref: &3 }.int_8 | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:45:5 | LL | const I32_REF_I16_UNION: i16 = unsafe { Nonsense { int_32_ref: &3 }.int_16 }; @@ -62,7 +62,7 @@ LL | const I32_REF_I16_UNION: i16 = unsafe { Nonsense { int_32_ref: &3 }.int | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:48:5 | LL | const I32_REF_I32_UNION: i32 = unsafe { Nonsense { int_32_ref: &3 }.int_32 }; @@ -70,7 +70,7 @@ LL | const I32_REF_I32_UNION: i32 = unsafe { Nonsense { int_32_ref: &3 }.int | | | a raw memory access tried to access part of a pointer value as raw bytes -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/const-pointer-values-in-various-types.rs:51:5 | LL | const I32_REF_I64_UNION: i64 = unsafe { Nonsense { int_32_ref: &3 }.int_64 }; @@ -78,13 +78,13 @@ LL | const I32_REF_I64_UNION: i64 = unsafe { Nonsense { int_32_ref: &3 }.int | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:54:5 | LL | const I32_REF_I128_UNION: i128 = unsafe { Nonsense { int_32_ref: &3 }.int_128 }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ attempted to read undefined bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:57:5 | LL | const I32_REF_F32_UNION: f32 = unsafe { Nonsense { int_32_ref: &3 }.float_32 }; @@ -92,7 +92,7 @@ LL | const I32_REF_F32_UNION: f32 = unsafe { Nonsense { int_32_ref: &3 }.flo | | | a raw memory access tried to access part of a pointer value as raw bytes -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/const-pointer-values-in-various-types.rs:60:5 | LL | const I32_REF_F64_UNION: f64 = unsafe { Nonsense { int_32_ref: &3 }.float_64 }; @@ -100,7 +100,7 @@ LL | const I32_REF_F64_UNION: f64 = unsafe { Nonsense { int_32_ref: &3 }.flo | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:63:5 | LL | const I32_REF_BOOL_UNION: bool = unsafe { Nonsense { int_32_ref: &3 }.truthy_falsey }; @@ -108,7 +108,7 @@ LL | const I32_REF_BOOL_UNION: bool = unsafe { Nonsense { int_32_ref: &3 }.t | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:66:5 | LL | const I32_REF_CHAR_UNION: char = unsafe { Nonsense { int_32_ref: &3 }.character }; @@ -116,7 +116,7 @@ LL | const I32_REF_CHAR_UNION: char = unsafe { Nonsense { int_32_ref: &3 }.c | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:69:5 | LL | const STR_U8_UNION: u8 = unsafe { Nonsense { stringy: "3" }.uint_8 }; @@ -124,7 +124,7 @@ LL | const STR_U8_UNION: u8 = unsafe { Nonsense { stringy: "3" }.uint_8 }; | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:72:5 | LL | const STR_U16_UNION: u16 = unsafe { Nonsense { stringy: "3" }.uint_16 }; @@ -132,7 +132,7 @@ LL | const STR_U16_UNION: u16 = unsafe { Nonsense { stringy: "3" }.uint_16 } | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:75:5 | LL | const STR_U32_UNION: u32 = unsafe { Nonsense { stringy: "3" }.uint_32 }; @@ -140,7 +140,7 @@ LL | const STR_U32_UNION: u32 = unsafe { Nonsense { stringy: "3" }.uint_32 } | | | a raw memory access tried to access part of a pointer value as raw bytes -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/const-pointer-values-in-various-types.rs:78:5 | LL | const STR_U64_UNION: u64 = unsafe { Nonsense { stringy: "3" }.uint_64 }; @@ -148,7 +148,7 @@ LL | const STR_U64_UNION: u64 = unsafe { Nonsense { stringy: "3" }.uint_64 } | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:81:5 | LL | const STR_U128_UNION: u128 = unsafe { Nonsense { stringy: "3" }.uint_128 }; @@ -156,7 +156,7 @@ LL | const STR_U128_UNION: u128 = unsafe { Nonsense { stringy: "3" }.uint_12 | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:84:5 | LL | const STR_I8_UNION: i8 = unsafe { Nonsense { stringy: "3" }.int_8 }; @@ -164,7 +164,7 @@ LL | const STR_I8_UNION: i8 = unsafe { Nonsense { stringy: "3" }.int_8 }; | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:87:5 | LL | const STR_I16_UNION: i16 = unsafe { Nonsense { stringy: "3" }.int_16 }; @@ -172,7 +172,7 @@ LL | const STR_I16_UNION: i16 = unsafe { Nonsense { stringy: "3" }.int_16 }; | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:90:5 | LL | const STR_I32_UNION: i32 = unsafe { Nonsense { stringy: "3" }.int_32 }; @@ -180,7 +180,7 @@ LL | const STR_I32_UNION: i32 = unsafe { Nonsense { stringy: "3" }.int_32 }; | | | a raw memory access tried to access part of a pointer value as raw bytes -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/const-pointer-values-in-various-types.rs:93:5 | LL | const STR_I64_UNION: i64 = unsafe { Nonsense { stringy: "3" }.int_64 }; @@ -188,7 +188,7 @@ LL | const STR_I64_UNION: i64 = unsafe { Nonsense { stringy: "3" }.int_64 }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:96:5 | LL | const STR_I128_UNION: i128 = unsafe { Nonsense { stringy: "3" }.int_128 }; @@ -196,7 +196,7 @@ LL | const STR_I128_UNION: i128 = unsafe { Nonsense { stringy: "3" }.int_128 | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:99:5 | LL | const STR_F32_UNION: f32 = unsafe { Nonsense { stringy: "3" }.float_32 }; @@ -204,7 +204,7 @@ LL | const STR_F32_UNION: f32 = unsafe { Nonsense { stringy: "3" }.float_32 | | | a raw memory access tried to access part of a pointer value as raw bytes -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/const-pointer-values-in-various-types.rs:102:5 | LL | const STR_F64_UNION: f64 = unsafe { Nonsense { stringy: "3" }.float_64 }; @@ -212,7 +212,7 @@ LL | const STR_F64_UNION: f64 = unsafe { Nonsense { stringy: "3" }.float_64 | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:105:5 | LL | const STR_BOOL_UNION: bool = unsafe { Nonsense { stringy: "3" }.truthy_falsey }; @@ -220,7 +220,7 @@ LL | const STR_BOOL_UNION: bool = unsafe { Nonsense { stringy: "3" }.truthy_ | | | a raw memory access tried to access part of a pointer value as raw bytes -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-pointer-values-in-various-types.rs:108:5 | LL | const STR_CHAR_UNION: char = unsafe { Nonsense { stringy: "3" }.character }; diff --git a/src/test/ui/consts/const-eval/issue-52442.rs b/src/test/ui/consts/const-eval/issue-52442.rs index 755dc153d40..8e207b712c3 100644 --- a/src/test/ui/consts/const-eval/issue-52442.rs +++ b/src/test/ui/consts/const-eval/issue-52442.rs @@ -10,4 +10,5 @@ fn main() { [(); { &loop { break } as *const _ as usize } ]; //~ ERROR unimplemented expression type + //~^ ERROR it is undefined behavior to use this value } diff --git a/src/test/ui/consts/const-eval/issue-52442.stderr b/src/test/ui/consts/const-eval/issue-52442.stderr index 586c9fa22ce..93fc4bea5ca 100644 --- a/src/test/ui/consts/const-eval/issue-52442.stderr +++ b/src/test/ui/consts/const-eval/issue-52442.stderr @@ -4,6 +4,15 @@ error[E0019]: constant contains unimplemented expression type LL | [(); { &loop { break } as *const _ as usize } ]; //~ ERROR unimplemented expression type | ^^^^^^^^^^^^^^ -error: aborting due to previous error +error[E0080]: it is undefined behavior to use this value + --> $DIR/issue-52442.rs:12:11 + | +LL | [(); { &loop { break } as *const _ as usize } ]; //~ ERROR unimplemented expression type + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected the type usize + | + = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior + +error: aborting due to 2 previous errors -For more information about this error, try `rustc --explain E0019`. +Some errors occurred: E0019, E0080. +For more information about an error, try `rustc --explain E0019`. diff --git a/src/test/ui/consts/const-eval/ref_to_int_match.rs b/src/test/ui/consts/const-eval/ref_to_int_match.rs index cb942f465e4..2254ed5d9e3 100644 --- a/src/test/ui/consts/const-eval/ref_to_int_match.rs +++ b/src/test/ui/consts/const-eval/ref_to_int_match.rs @@ -14,7 +14,7 @@ fn main() { let n: Int = 40; match n { 0..=10 => {}, - 10..=BAR => {}, //~ ERROR lower range bound must be less than or equal to upper + 10..=BAR => {}, //~ ERROR could not evaluate constant pattern _ => {}, } } @@ -30,4 +30,4 @@ type Int = u64; #[cfg(target_pointer_width="32")] type Int = u32; -const BAR: Int = unsafe { Foo { r: &42 }.f }; +const BAR: Int = unsafe { Foo { r: &42 }.f }; //~ ERROR it is undefined behavior to use this value diff --git a/src/test/ui/consts/const-eval/ref_to_int_match.stderr b/src/test/ui/consts/const-eval/ref_to_int_match.stderr index e82a16c066f..1e65a871de4 100644 --- a/src/test/ui/consts/const-eval/ref_to_int_match.stderr +++ b/src/test/ui/consts/const-eval/ref_to_int_match.stderr @@ -1,9 +1,17 @@ -error[E0030]: lower range bound must be less than or equal to upper - --> $DIR/ref_to_int_match.rs:17:9 +error[E0080]: it is undefined behavior to use this value + --> $DIR/ref_to_int_match.rs:33:1 | -LL | 10..=BAR => {}, //~ ERROR lower range bound must be less than or equal to upper - | ^^ lower bound larger than upper bound +LL | const BAR: Int = unsafe { Foo { r: &42 }.f }; //~ ERROR it is undefined behavior to use this value + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected the type u64 + | + = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior + +error: could not evaluate constant pattern + --> $DIR/ref_to_int_match.rs:17:14 + | +LL | 10..=BAR => {}, //~ ERROR could not evaluate constant pattern + | ^^^ -error: aborting due to previous error +error: aborting due to 2 previous errors -For more information about this error, try `rustc --explain E0030`. +For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-size_of-cycle.stderr b/src/test/ui/consts/const-size_of-cycle.stderr index 0c8fdfb6da2..8e1e81f7735 100644 --- a/src/test/ui/consts/const-size_of-cycle.stderr +++ b/src/test/ui/consts/const-size_of-cycle.stderr @@ -1,5 +1,5 @@ error[E0391]: cycle detected when const-evaluating + checking `Foo::bytes::{{constant}}` - --> $DIR/const-size_of-cycle.rs:16:17 + --> $DIR/const-size_of-cycle.rs:14:17 | LL | bytes: [u8; std::mem::size_of::()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -7,18 +7,18 @@ LL | bytes: [u8; std::mem::size_of::()] note: ...which requires const-evaluating `Foo::bytes::{{constant}}`... --> $SRC_DIR/libcore/mem.rs:LL:COL | -LL | unsafe { intrinsics::size_of::() } - | ^^^^^^^^^^^^^^^^^^^^^^^^^^ +LL | intrinsics::size_of::() + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ note: ...which requires computing layout of `Foo`... note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... - --> $DIR/const-size_of-cycle.rs:16:17 + --> $DIR/const-size_of-cycle.rs:14:17 | LL | bytes: [u8; std::mem::size_of::()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: ...which again requires const-evaluating + checking `Foo::bytes::{{constant}}`, completing the cycle note: cycle used when processing `Foo` - --> $DIR/const-size_of-cycle.rs:15:1 + --> $DIR/const-size_of-cycle.rs:13:1 | LL | struct Foo { | ^^^^^^^^^^ diff --git a/src/test/ui/issues/issue-44415.stderr b/src/test/ui/issues/issue-44415.stderr index 4345a5dbf43..e70dfe7ad4e 100644 --- a/src/test/ui/issues/issue-44415.stderr +++ b/src/test/ui/issues/issue-44415.stderr @@ -1,24 +1,24 @@ error[E0391]: cycle detected when const-evaluating + checking `Foo::bytes::{{constant}}` - --> $DIR/issue-44415.rs:17:17 + --> $DIR/issue-44415.rs:16:17 | LL | bytes: [u8; unsafe { intrinsics::size_of::() }], | ^^^^^^ | note: ...which requires const-evaluating `Foo::bytes::{{constant}}`... - --> $DIR/issue-44415.rs:17:26 + --> $DIR/issue-44415.rs:16:26 | LL | bytes: [u8; unsafe { intrinsics::size_of::() }], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ note: ...which requires computing layout of `Foo`... note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... - --> $DIR/issue-44415.rs:17:17 + --> $DIR/issue-44415.rs:16:17 | LL | bytes: [u8; unsafe { intrinsics::size_of::() }], | ^^^^^^ = note: ...which again requires const-evaluating + checking `Foo::bytes::{{constant}}`, completing the cycle note: cycle used when processing `Foo` - --> $DIR/issue-44415.rs:16:1 + --> $DIR/issue-44415.rs:15:1 | LL | struct Foo { | ^^^^^^^^^^ diff --git a/src/test/ui/issues/issue-52023-array-size-pointer-cast.rs b/src/test/ui/issues/issue-52023-array-size-pointer-cast.rs index 02bed69f0d4..46cbdb6ac22 100644 --- a/src/test/ui/issues/issue-52023-array-size-pointer-cast.rs +++ b/src/test/ui/issues/issue-52023-array-size-pointer-cast.rs @@ -10,4 +10,5 @@ fn main() { let _ = [0; (&0 as *const i32) as usize]; //~ ERROR casting pointers to integers in constants + //~^ ERROR it is undefined behavior to use this value } diff --git a/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr b/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr index 74270c2bef7..ba415d43a75 100644 --- a/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr +++ b/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr @@ -6,6 +6,15 @@ LL | let _ = [0; (&0 as *const i32) as usize]; //~ ERROR casting pointers to | = help: add #![feature(const_raw_ptr_to_usize_cast)] to the crate attributes to enable -error: aborting due to previous error +error[E0080]: it is undefined behavior to use this value + --> $DIR/issue-52023-array-size-pointer-cast.rs:12:17 + | +LL | let _ = [0; (&0 as *const i32) as usize]; //~ ERROR casting pointers to integers in constants + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected the type usize + | + = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior + +error: aborting due to 2 previous errors -For more information about this error, try `rustc --explain E0658`. +Some errors occurred: E0080, E0658. +For more information about an error, try `rustc --explain E0080`. -- cgit 1.4.1-3-g733a5 From 528c72371c99f1da4a13fb15321ed7b9c1b34c1e Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Tue, 4 Sep 2018 14:04:55 +0200 Subject: More mono items are generated now --- src/test/codegen-units/partitioning/vtable-through-const.rs | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/test') diff --git a/src/test/codegen-units/partitioning/vtable-through-const.rs b/src/test/codegen-units/partitioning/vtable-through-const.rs index 74533c1015b..ebda08a29f6 100644 --- a/src/test/codegen-units/partitioning/vtable-through-const.rs +++ b/src/test/codegen-units/partitioning/vtable-through-const.rs @@ -38,6 +38,7 @@ mod mod1 { fn do_something_else(&self, x: T) -> T { x } } + //~ MONO_ITEM fn vtable_through_const::mod1[0]::id[0] @@ vtable_through_const-mod1.volatile[Internal] fn id(x: T) -> T { x } // These are referenced, so they produce mono-items (see start()) @@ -52,6 +53,8 @@ mod mod1 { fn do_something_else(&self) {} } + //~ MONO_ITEM fn vtable_through_const::mod1[0]::Trait2[0]::do_something[0] @@ vtable_through_const-mod1.volatile[Internal] + //~ MONO_ITEM fn vtable_through_const::mod1[0]::Trait2[0]::do_something_else[0] @@ vtable_through_const-mod1.volatile[Internal] impl Trait2 for u32 {} pub trait Trait2Gen { @@ -89,6 +92,8 @@ fn start(_: isize, _: *const *const u8) -> isize { // Same as above //~ MONO_ITEM fn vtable_through_const::mod1[0]::{{impl}}[1]::do_something[0] @@ vtable_through_const-mod1.volatile[External] //~ MONO_ITEM fn vtable_through_const::mod1[0]::{{impl}}[1]::do_something_else[0] @@ vtable_through_const-mod1.volatile[External] + //~ MONO_ITEM fn vtable_through_const::mod1[0]::{{impl}}[3]::do_something[0] @@ vtable_through_const-mod1.volatile[Internal] + //~ MONO_ITEM fn vtable_through_const::mod1[0]::{{impl}}[3]::do_something_else[0] @@ vtable_through_const-mod1.volatile[Internal] mod1::TRAIT1_GEN_REF.do_something(0u8); //~ MONO_ITEM fn vtable_through_const::mod1[0]::id[0] @@ vtable_through_const-mod1.volatile[External] -- cgit 1.4.1-3-g733a5 From f4a3e50d782c609f0868d06fc2b03fbea6774a2f Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Tue, 4 Sep 2018 16:09:30 +0200 Subject: Update rustdoc test --- src/test/rustdoc/const-evalutation-ice.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/test') diff --git a/src/test/rustdoc/const-evalutation-ice.rs b/src/test/rustdoc/const-evalutation-ice.rs index 000ed709a8a..5675f61bd4b 100644 --- a/src/test/rustdoc/const-evalutation-ice.rs +++ b/src/test/rustdoc/const-evalutation-ice.rs @@ -17,4 +17,4 @@ pub struct S { s: Cell } -pub type _S = [usize; 0 - (mem::size_of::() != 4) as usize]; +pub const N: usize = 0 - (mem::size_of::() != 4) as usize; -- cgit 1.4.1-3-g733a5 From bf8471aeda0a00c37a4798942ef9d5ae551eef20 Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Fri, 7 Sep 2018 10:53:31 +0200 Subject: Rebase fallout in ui output --- src/librustc_codegen_llvm/mir/operand.rs | 2 -- .../const-eval/const_panic_libcore_main.stderr | 6 +++--- src/test/ui/consts/const-eval/issue-52475.rs | 3 +-- src/test/ui/consts/const-eval/issue-52475.stderr | 24 +++++++--------------- src/test/ui/consts/const-int-unchecked.stderr | 4 ++-- 5 files changed, 13 insertions(+), 26 deletions(-) (limited to 'src/test') diff --git a/src/librustc_codegen_llvm/mir/operand.rs b/src/librustc_codegen_llvm/mir/operand.rs index 25f03cbe970..d1b6aa7fc42 100644 --- a/src/librustc_codegen_llvm/mir/operand.rs +++ b/src/librustc_codegen_llvm/mir/operand.rs @@ -12,8 +12,6 @@ use rustc::mir::interpret::{ConstValue, ErrorHandled}; use rustc::mir; use rustc::ty; use rustc::ty::layout::{self, Align, LayoutOf, TyLayout}; -use rustc_data_structures::sync::Lrc; -use rustc_data_structures::indexed_vec::Idx; use base; use common::{CodegenCx, C_undef, C_usize}; diff --git a/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr b/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr index 9a7c510029c..50794c8f065 100644 --- a/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr +++ b/src/test/ui/consts/const-eval/const_panic_libcore_main.stderr @@ -1,5 +1,5 @@ error: any use of this value will cause an error - --> $DIR/const_panic_libcore_main.rs:20:1 + --> $DIR/const_panic_libcore_main.rs:19:1 | LL | const Z: () = panic!("cheese"); | ^^^^^^^^^^^^^^----------------^ @@ -10,7 +10,7 @@ LL | const Z: () = panic!("cheese"); = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) error: any use of this value will cause an error - --> $DIR/const_panic_libcore_main.rs:23:1 + --> $DIR/const_panic_libcore_main.rs:22:1 | LL | const Y: () = unreachable!(); | ^^^^^^^^^^^^^^--------------^ @@ -20,7 +20,7 @@ LL | const Y: () = unreachable!(); = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) error: any use of this value will cause an error - --> $DIR/const_panic_libcore_main.rs:26:1 + --> $DIR/const_panic_libcore_main.rs:25:1 | LL | const X: () = unimplemented!(); | ^^^^^^^^^^^^^^----------------^ diff --git a/src/test/ui/consts/const-eval/issue-52475.rs b/src/test/ui/consts/const-eval/issue-52475.rs index 1c1e6535e69..b21c1827e2b 100644 --- a/src/test/ui/consts/const-eval/issue-52475.rs +++ b/src/test/ui/consts/const-eval/issue-52475.rs @@ -13,11 +13,10 @@ fn main() { let _ = [(); { //~^ WARNING Constant evaluating a complex constant, this might take some time - //~| ERROR could not evaluate repeat length let mut x = &0; let mut n = 0; while n < 5 { //~ ERROR constant contains unimplemented expression type - n = (n + 1) % 5; + n = (n + 1) % 5; //~ ERROR evaluation of constant value failed x = &0; // Materialize a new AllocId } 0 diff --git a/src/test/ui/consts/const-eval/issue-52475.stderr b/src/test/ui/consts/const-eval/issue-52475.stderr index f45587f3f75..c0cd98b2fca 100644 --- a/src/test/ui/consts/const-eval/issue-52475.stderr +++ b/src/test/ui/consts/const-eval/issue-52475.stderr @@ -1,8 +1,8 @@ error[E0019]: constant contains unimplemented expression type - --> $DIR/issue-52475.rs:19:9 + --> $DIR/issue-52475.rs:18:9 | LL | / while n < 5 { //~ ERROR constant contains unimplemented expression type -LL | | n = (n + 1) % 5; +LL | | n = (n + 1) % 5; //~ ERROR evaluation of constant value failed LL | | x = &0; // Materialize a new AllocId LL | | } | |_________^ @@ -13,28 +13,18 @@ warning: Constant evaluating a complex constant, this might take some time LL | let _ = [(); { | __________________^ LL | | //~^ WARNING Constant evaluating a complex constant, this might take some time -LL | | //~| ERROR could not evaluate repeat length LL | | let mut x = &0; +LL | | let mut n = 0; ... | LL | | 0 LL | | }]; | |_____^ -error[E0080]: could not evaluate repeat length - --> $DIR/issue-52475.rs:14:18 +error[E0080]: evaluation of constant value failed + --> $DIR/issue-52475.rs:19:17 | -LL | let _ = [(); { - | __________________^ -LL | | //~^ WARNING Constant evaluating a complex constant, this might take some time -LL | | //~| ERROR could not evaluate repeat length -LL | | let mut x = &0; -... | -LL | | n = (n + 1) % 5; - | | ----------- duplicate interpreter state observed here, const evaluation will never terminate -... | -LL | | 0 -LL | | }]; - | |_____^ +LL | n = (n + 1) % 5; //~ ERROR evaluation of constant value failed + | ^^^^^^^^^^^ duplicate interpreter state observed here, const evaluation will never terminate error: aborting due to 2 previous errors diff --git a/src/test/ui/consts/const-int-unchecked.stderr b/src/test/ui/consts/const-int-unchecked.stderr index b8fd0facbc1..314a3e488a1 100644 --- a/src/test/ui/consts/const-int-unchecked.stderr +++ b/src/test/ui/consts/const-int-unchecked.stderr @@ -1,4 +1,4 @@ -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-int-unchecked.rs:15:1 | LL | const SHR: u8 = unsafe { intrinsics::unchecked_shr(5_u8, 8) }; @@ -8,7 +8,7 @@ LL | const SHR: u8 = unsafe { intrinsics::unchecked_shr(5_u8, 8) }; | = note: #[deny(const_err)] on by default -error: this constant cannot be used +error: any use of this value will cause an error --> $DIR/const-int-unchecked.rs:17:1 | LL | const SHL: u8 = unsafe { intrinsics::unchecked_shl(5_u8, 8) }; -- cgit 1.4.1-3-g733a5 From 7c34f2da577a0b3b8effdbcc0705499bc2a6861f Mon Sep 17 00:00:00 2001 From: Alexander Regueiro Date: Tue, 18 Sep 2018 04:26:39 +0100 Subject: Addressed minor issues brought up in review. --- src/librustc_mir/const_eval.rs | 15 +++++++++------ src/test/rustdoc/const-evalutation-ice.rs | 2 +- .../const-eval/promoted_const_fn_fail_deny_const_err.rs | 10 ++++------ .../promoted_const_fn_fail_deny_const_err.stderr | 3 +-- 4 files changed, 15 insertions(+), 15 deletions(-) (limited to 'src/test') diff --git a/src/librustc_mir/const_eval.rs b/src/librustc_mir/const_eval.rs index 5cda7154774..c501ef8eceb 100644 --- a/src/librustc_mir/const_eval.rs +++ b/src/librustc_mir/const_eval.rs @@ -597,12 +597,14 @@ pub fn const_eval_raw_provider<'a, 'tcx>( tcx: TyCtxt<'a, 'tcx, 'tcx>, key: ty::ParamEnvAnd<'tcx, GlobalId<'tcx>>, ) -> ::rustc::mir::interpret::ConstEvalResult<'tcx> { - // so we do a small trick here. We check whether we can evaluate the constant in the more - // restrictive `Reveal::UserFacing`, which most likely already was computed. In a large - // percentage of constants that will already have succeeded. Only associated constants of - // generic functions will fail due to not enough monomorphization information being available - - // in case we fail in the `UserFacing` variant, we just do the real computation. + // Because the constant is computed twice (once per value of `Reveal`), we are at risk of + // reporting the same error twice here. To resolve this, we check whether we can evaluate the + // constant in the more restrictive `Reveal::UserFacing`, which most likely already was + // computed. For a large percentage of constants that will already have succeeded. Only + // associated constants of generic functions will fail due to not enough monomorphization + // information being available. + + // In case we fail in the `UserFacing` variant, we just do the real computation. if key.param_env.reveal == Reveal::All { let mut key = key.clone(); key.param_env.reveal = Reveal::UserFacing; @@ -614,6 +616,7 @@ pub fn const_eval_raw_provider<'a, 'tcx>( } } trace!("const eval: {:?}", key); + let cid = key.value; let def_id = cid.instance.def.def_id(); diff --git a/src/test/rustdoc/const-evalutation-ice.rs b/src/test/rustdoc/const-evalutation-ice.rs index 5675f61bd4b..64a20d49876 100644 --- a/src/test/rustdoc/const-evalutation-ice.rs +++ b/src/test/rustdoc/const-evalutation-ice.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -// Just check if we don't get an ICE for the _S type. +// Just check we don't get an ICE for the S type. use std::cell::Cell; use std::mem; diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs index 9f19e68f2a8..dca8f3c4745 100644 --- a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.rs @@ -19,17 +19,15 @@ union Bar { const fn bar() -> u8 { unsafe { - // this will error as long as this test - // is run on a system whose pointers need more - // than 8 bits + // This will error as long as this test is run on a system whose + // pointers need more than 8 bits. Bar { a: &42 }.b as u8 } } fn main() { - // FIXME(oli-obk): this should panic at runtime - // this will actually compile, but then - // abort at runtime (not panic, hard abort). + // This will compile, but then hard-abort at runtime. + // FIXME(oli-obk): this should instead panic (not hard-abort) at runtime. let x: &'static u8 = &(bar() + 1); let y = *x; unreachable!(); diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr index 3eeacbf842a..8e21f909954 100644 --- a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr @@ -1,5 +1,5 @@ error: reaching this expression at runtime will panic or abort - --> $DIR/promoted_const_fn_fail_deny_const_err.rs:33:26 + --> $DIR/promoted_const_fn_fail_deny_const_err.rs:31:26 | LL | Bar { a: &42 }.b as u8 | ---------------------- a raw memory access tried to access part of a pointer value as raw bytes @@ -16,4 +16,3 @@ LL | #![deny(const_err)] | ^^^^^^^^^ error: aborting due to previous error - -- cgit 1.4.1-3-g733a5 From 7717a63182722b33d9c5c298157d54eaaf23dab2 Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Wed, 19 Sep 2018 09:30:25 +0200 Subject: fix a test comment --- src/test/rustdoc/const-evalutation-ice.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/test') diff --git a/src/test/rustdoc/const-evalutation-ice.rs b/src/test/rustdoc/const-evalutation-ice.rs index 64a20d49876..1c04c34ea68 100644 --- a/src/test/rustdoc/const-evalutation-ice.rs +++ b/src/test/rustdoc/const-evalutation-ice.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -// Just check we don't get an ICE for the S type. +// Just check we don't get an ICE for `N`. use std::cell::Cell; use std::mem; -- cgit 1.4.1-3-g733a5 From 94586bc13326237c5aac566b1972dcd9b1b14000 Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Wed, 19 Sep 2018 10:59:01 +0200 Subject: fix ui tests (rebase fallout) --- .../consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr | 1 + src/test/ui/consts/const-size_of-cycle.stderr | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'src/test') diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr index 8e21f909954..c44acf9f1f8 100644 --- a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr @@ -16,3 +16,4 @@ LL | #![deny(const_err)] | ^^^^^^^^^ error: aborting due to previous error + diff --git a/src/test/ui/consts/const-size_of-cycle.stderr b/src/test/ui/consts/const-size_of-cycle.stderr index 8e1e81f7735..e824657f8af 100644 --- a/src/test/ui/consts/const-size_of-cycle.stderr +++ b/src/test/ui/consts/const-size_of-cycle.stderr @@ -1,5 +1,5 @@ error[E0391]: cycle detected when const-evaluating + checking `Foo::bytes::{{constant}}` - --> $DIR/const-size_of-cycle.rs:14:17 + --> $DIR/const-size_of-cycle.rs:16:17 | LL | bytes: [u8; std::mem::size_of::()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -12,13 +12,13 @@ LL | intrinsics::size_of::() note: ...which requires computing layout of `Foo`... note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All }, value: [u8; _] }`... note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}`... - --> $DIR/const-size_of-cycle.rs:14:17 + --> $DIR/const-size_of-cycle.rs:16:17 | LL | bytes: [u8; std::mem::size_of::()] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: ...which again requires const-evaluating + checking `Foo::bytes::{{constant}}`, completing the cycle note: cycle used when processing `Foo` - --> $DIR/const-size_of-cycle.rs:13:1 + --> $DIR/const-size_of-cycle.rs:15:1 | LL | struct Foo { | ^^^^^^^^^^ -- cgit 1.4.1-3-g733a5 From 7ed7fc881e7f4dabcdc45646257ddb979822d7f4 Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Wed, 19 Sep 2018 17:22:03 +0200 Subject: add the lint back to the list, and fix tests --- src/librustc_lint/builtin.rs | 15 ------- src/librustc_lint/lib.rs | 1 + src/test/ui/array_const_index-0.rs | 2 +- src/test/ui/array_const_index-0.stderr | 9 +--- src/test/ui/array_const_index-1.rs | 2 +- src/test/ui/array_const_index-1.stderr | 9 +--- src/test/ui/consts/const-err-early.rs | 12 ++--- src/test/ui/consts/const-err-early.stderr | 39 +---------------- src/test/ui/consts/const-err-multi.rs | 1 - src/test/ui/consts/const-err-multi.stderr | 9 +--- .../ui/consts/const-eval/const-eval-overflow2.rs | 16 +++---- .../consts/const-eval/const-eval-overflow2.stderr | 51 +--------------------- .../ui/consts/const-eval/const-eval-overflow2b.rs | 16 +++---- .../consts/const-eval/const-eval-overflow2b.stderr | 51 +--------------------- .../ui/consts/const-eval/const-eval-overflow2c.rs | 16 +++---- .../consts/const-eval/const-eval-overflow2c.stderr | 51 +--------------------- src/test/ui/consts/const-eval/pub_const_err.rs | 2 - src/test/ui/consts/const-eval/pub_const_err_bin.rs | 2 - .../ui/consts/const-eval/union-const-eval-field.rs | 2 - .../const-eval/union-const-eval-field.stderr | 22 +--------- .../ui/consts/const-eval/unused-broken-const.rs | 18 ++++++++ .../consts/const-eval/unused-broken-const.stderr | 14 ++++++ src/test/ui/consts/const-slice-oob.rs | 1 - src/test/ui/consts/const-slice-oob.stderr | 9 +--- 24 files changed, 74 insertions(+), 296 deletions(-) create mode 100644 src/test/ui/consts/const-eval/unused-broken-const.rs create mode 100644 src/test/ui/consts/const-eval/unused-broken-const.stderr (limited to 'src/test') diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index 597b6ae2366..c50f57e6c90 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -1607,17 +1607,6 @@ fn check_const(cx: &LateContext, body_id: hir::BodyId) { let _ = cx.tcx.const_eval(param_env.and(cid)); } -struct UnusedBrokenConstVisitor<'a, 'tcx: 'a>(&'a LateContext<'a, 'tcx>); - -impl<'a, 'tcx, 'v> hir::intravisit::Visitor<'v> for UnusedBrokenConstVisitor<'a, 'tcx> { - fn visit_nested_body(&mut self, id: hir::BodyId) { - check_const(self.0, id); - } - fn nested_visit_map<'this>(&'this mut self) -> hir::intravisit::NestedVisitorMap<'this, 'v> { - hir::intravisit::NestedVisitorMap::None - } -} - impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnusedBrokenConst { fn check_item(&mut self, cx: &LateContext, it: &hir::Item) { match it.node { @@ -1627,10 +1616,6 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnusedBrokenConst { hir::ItemKind::Static(_, _, body_id) => { check_const(cx, body_id); }, - hir::ItemKind::Ty(ref ty, _) => hir::intravisit::walk_ty( - &mut UnusedBrokenConstVisitor(cx), - ty - ), _ => {}, } } diff --git a/src/librustc_lint/lib.rs b/src/librustc_lint/lib.rs index 211b8471115..5bf2b76e668 100644 --- a/src/librustc_lint/lib.rs +++ b/src/librustc_lint/lib.rs @@ -152,6 +152,7 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) { UnreachablePub: UnreachablePub, UnnameableTestItems: UnnameableTestItems::new(), TypeAliasBounds: TypeAliasBounds, + UnusedBrokenConst: UnusedBrokenConst, TrivialConstraints: TrivialConstraints, TypeLimits: TypeLimits::new(), MissingDoc: MissingDoc::new(), diff --git a/src/test/ui/array_const_index-0.rs b/src/test/ui/array_const_index-0.rs index 0ad297eeb5c..e82458b10d9 100644 --- a/src/test/ui/array_const_index-0.rs +++ b/src/test/ui/array_const_index-0.rs @@ -14,5 +14,5 @@ const B: i32 = (&A)[1]; //~| ERROR any use of this value will cause an error fn main() { - let _ = B; //~ ERROR erroneous constant used + let _ = B; } diff --git a/src/test/ui/array_const_index-0.stderr b/src/test/ui/array_const_index-0.stderr index 38163b1f4b1..49c316eee12 100644 --- a/src/test/ui/array_const_index-0.stderr +++ b/src/test/ui/array_const_index-0.stderr @@ -8,12 +8,5 @@ LL | const B: i32 = (&A)[1]; | = note: #[deny(const_err)] on by default -error[E0080]: erroneous constant used - --> $DIR/array_const_index-0.rs:17:13 - | -LL | let _ = B; //~ ERROR erroneous constant used - | ^ referenced constant has errors - -error: aborting due to 2 previous errors +error: aborting due to previous error -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/array_const_index-1.rs b/src/test/ui/array_const_index-1.rs index 4c7dcfbb347..21028a447f4 100644 --- a/src/test/ui/array_const_index-1.rs +++ b/src/test/ui/array_const_index-1.rs @@ -14,5 +14,5 @@ const B: i32 = A[1]; //~| ERROR any use of this value will cause an error fn main() { - let _ = B; //~ ERROR erroneous constant used + let _ = B; } diff --git a/src/test/ui/array_const_index-1.stderr b/src/test/ui/array_const_index-1.stderr index b122e590c88..fa0e6e6afc6 100644 --- a/src/test/ui/array_const_index-1.stderr +++ b/src/test/ui/array_const_index-1.stderr @@ -8,12 +8,5 @@ LL | const B: i32 = A[1]; | = note: #[deny(const_err)] on by default -error[E0080]: erroneous constant used - --> $DIR/array_const_index-1.rs:17:13 - | -LL | let _ = B; //~ ERROR erroneous constant used - | ^ referenced constant has errors - -error: aborting due to 2 previous errors +error: aborting due to previous error -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err-early.rs b/src/test/ui/consts/const-err-early.rs index 1cbfb918427..39b1b342eac 100644 --- a/src/test/ui/consts/const-err-early.rs +++ b/src/test/ui/consts/const-err-early.rs @@ -17,10 +17,10 @@ pub const D: u8 = 42u8 - (42u8 + 1); //~ ERROR const_err pub const E: u8 = [5u8][1]; //~ ERROR const_err fn main() { - let _a = A; //~ ERROR erroneous constant used - let _b = B; //~ ERROR erroneous constant used - let _c = C; //~ ERROR erroneous constant used - let _d = D; //~ ERROR erroneous constant used - let _e = E; //~ ERROR erroneous constant used - let _e = [6u8][1]; //~ ERROR index out of bounds + let _a = A; + let _b = B; + let _c = C; + let _d = D; + let _e = E; + let _e = [6u8][1]; } diff --git a/src/test/ui/consts/const-err-early.stderr b/src/test/ui/consts/const-err-early.stderr index 8cc112191b5..1dd6c096e37 100644 --- a/src/test/ui/consts/const-err-early.stderr +++ b/src/test/ui/consts/const-err-early.stderr @@ -44,42 +44,5 @@ LL | pub const E: u8 = [5u8][1]; //~ ERROR const_err | | | index out of bounds: the len is 1 but the index is 1 -error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:20:14 - | -LL | let _a = A; //~ ERROR erroneous constant used - | ^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:21:14 - | -LL | let _b = B; //~ ERROR erroneous constant used - | ^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:22:14 - | -LL | let _c = C; //~ ERROR erroneous constant used - | ^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:23:14 - | -LL | let _d = D; //~ ERROR erroneous constant used - | ^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-err-early.rs:24:14 - | -LL | let _e = E; //~ ERROR erroneous constant used - | ^ referenced constant has errors - -error: index out of bounds: the len is 1 but the index is 1 - --> $DIR/const-err-early.rs:25:14 - | -LL | let _e = [6u8][1]; //~ ERROR index out of bounds - | ^^^^^^^^ - -error: aborting due to 11 previous errors +error: aborting due to 5 previous errors -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-err-multi.rs b/src/test/ui/consts/const-err-multi.rs index 20eaebfbe56..5cf3114c64a 100644 --- a/src/test/ui/consts/const-err-multi.rs +++ b/src/test/ui/consts/const-err-multi.rs @@ -21,5 +21,4 @@ pub const D: i8 = 50 - A; fn main() { let _ = (A, B, C, D); - //~^ ERROR erroneous constant used } diff --git a/src/test/ui/consts/const-err-multi.stderr b/src/test/ui/consts/const-err-multi.stderr index da6f31a3886..e77a31a9f5f 100644 --- a/src/test/ui/consts/const-err-multi.stderr +++ b/src/test/ui/consts/const-err-multi.stderr @@ -36,12 +36,5 @@ LL | pub const D: i8 = 50 - A; | | | referenced constant has errors -error[E0080]: erroneous constant used - --> $DIR/const-err-multi.rs:23:13 - | -LL | let _ = (A, B, C, D); - | ^^^^^^^^^^^^ referenced constant has errors - -error: aborting due to 5 previous errors +error: aborting due to 4 previous errors -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2.rs b/src/test/ui/consts/const-eval/const-eval-overflow2.rs index c61a1b3edb7..8e094a7f7dc 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2.rs @@ -60,15 +60,15 @@ const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error ); fn main() { - foo(VALS_I8); //~ ERROR erroneous constant used - foo(VALS_I16); //~ ERROR erroneous constant used - foo(VALS_I32); //~ ERROR erroneous constant used - foo(VALS_I64); //~ ERROR erroneous constant used + foo(VALS_I8); + foo(VALS_I16); + foo(VALS_I32); + foo(VALS_I64); - foo(VALS_U8); //~ ERROR erroneous constant used - foo(VALS_U16); //~ ERROR erroneous constant used - foo(VALS_U32); //~ ERROR erroneous constant used - foo(VALS_U64); //~ ERROR erroneous constant used + foo(VALS_U8); + foo(VALS_U16); + foo(VALS_U32); + foo(VALS_U64); } fn foo(_: T) { diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2.stderr index 0484335fd0c..596ba6bb223 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2.stderr @@ -82,54 +82,5 @@ LL | | u64::MIN - 1, LL | | ); | |_______^ -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:63:5 - | -LL | foo(VALS_I8); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:64:5 - | -LL | foo(VALS_I16); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:65:5 - | -LL | foo(VALS_I32); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:66:5 - | -LL | foo(VALS_I64); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:68:5 - | -LL | foo(VALS_U8); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:69:5 - | -LL | foo(VALS_U16); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:70:5 - | -LL | foo(VALS_U32); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2.rs:71:5 - | -LL | foo(VALS_U64); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error: aborting due to 16 previous errors +error: aborting due to 8 previous errors -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2b.rs b/src/test/ui/consts/const-eval/const-eval-overflow2b.rs index 47b0977ec1d..c69d03071e7 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2b.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2b.rs @@ -60,15 +60,15 @@ const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error ); fn main() { - foo(VALS_I8); //~ ERROR erroneous constant used - foo(VALS_I16); //~ ERROR erroneous constant used - foo(VALS_I32); //~ ERROR erroneous constant used - foo(VALS_I64); //~ ERROR erroneous constant used + foo(VALS_I8); + foo(VALS_I16); + foo(VALS_I32); + foo(VALS_I64); - foo(VALS_U8); //~ ERROR erroneous constant used - foo(VALS_U16); //~ ERROR erroneous constant used - foo(VALS_U32); //~ ERROR erroneous constant used - foo(VALS_U64); //~ ERROR erroneous constant used + foo(VALS_U8); + foo(VALS_U16); + foo(VALS_U32); + foo(VALS_U64); } fn foo(_: T) { diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr index 8922b35a0b2..82f245eaee8 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2b.stderr @@ -82,54 +82,5 @@ LL | | u64::MAX + 1, LL | | ); | |_______^ -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:63:5 - | -LL | foo(VALS_I8); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:64:5 - | -LL | foo(VALS_I16); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:65:5 - | -LL | foo(VALS_I32); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:66:5 - | -LL | foo(VALS_I64); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:68:5 - | -LL | foo(VALS_U8); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:69:5 - | -LL | foo(VALS_U16); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:70:5 - | -LL | foo(VALS_U32); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2b.rs:71:5 - | -LL | foo(VALS_U64); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error: aborting due to 16 previous errors +error: aborting due to 8 previous errors -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2c.rs b/src/test/ui/consts/const-eval/const-eval-overflow2c.rs index b4e1a0bc099..f442661ec63 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2c.rs +++ b/src/test/ui/consts/const-eval/const-eval-overflow2c.rs @@ -60,15 +60,15 @@ const VALS_U64: (u64,) = //~ ERROR any use of this value will cause an error ); fn main() { - foo(VALS_I8); //~ ERROR erroneous constant used - foo(VALS_I16); //~ ERROR erroneous constant used - foo(VALS_I32); //~ ERROR erroneous constant used - foo(VALS_I64); //~ ERROR erroneous constant used + foo(VALS_I8); + foo(VALS_I16); + foo(VALS_I32); + foo(VALS_I64); - foo(VALS_U8); //~ ERROR erroneous constant used - foo(VALS_U16); //~ ERROR erroneous constant used - foo(VALS_U32); //~ ERROR erroneous constant used - foo(VALS_U64); //~ ERROR erroneous constant used + foo(VALS_U8); + foo(VALS_U16); + foo(VALS_U32); + foo(VALS_U64); } fn foo(_: T) { diff --git a/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr b/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr index 023156a40dd..91064eb867d 100644 --- a/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr +++ b/src/test/ui/consts/const-eval/const-eval-overflow2c.stderr @@ -82,54 +82,5 @@ LL | | u64::MAX * 2, LL | | ); | |_______^ -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:63:5 - | -LL | foo(VALS_I8); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:64:5 - | -LL | foo(VALS_I16); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:65:5 - | -LL | foo(VALS_I32); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:66:5 - | -LL | foo(VALS_I64); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:68:5 - | -LL | foo(VALS_U8); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:69:5 - | -LL | foo(VALS_U16); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:70:5 - | -LL | foo(VALS_U32); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error[E0080]: erroneous constant used - --> $DIR/const-eval-overflow2c.rs:71:5 - | -LL | foo(VALS_U64); //~ ERROR erroneous constant used - | ^^^^^^^^^^^^^ referenced constant has errors - -error: aborting due to 16 previous errors +error: aborting due to 8 previous errors -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/pub_const_err.rs b/src/test/ui/consts/const-eval/pub_const_err.rs index 48c172b5e31..41cf844a8e2 100644 --- a/src/test/ui/consts/const-eval/pub_const_err.rs +++ b/src/test/ui/consts/const-eval/pub_const_err.rs @@ -17,5 +17,3 @@ pub const Z: u32 = 0 - 1; //~^ WARN any use of this value will cause an error pub type Foo = [i32; 0 - 1]; -//~^ WARN attempt to subtract with overflow -//~| WARN this array length cannot be used diff --git a/src/test/ui/consts/const-eval/pub_const_err_bin.rs b/src/test/ui/consts/const-eval/pub_const_err_bin.rs index 849d40cf107..0ee7d603e31 100644 --- a/src/test/ui/consts/const-eval/pub_const_err_bin.rs +++ b/src/test/ui/consts/const-eval/pub_const_err_bin.rs @@ -15,7 +15,5 @@ pub const Z: u32 = 0 - 1; //~^ WARN any use of this value will cause an error pub type Foo = [i32; 0 - 1]; -//~^ WARN attempt to subtract with overflow -//~| WARN this array length cannot be used fn main() {} diff --git a/src/test/ui/consts/const-eval/union-const-eval-field.rs b/src/test/ui/consts/const-eval/union-const-eval-field.rs index 759dab6c256..c0bfbc17629 100644 --- a/src/test/ui/consts/const-eval/union-const-eval-field.rs +++ b/src/test/ui/consts/const-eval/union-const-eval-field.rs @@ -36,12 +36,10 @@ const fn read_field2() -> Field2 { const fn read_field3() -> Field3 { const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of this value FIELD3 - //~^ erroneous constant used } fn main() { assert_eq!(read_field1(), FLOAT1_AS_I32); assert_eq!(read_field2(), 1.0); assert_eq!(read_field3(), unsafe { UNION.field3 }); - //~^ ERROR evaluation of constant expression failed } diff --git a/src/test/ui/consts/const-eval/union-const-eval-field.stderr b/src/test/ui/consts/const-eval/union-const-eval-field.stderr index 6a64f0c3671..565cd916ffc 100644 --- a/src/test/ui/consts/const-eval/union-const-eval-field.stderr +++ b/src/test/ui/consts/const-eval/union-const-eval-field.stderr @@ -6,25 +6,5 @@ LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR any use of th | = note: #[deny(const_err)] on by default -error[E0080]: erroneous constant used - --> $DIR/union-const-eval-field.rs:38:5 - | -LL | FIELD3 - | ^^^^^^ referenced constant has errors - -error[E0080]: evaluation of constant expression failed - --> $DIR/union-const-eval-field.rs:45:5 - | -LL | FIELD3 - | ------ referenced constant has errors -... -LL | assert_eq!(read_field3(), unsafe { UNION.field3 }); - | ^^^^^^^^^^^-------------^^^^^^^^^^^^^^^^^^^^^^^^^^^ - | | - | inside call to `read_field3` - | - = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) - -error: aborting due to 3 previous errors +error: aborting due to previous error -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/unused-broken-const.rs b/src/test/ui/consts/const-eval/unused-broken-const.rs new file mode 100644 index 00000000000..53ce82f8e87 --- /dev/null +++ b/src/test/ui/consts/const-eval/unused-broken-const.rs @@ -0,0 +1,18 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// make sure that an *unused* broken const triggers an error even in a check build + +// compile-flags: --emit=dep-info,metadata + +const FOO: i32 = [][0]; +//~^ ERROR any use of this value will cause an error + +fn main() {} diff --git a/src/test/ui/consts/const-eval/unused-broken-const.stderr b/src/test/ui/consts/const-eval/unused-broken-const.stderr new file mode 100644 index 00000000000..5fb2a3722e2 --- /dev/null +++ b/src/test/ui/consts/const-eval/unused-broken-const.stderr @@ -0,0 +1,14 @@ +warning: due to multiple output types requested, the explicitly specified output file name will be adapted for each output type + +error: any use of this value will cause an error + --> $DIR/unused-broken-const.rs:15:1 + | +LL | const FOO: i32 = [][0]; + | ^^^^^^^^^^^^^^^^^-----^ + | | + | index out of bounds: the len is 0 but the index is 0 + | + = note: #[deny(const_err)] on by default + +error: aborting due to previous error + diff --git a/src/test/ui/consts/const-slice-oob.rs b/src/test/ui/consts/const-slice-oob.rs index cc7f86f97a1..04d9b01633b 100644 --- a/src/test/ui/consts/const-slice-oob.rs +++ b/src/test/ui/consts/const-slice-oob.rs @@ -17,5 +17,4 @@ const BAR: u32 = FOO[5]; fn main() { let _ = BAR; - //~^ ERROR erroneous constant used } diff --git a/src/test/ui/consts/const-slice-oob.stderr b/src/test/ui/consts/const-slice-oob.stderr index 763afae62ea..4a8ad5ed6ca 100644 --- a/src/test/ui/consts/const-slice-oob.stderr +++ b/src/test/ui/consts/const-slice-oob.stderr @@ -8,12 +8,5 @@ LL | const BAR: u32 = FOO[5]; | = note: #[deny(const_err)] on by default -error[E0080]: erroneous constant used - --> $DIR/const-slice-oob.rs:19:13 - | -LL | let _ = BAR; - | ^^^ referenced constant has errors - -error: aborting due to 2 previous errors +error: aborting due to previous error -For more information about this error, try `rustc --explain E0080`. -- cgit 1.4.1-3-g733a5 From 1c5ff292fcaac24ae2bab9d24fc70e34b112cbbe Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Mon, 1 Oct 2018 12:52:47 +0200 Subject: Rebase fallout --- src/librustc_lint/builtin.rs | 43 ------------------- src/librustc_mir/const_eval.rs | 13 +++--- src/test/compile-fail/const-fn-error.rs | 2 +- src/test/compile-fail/issue-52443.rs | 1 - src/test/ui/consts/const-call.stderr | 8 +--- .../conditional_array_execution.nll.stderr | 29 ------------- .../ui/consts/const-eval/issue-43197.nll.stderr | 43 ------------------- src/test/ui/consts/const-eval/issue-43197.stderr | 8 ++-- .../ui/consts/const-eval/issue-44578.nll.stderr | 15 ------- src/test/ui/consts/const-eval/issue-52442.stderr | 2 +- src/test/ui/consts/const-eval/issue-52443.stderr | 49 ---------------------- ...romoted_const_fn_fail_deny_const_err.nll.stderr | 14 +++++++ .../promoted_const_fn_fail_deny_const_err.stderr | 21 ++++------ .../ui/consts/const-eval/ref_to_int_match.stderr | 2 +- src/test/ui/consts/const-eval/transmute-const.rs | 2 +- src/test/ui/consts/const-eval/ub-nonnull.rs | 6 +-- src/test/ui/consts/const-eval/ub-nonnull.stderr | 6 +-- src/test/ui/consts/const-eval/ub-ref.rs | 10 ++--- src/test/ui/consts/const-eval/ub-ref.stderr | 10 ++--- src/test/ui/consts/const-eval/ub-uninhabit.rs | 6 +-- src/test/ui/consts/const-eval/ub-uninhabit.stderr | 6 +-- src/test/ui/consts/const-eval/ub-upvars.rs | 2 +- src/test/ui/consts/const-eval/ub-upvars.stderr | 4 +- src/test/ui/consts/const-eval/union-ice.rs | 2 +- src/test/ui/consts/const-eval/union-ice.stderr | 4 +- src/test/ui/consts/const-fn-error.stderr | 41 ------------------ .../ui/infinite/infinite-recursion-const-fn.stderr | 2 +- src/test/ui/issues/issue-39559-2.stderr | 14 +------ src/test/ui/issues/issue-43105.rs | 3 +- src/test/ui/issues/issue-43105.stderr | 18 +------- .../issue-52023-array-size-pointer-cast.stderr | 2 +- 31 files changed, 69 insertions(+), 319 deletions(-) delete mode 100644 src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr delete mode 100644 src/test/ui/consts/const-eval/issue-43197.nll.stderr delete mode 100644 src/test/ui/consts/const-eval/issue-44578.nll.stderr delete mode 100644 src/test/ui/consts/const-eval/issue-52443.stderr create mode 100644 src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.nll.stderr delete mode 100644 src/test/ui/consts/const-fn-error.stderr (limited to 'src/test') diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index c50f57e6c90..1632af6d3dd 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -1547,49 +1547,6 @@ impl LintPass for UnusedBrokenConst { lint_array!() } } - -fn validate_const<'a, 'tcx>( - tcx: ty::TyCtxt<'a, 'tcx, 'tcx>, - constant: &ty::Const<'tcx>, - param_env: ty::ParamEnv<'tcx>, - gid: ::rustc::mir::interpret::GlobalId<'tcx>, - what: &str, -) { - let ecx = ::rustc_mir::const_eval::mk_eval_cx(tcx, gid.instance, param_env).unwrap(); - let result = (|| { - let op = ecx.const_to_op(constant)?; - let mut ref_tracking = ::rustc_mir::interpret::RefTracking::new(op); - while let Some((op, mut path)) = ref_tracking.todo.pop() { - ecx.validate_operand( - op, - &mut path, - Some(&mut ref_tracking), - /* const_mode */ true, - )?; - } - Ok(()) - })(); - if let Err(err) = result { - let (trace, span) = ecx.generate_stacktrace(None); - let err = ::rustc::mir::interpret::ConstEvalErr { - error: err, - stacktrace: trace, - span, - }; - let err = err.struct_error( - tcx.at(span), - &format!("this {} likely exhibits undefined behavior", what), - ); - if let Some(mut err) = err { - err.note("The rules on what exactly is undefined behavior aren't clear, \ - so this check might be overzealous. Please open an issue on the rust compiler \ - repository if you believe it should not be considered undefined behavior", - ); - err.emit(); - } - } -} - fn check_const(cx: &LateContext, body_id: hir::BodyId) { let def_id = cx.tcx.hir.body_owner_def_id(body_id); let is_static = cx.tcx.is_static(def_id).is_some(); diff --git a/src/librustc_mir/const_eval.rs b/src/librustc_mir/const_eval.rs index c501ef8eceb..830f2fb089a 100644 --- a/src/librustc_mir/const_eval.rs +++ b/src/librustc_mir/const_eval.rs @@ -24,7 +24,6 @@ use rustc::ty::{self, Ty, TyCtxt, Instance, query::TyCtxtAt}; use rustc::ty::layout::{self, Size, LayoutOf, TyLayout}; use rustc::ty::subst::Subst; use rustc::traits::Reveal; -use rustc::util::nodemap::FxHashSet; use rustc_data_structures::indexed_vec::IndexVec; use rustc_data_structures::fx::FxHashMap; use rustc::util::common::ErrorReported; @@ -36,7 +35,7 @@ use interpret::{self, PlaceTy, MemPlace, OpTy, Operand, Value, Pointer, Scalar, ConstValue, EvalResult, EvalError, EvalErrorKind, GlobalId, EvalContext, StackPopCleanup, Allocation, AllocId, MemoryKind, - snapshot, + snapshot, RefTracking, }; /// Number of steps until the detector even starts doing anything. @@ -542,15 +541,13 @@ fn validate_const<'a, 'tcx>( let ecx = mk_eval_cx(tcx, cid.instance, key.param_env).unwrap(); let val = (|| { let op = ecx.const_to_op(constant)?; - let mut todo = vec![(op, Vec::new())]; - let mut seen = FxHashSet(); - seen.insert(op); - while let Some((op, mut path)) = todo.pop() { + let mut ref_tracking = RefTracking::new(op); + while let Some((op, mut path)) = ref_tracking.todo.pop() { ecx.validate_operand( op, &mut path, - &mut seen, - &mut todo, + Some(&mut ref_tracking), + /* const_mode */ true, )?; } Ok(constant) diff --git a/src/test/compile-fail/const-fn-error.rs b/src/test/compile-fail/const-fn-error.rs index 0eee0b4c7b8..83f2735aa9d 100644 --- a/src/test/compile-fail/const-fn-error.rs +++ b/src/test/compile-fail/const-fn-error.rs @@ -16,7 +16,7 @@ const fn f(x: usize) -> usize { let mut sum = 0; //~^ let bindings in constant functions are unstable //~| statements in constant functions are unstable - for i in 0..x { //~ ERROR E0080 + for i in 0..x { //~^ ERROR E0015 //~| ERROR E0019 sum += i; diff --git a/src/test/compile-fail/issue-52443.rs b/src/test/compile-fail/issue-52443.rs index 1ed513033fd..fc42f87ccbf 100644 --- a/src/test/compile-fail/issue-52443.rs +++ b/src/test/compile-fail/issue-52443.rs @@ -14,5 +14,4 @@ fn main() { [(); {while true {break}; 0}]; //~ ERROR constant contains unimplemented expression type [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions //~^ ERROR constant contains unimplemented expression type - //~| ERROR evaluation of constant value failed } diff --git a/src/test/ui/consts/const-call.stderr b/src/test/ui/consts/const-call.stderr index e0427d0d04c..81be93e916e 100644 --- a/src/test/ui/consts/const-call.stderr +++ b/src/test/ui/consts/const-call.stderr @@ -4,12 +4,6 @@ error[E0015]: calls in constants are limited to constant functions, tuple struct LL | let _ = [0; f(2)]; | ^^^^ -error[E0080]: evaluation of constant value failed - --> $DIR/const-call.rs:16:17 - | -LL | let _ = [0; f(2)]; - | ^^^^ calling non-const fn `f` - -error: aborting due to 2 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0015`. diff --git a/src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr b/src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr deleted file mode 100644 index b6c35b8ebbd..00000000000 --- a/src/test/ui/consts/const-eval/conditional_array_execution.nll.stderr +++ /dev/null @@ -1,29 +0,0 @@ -warning: any use of this value will cause an error - --> $DIR/conditional_array_execution.rs:15:1 - | -LL | const FOO: u32 = [X - Y, Y - X][(X < Y) as usize]; - | ^^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^ - | | - | attempt to subtract with overflow - | -note: lint level defined here - --> $DIR/conditional_array_execution.rs:11:9 - | -LL | #![warn(const_err)] - | ^^^^^^^^^ - -error[E0080]: evaluation of constant expression failed - --> $DIR/conditional_array_execution.rs:19:14 - | -LL | println!("{}", FOO); - | ^^^^ --- referenced constant has errors - -error[E0080]: evaluation of constant expression failed - --> $DIR/conditional_array_execution.rs:19:20 - | -LL | println!("{}", FOO); - | ^^^ referenced constant has errors - -error: aborting due to 2 previous errors - -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/issue-43197.nll.stderr b/src/test/ui/consts/const-eval/issue-43197.nll.stderr deleted file mode 100644 index 86a86922d3b..00000000000 --- a/src/test/ui/consts/const-eval/issue-43197.nll.stderr +++ /dev/null @@ -1,43 +0,0 @@ -warning: any use of this value will cause an error - --> $DIR/issue-43197.rs:20:5 - | -LL | const X: u32 = 0-1; - | ^^^^^^^^^^^^^^^---^ - | | - | attempt to subtract with overflow - | -note: lint level defined here - --> $DIR/issue-43197.rs:11:9 - | -LL | #![warn(const_err)] - | ^^^^^^^^^ - -warning: any use of this value will cause an error - --> $DIR/issue-43197.rs:22:5 - | -LL | const Y: u32 = foo(0-1); - | ^^^^^^^^^^^^^^^^^^^---^^ - | | - | attempt to subtract with overflow - -error[E0080]: evaluation of constant expression failed - --> $DIR/issue-43197.rs:24:14 - | -LL | println!("{} {}", X, Y); - | ^^^^^^^ - referenced constant has errors - -error[E0080]: evaluation of constant expression failed - --> $DIR/issue-43197.rs:24:26 - | -LL | println!("{} {}", X, Y); - | ^ referenced constant has errors - -error[E0080]: evaluation of constant expression failed - --> $DIR/issue-43197.rs:24:23 - | -LL | println!("{} {}", X, Y); - | ^ referenced constant has errors - -error: aborting due to 3 previous errors - -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/issue-43197.stderr b/src/test/ui/consts/const-eval/issue-43197.stderr index 95d43581830..eaaebc5d75a 100644 --- a/src/test/ui/consts/const-eval/issue-43197.stderr +++ b/src/test/ui/consts/const-eval/issue-43197.stderr @@ -1,5 +1,5 @@ warning: any use of this value will cause an error - --> $DIR/issue-43197.rs:20:5 + --> $DIR/issue-43197.rs:18:5 | LL | const X: u32 = 0-1; | ^^^^^^^^^^^^^^^---^ @@ -13,7 +13,7 @@ LL | #![warn(const_err)] | ^^^^^^^^^ warning: any use of this value will cause an error - --> $DIR/issue-43197.rs:22:5 + --> $DIR/issue-43197.rs:20:5 | LL | const Y: u32 = foo(0-1); | ^^^^^^^^^^^^^^^^^^^---^^ @@ -21,13 +21,13 @@ LL | const Y: u32 = foo(0-1); | attempt to subtract with overflow error[E0080]: evaluation of constant expression failed - --> $DIR/issue-43197.rs:24:26 + --> $DIR/issue-43197.rs:22:26 | LL | println!("{} {}", X, Y); | ^ referenced constant has errors error[E0080]: evaluation of constant expression failed - --> $DIR/issue-43197.rs:24:23 + --> $DIR/issue-43197.rs:22:23 | LL | println!("{} {}", X, Y); | ^ referenced constant has errors diff --git a/src/test/ui/consts/const-eval/issue-44578.nll.stderr b/src/test/ui/consts/const-eval/issue-44578.nll.stderr deleted file mode 100644 index 71e06e36361..00000000000 --- a/src/test/ui/consts/const-eval/issue-44578.nll.stderr +++ /dev/null @@ -1,15 +0,0 @@ -error[E0080]: evaluation of constant expression failed - --> $DIR/issue-44578.rs:35:14 - | -LL | println!("{}", as Foo>::AMT); - | ^^^^ -------------------------- referenced constant has errors - -error[E0080]: evaluation of constant expression failed - --> $DIR/issue-44578.rs:35:20 - | -LL | println!("{}", as Foo>::AMT); - | ^^^^^^^^^^^^^^^^^^^^^^^^^^ referenced constant has errors - -error: aborting due to 2 previous errors - -For more information about this error, try `rustc --explain E0080`. diff --git a/src/test/ui/consts/const-eval/issue-52442.stderr b/src/test/ui/consts/const-eval/issue-52442.stderr index 93fc4bea5ca..3075be9e28b 100644 --- a/src/test/ui/consts/const-eval/issue-52442.stderr +++ b/src/test/ui/consts/const-eval/issue-52442.stderr @@ -8,7 +8,7 @@ error[E0080]: it is undefined behavior to use this value --> $DIR/issue-52442.rs:12:11 | LL | [(); { &loop { break } as *const _ as usize } ]; //~ ERROR unimplemented expression type - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected the type usize + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected initialized plain bits | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior diff --git a/src/test/ui/consts/const-eval/issue-52443.stderr b/src/test/ui/consts/const-eval/issue-52443.stderr deleted file mode 100644 index 807a70dd201..00000000000 --- a/src/test/ui/consts/const-eval/issue-52443.stderr +++ /dev/null @@ -1,49 +0,0 @@ -error[E0308]: mismatched types - --> $DIR/issue-52443.rs:12:10 - | -LL | [(); & { loop { continue } } ]; //~ ERROR mismatched types - | ^^^^^^^^^^^^^^^^^^^^^^^ - | | - | expected usize, found reference - | help: consider removing the borrow: `{ loop { continue } }` - | - = note: expected type `usize` - found type `&_` - -error[E0308]: mismatched types - --> $DIR/issue-52443.rs:13:17 - | -LL | [(); loop { break }]; //~ ERROR mismatched types - | ^^^^^ expected (), found usize - | - = note: expected type `()` - found type `usize` - -error[E0019]: constant contains unimplemented expression type - --> $DIR/issue-52443.rs:14:11 - | -LL | [(); {while true {break}; 0}]; //~ ERROR constant contains unimplemented expression type - | ^^^^^^^^^^^^^^^^^^ - -error[E0015]: calls in constants are limited to constant functions, tuple structs and tuple variants - --> $DIR/issue-52443.rs:15:21 - | -LL | [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions - | ^^^^^^^^ - -error[E0019]: constant contains unimplemented expression type - --> $DIR/issue-52443.rs:15:21 - | -LL | [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions - | ^^^^^^^^ - -error[E0080]: evaluation of constant value failed - --> $DIR/issue-52443.rs:15:21 - | -LL | [(); { for _ in 0usize.. {}; 0}]; //~ ERROR calls in constants are limited to constant functions - | ^^^^^^^^ calling non-const fn `>::into_iter` - -error: aborting due to 6 previous errors - -Some errors occurred: E0015, E0019, E0080, E0308. -For more information about an error, try `rustc --explain E0015`. diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.nll.stderr b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.nll.stderr new file mode 100644 index 00000000000..c6b3dd242e9 --- /dev/null +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.nll.stderr @@ -0,0 +1,14 @@ +error[E0716]: temporary value dropped while borrowed + --> $DIR/promoted_const_fn_fail_deny_const_err.rs:31:27 + | +LL | let x: &'static u8 = &(bar() + 1); + | ----------- ^^^^^^^^^^^ creates a temporary which is freed while still in use + | | + | type annotation requires that borrow lasts for `'static` +... +LL | } + | - temporary value is freed at the end of this statement + +error: aborting due to previous error + +For more information about this error, try `rustc --explain E0716`. diff --git a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr index c44acf9f1f8..728ff39f579 100644 --- a/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr +++ b/src/test/ui/consts/const-eval/promoted_const_fn_fail_deny_const_err.stderr @@ -1,19 +1,14 @@ -error: reaching this expression at runtime will panic or abort - --> $DIR/promoted_const_fn_fail_deny_const_err.rs:31:26 +error[E0597]: borrowed value does not live long enough + --> $DIR/promoted_const_fn_fail_deny_const_err.rs:31:27 | -LL | Bar { a: &42 }.b as u8 - | ---------------------- a raw memory access tried to access part of a pointer value as raw bytes -... LL | let x: &'static u8 = &(bar() + 1); - | ^^-----^^^^^ - | | - | inside call to `bar` - | -note: lint level defined here - --> $DIR/promoted_const_fn_fail_deny_const_err.rs:13:9 + | ^^^^^^^^^^^ temporary value does not live long enough +... +LL | } + | - temporary value only lives until here | -LL | #![deny(const_err)] - | ^^^^^^^^^ + = note: borrowed value must be valid for the static lifetime... error: aborting due to previous error +For more information about this error, try `rustc --explain E0597`. diff --git a/src/test/ui/consts/const-eval/ref_to_int_match.stderr b/src/test/ui/consts/const-eval/ref_to_int_match.stderr index 1e65a871de4..d55c1c2c70b 100644 --- a/src/test/ui/consts/const-eval/ref_to_int_match.stderr +++ b/src/test/ui/consts/const-eval/ref_to_int_match.stderr @@ -2,7 +2,7 @@ error[E0080]: it is undefined behavior to use this value --> $DIR/ref_to_int_match.rs:33:1 | LL | const BAR: Int = unsafe { Foo { r: &42 }.f }; //~ ERROR it is undefined behavior to use this value - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected the type u64 + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected initialized plain bits | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior diff --git a/src/test/ui/consts/const-eval/transmute-const.rs b/src/test/ui/consts/const-eval/transmute-const.rs index 477e7119ba9..1d0ac4c98f5 100644 --- a/src/test/ui/consts/const-eval/transmute-const.rs +++ b/src/test/ui/consts/const-eval/transmute-const.rs @@ -13,6 +13,6 @@ use std::mem; static FOO: bool = unsafe { mem::transmute(3u8) }; -//~^ ERROR this static likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value fn main() {} diff --git a/src/test/ui/consts/const-eval/ub-nonnull.rs b/src/test/ui/consts/const-eval/ub-nonnull.rs index 2b07eee3ccb..6d6ad38afdb 100644 --- a/src/test/ui/consts/const-eval/ub-nonnull.rs +++ b/src/test/ui/consts/const-eval/ub-nonnull.rs @@ -15,11 +15,11 @@ use std::ptr::NonNull; use std::num::{NonZeroU8, NonZeroUsize}; const NULL_PTR: NonNull = unsafe { mem::transmute(0usize) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const NULL_U8: NonZeroU8 = unsafe { mem::transmute(0u8) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const NULL_USIZE: NonZeroUsize = unsafe { mem::transmute(0usize) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value fn main() {} diff --git a/src/test/ui/consts/const-eval/ub-nonnull.stderr b/src/test/ui/consts/const-eval/ub-nonnull.stderr index 8d1ca885b5a..1fdea3f38d3 100644 --- a/src/test/ui/consts/const-eval/ub-nonnull.stderr +++ b/src/test/ui/consts/const-eval/ub-nonnull.stderr @@ -1,4 +1,4 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-nonnull.rs:17:1 | LL | const NULL_PTR: NonNull = unsafe { mem::transmute(0usize) }; @@ -6,7 +6,7 @@ LL | const NULL_PTR: NonNull = unsafe { mem::transmute(0usize) }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-nonnull.rs:20:1 | LL | const NULL_U8: NonZeroU8 = unsafe { mem::transmute(0u8) }; @@ -14,7 +14,7 @@ LL | const NULL_U8: NonZeroU8 = unsafe { mem::transmute(0u8) }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-nonnull.rs:22:1 | LL | const NULL_USIZE: NonZeroUsize = unsafe { mem::transmute(0usize) }; diff --git a/src/test/ui/consts/const-eval/ub-ref.rs b/src/test/ui/consts/const-eval/ub-ref.rs index 584dc069169..2c2abd91275 100644 --- a/src/test/ui/consts/const-eval/ub-ref.rs +++ b/src/test/ui/consts/const-eval/ub-ref.rs @@ -13,18 +13,18 @@ use std::mem; const UNALIGNED: &u16 = unsafe { mem::transmute(&[0u8; 4]) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const NULL: &u16 = unsafe { mem::transmute(0usize) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const REF_AS_USIZE: usize = unsafe { mem::transmute(&0) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const REF_AS_USIZE_SLICE: &[usize] = &[unsafe { mem::transmute(&0) }]; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const USIZE_AS_REF: &'static u8 = unsafe { mem::transmute(1337usize) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value fn main() {} diff --git a/src/test/ui/consts/const-eval/ub-ref.stderr b/src/test/ui/consts/const-eval/ub-ref.stderr index 8bcb6d190b8..4ae4640d074 100644 --- a/src/test/ui/consts/const-eval/ub-ref.stderr +++ b/src/test/ui/consts/const-eval/ub-ref.stderr @@ -1,4 +1,4 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-ref.rs:15:1 | LL | const UNALIGNED: &u16 = unsafe { mem::transmute(&[0u8; 4]) }; @@ -6,7 +6,7 @@ LL | const UNALIGNED: &u16 = unsafe { mem::transmute(&[0u8; 4]) }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-ref.rs:18:1 | LL | const NULL: &u16 = unsafe { mem::transmute(0usize) }; @@ -14,7 +14,7 @@ LL | const NULL: &u16 = unsafe { mem::transmute(0usize) }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-ref.rs:21:1 | LL | const REF_AS_USIZE: usize = unsafe { mem::transmute(&0) }; @@ -22,7 +22,7 @@ LL | const REF_AS_USIZE: usize = unsafe { mem::transmute(&0) }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-ref.rs:24:1 | LL | const REF_AS_USIZE_SLICE: &[usize] = &[unsafe { mem::transmute(&0) }]; @@ -30,7 +30,7 @@ LL | const REF_AS_USIZE_SLICE: &[usize] = &[unsafe { mem::transmute(&0) }]; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-ref.rs:27:1 | LL | const USIZE_AS_REF: &'static u8 = unsafe { mem::transmute(1337usize) }; diff --git a/src/test/ui/consts/const-eval/ub-uninhabit.rs b/src/test/ui/consts/const-eval/ub-uninhabit.rs index 99305beee52..22262fd0b97 100644 --- a/src/test/ui/consts/const-eval/ub-uninhabit.rs +++ b/src/test/ui/consts/const-eval/ub-uninhabit.rs @@ -16,13 +16,13 @@ use std::mem; enum Bar {} const BAD_BAD_BAD: Bar = unsafe { mem::transmute(()) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const BAD_BAD_REF: &Bar = unsafe { mem::transmute(1usize) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value const BAD_BAD_ARRAY: [Bar; 1] = unsafe { mem::transmute(()) }; -//~^ ERROR this constant likely exhibits undefined behavior +//~^ ERROR it is undefined behavior to use this value fn main() { } diff --git a/src/test/ui/consts/const-eval/ub-uninhabit.stderr b/src/test/ui/consts/const-eval/ub-uninhabit.stderr index 136d5f29199..2ac0a6e4e86 100644 --- a/src/test/ui/consts/const-eval/ub-uninhabit.stderr +++ b/src/test/ui/consts/const-eval/ub-uninhabit.stderr @@ -1,4 +1,4 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-uninhabit.rs:18:1 | LL | const BAD_BAD_BAD: Bar = unsafe { mem::transmute(()) }; @@ -6,7 +6,7 @@ LL | const BAD_BAD_BAD: Bar = unsafe { mem::transmute(()) }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-uninhabit.rs:21:1 | LL | const BAD_BAD_REF: &Bar = unsafe { mem::transmute(1usize) }; @@ -14,7 +14,7 @@ LL | const BAD_BAD_REF: &Bar = unsafe { mem::transmute(1usize) }; | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-uninhabit.rs:24:1 | LL | const BAD_BAD_ARRAY: [Bar; 1] = unsafe { mem::transmute(()) }; diff --git a/src/test/ui/consts/const-eval/ub-upvars.rs b/src/test/ui/consts/const-eval/ub-upvars.rs index 309211d19d4..f591a5affe5 100644 --- a/src/test/ui/consts/const-eval/ub-upvars.rs +++ b/src/test/ui/consts/const-eval/ub-upvars.rs @@ -12,7 +12,7 @@ use std::mem; -const BAD_UPVAR: &FnOnce() = &{ //~ ERROR this constant likely exhibits undefined behavior +const BAD_UPVAR: &FnOnce() = &{ //~ ERROR it is undefined behavior to use this value let bad_ref: &'static u16 = unsafe { mem::transmute(0usize) }; let another_var = 13; move || { let _ = bad_ref; let _ = another_var; } diff --git a/src/test/ui/consts/const-eval/ub-upvars.stderr b/src/test/ui/consts/const-eval/ub-upvars.stderr index 3ae140d6e1c..178f80f88e8 100644 --- a/src/test/ui/consts/const-eval/ub-upvars.stderr +++ b/src/test/ui/consts/const-eval/ub-upvars.stderr @@ -1,7 +1,7 @@ -error[E0080]: this constant likely exhibits undefined behavior +error[E0080]: it is undefined behavior to use this value --> $DIR/ub-upvars.rs:15:1 | -LL | / const BAD_UPVAR: &FnOnce() = &{ //~ ERROR this constant likely exhibits undefined behavior +LL | / const BAD_UPVAR: &FnOnce() = &{ //~ ERROR it is undefined behavior to use this value LL | | let bad_ref: &'static u16 = unsafe { mem::transmute(0usize) }; LL | | let another_var = 13; LL | | move || { let _ = bad_ref; let _ = another_var; } diff --git a/src/test/ui/consts/const-eval/union-ice.rs b/src/test/ui/consts/const-eval/union-ice.rs index 5a8ea711d86..0e4f1e09171 100644 --- a/src/test/ui/consts/const-eval/union-ice.rs +++ b/src/test/ui/consts/const-eval/union-ice.rs @@ -22,7 +22,7 @@ const UNION: DummyUnion = DummyUnion { field1: 1065353216 }; const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR will cause an error -const FIELD_PATH: Struct = Struct { //~ ERROR any use of this value will cause an error +const FIELD_PATH: Struct = Struct { //~ ERROR it is undefined behavior to use this value a: 42, b: unsafe { UNION.field3 }, }; diff --git a/src/test/ui/consts/const-eval/union-ice.stderr b/src/test/ui/consts/const-eval/union-ice.stderr index 7f5cb731c8e..d5a20640771 100644 --- a/src/test/ui/consts/const-eval/union-ice.stderr +++ b/src/test/ui/consts/const-eval/union-ice.stderr @@ -6,10 +6,10 @@ LL | const FIELD3: Field3 = unsafe { UNION.field3 }; //~ ERROR will cause an err | = note: #[deny(const_err)] on by default -error: any use of this value will cause an error +error[E0080]: it is undefined behavior to use this value --> $DIR/union-ice.rs:25:1 | -LL | / const FIELD_PATH: Struct = Struct { //~ ERROR any use of this value will cause an error +LL | / const FIELD_PATH: Struct = Struct { //~ ERROR it is undefined behavior to use this value LL | | a: 42, LL | | b: unsafe { UNION.field3 }, LL | | }; diff --git a/src/test/ui/consts/const-fn-error.stderr b/src/test/ui/consts/const-fn-error.stderr deleted file mode 100644 index a7b757f2d00..00000000000 --- a/src/test/ui/consts/const-fn-error.stderr +++ /dev/null @@ -1,41 +0,0 @@ -error[E0658]: let bindings in constant functions are unstable (see issue #48821) - --> $DIR/const-fn-error.rs:16:19 - | -LL | let mut sum = 0; - | ^ - | - = help: add #![feature(const_let)] to the crate attributes to enable - -error[E0658]: statements in constant functions are unstable (see issue #48821) - --> $DIR/const-fn-error.rs:16:19 - | -LL | let mut sum = 0; - | ^ - | - = help: add #![feature(const_let)] to the crate attributes to enable - -error[E0015]: calls in constant functions are limited to constant functions, tuple structs and tuple variants - --> $DIR/const-fn-error.rs:19:14 - | -LL | for i in 0..x { //~ ERROR E0080 - | ^^^^ - -error[E0019]: constant function contains unimplemented expression type - --> $DIR/const-fn-error.rs:19:14 - | -LL | for i in 0..x { //~ ERROR E0080 - | ^^^^ - -error[E0080]: evaluation of constant value failed - --> $DIR/const-fn-error.rs:19:14 - | -LL | for i in 0..x { //~ ERROR E0080 - | ^^^^ calling non-const fn `>::into_iter` -... -LL | let a : [i32; f(X)]; - | ---- inside call to `f` - -error: aborting due to 5 previous errors - -Some errors occurred: E0015, E0019, E0080, E0658. -For more information about an error, try `rustc --explain E0015`. diff --git a/src/test/ui/infinite/infinite-recursion-const-fn.stderr b/src/test/ui/infinite/infinite-recursion-const-fn.stderr index 82da89f1aa7..ef35bb6d98d 100644 --- a/src/test/ui/infinite/infinite-recursion-const-fn.stderr +++ b/src/test/ui/infinite/infinite-recursion-const-fn.stderr @@ -1,5 +1,5 @@ error[E0080]: evaluation of constant value failed - --> $DIR/infinite-recursion-const-fn.rs:14:25 + --> $DIR/infinite-recursion-const-fn.rs:13:25 | LL | const fn a() -> usize { b() } //~ ERROR evaluation of constant value failed | ^^^ diff --git a/src/test/ui/issues/issue-39559-2.stderr b/src/test/ui/issues/issue-39559-2.stderr index d7efcc52494..ca9da096b6c 100644 --- a/src/test/ui/issues/issue-39559-2.stderr +++ b/src/test/ui/issues/issue-39559-2.stderr @@ -4,24 +4,12 @@ error[E0015]: calls in constants are limited to constant functions, tuple struct LL | let array: [usize; Dim3::dim()] | ^^^^^^^^^^^ -error[E0080]: evaluation of constant value failed - --> $DIR/issue-39559-2.rs:24:24 - | -LL | let array: [usize; Dim3::dim()] - | ^^^^^^^^^^^ calling non-const fn `::dim` - error[E0015]: calls in constants are limited to constant functions, tuple structs and tuple variants --> $DIR/issue-39559-2.rs:26:15 | LL | = [0; Dim3::dim()]; | ^^^^^^^^^^^ -error[E0080]: evaluation of constant value failed - --> $DIR/issue-39559-2.rs:27:15 - | -LL | = [0; Dim3::dim()]; - | ^^^^^^^^^^^ calling non-const fn `::dim` - -error: aborting due to 4 previous errors +error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0015`. diff --git a/src/test/ui/issues/issue-43105.rs b/src/test/ui/issues/issue-43105.rs index 2b0eb685497..2bddc443d5b 100644 --- a/src/test/ui/issues/issue-43105.rs +++ b/src/test/ui/issues/issue-43105.rs @@ -12,11 +12,10 @@ fn xyz() -> u8 { 42 } const NUM: u8 = xyz(); //~^ ERROR calls in constants are limited to constant functions, tuple structs and tuple variants -//~| ERROR any use of this value will cause an error fn main() { match 1 { - NUM => unimplemented!(), //~ ERROR could not evaluate constant pattern + NUM => unimplemented!(), _ => unimplemented!(), } } diff --git a/src/test/ui/issues/issue-43105.stderr b/src/test/ui/issues/issue-43105.stderr index aba8351186b..67a6008cd8e 100644 --- a/src/test/ui/issues/issue-43105.stderr +++ b/src/test/ui/issues/issue-43105.stderr @@ -4,22 +4,6 @@ error[E0015]: calls in constants are limited to constant functions, tuple struct LL | const NUM: u8 = xyz(); | ^^^^^ -error: any use of this value will cause an error - --> $DIR/issue-43105.rs:13:1 - | -LL | const NUM: u8 = xyz(); - | ^^^^^^^^^^^^^^^^-----^ - | | - | calling non-const fn `xyz` - | - = note: #[deny(const_err)] on by default - -error: could not evaluate constant pattern - --> $DIR/issue-43105.rs:19:9 - | -LL | NUM => unimplemented!(), //~ ERROR could not evaluate constant pattern - | ^^^ - -error: aborting due to 3 previous errors +error: aborting due to previous error For more information about this error, try `rustc --explain E0015`. diff --git a/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr b/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr index ba415d43a75..03de0efd073 100644 --- a/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr +++ b/src/test/ui/issues/issue-52023-array-size-pointer-cast.stderr @@ -10,7 +10,7 @@ error[E0080]: it is undefined behavior to use this value --> $DIR/issue-52023-array-size-pointer-cast.rs:12:17 | LL | let _ = [0; (&0 as *const i32) as usize]; //~ ERROR casting pointers to integers in constants - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected the type usize + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a pointer, but expected initialized plain bits | = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rust compiler repository if you believe it should not be considered undefined behavior -- cgit 1.4.1-3-g733a5