From 7342325dfbd2560ebfd1b95073a20dfc56bd0298 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Tue, 10 Sep 2019 09:28:47 -0700 Subject: Add `#![deny(warnings)]` to internal tools --- src/tools/build-manifest/src/main.rs | 2 ++ src/tools/cargotest/main.rs | 2 ++ src/tools/compiletest/src/main.rs | 1 + src/tools/error_index_generator/main.rs | 1 + src/tools/linkchecker/main.rs | 2 ++ src/tools/remote-test-client/src/main.rs | 14 ++++++++------ src/tools/remote-test-server/src/main.rs | 24 +++++++++++++----------- src/tools/tidy/src/main.rs | 2 ++ src/tools/unstable-book-gen/src/main.rs | 2 ++ 9 files changed, 33 insertions(+), 17 deletions(-) (limited to 'src/tools') diff --git a/src/tools/build-manifest/src/main.rs b/src/tools/build-manifest/src/main.rs index eab23f3cfff..f41e7dd17ed 100644 --- a/src/tools/build-manifest/src/main.rs +++ b/src/tools/build-manifest/src/main.rs @@ -4,6 +4,8 @@ //! via `x.py dist hash-and-sign`; the cmdline arguments are set up //! by rustbuild (in `src/bootstrap/dist.rs`). +#![deny(warnings)] + use toml; use serde::Serialize; diff --git a/src/tools/cargotest/main.rs b/src/tools/cargotest/main.rs index f6aaaa5c6ea..1a42e0cac3c 100644 --- a/src/tools/cargotest/main.rs +++ b/src/tools/cargotest/main.rs @@ -1,3 +1,5 @@ +#![deny(warnings)] + use std::env; use std::process::Command; use std::path::{Path, PathBuf}; diff --git a/src/tools/compiletest/src/main.rs b/src/tools/compiletest/src/main.rs index 7c51de5df22..34435819a2c 100644 --- a/src/tools/compiletest/src/main.rs +++ b/src/tools/compiletest/src/main.rs @@ -1,6 +1,7 @@ #![crate_name = "compiletest"] #![feature(test)] #![feature(vec_remove_item)] +#![deny(warnings)] extern crate test; diff --git a/src/tools/error_index_generator/main.rs b/src/tools/error_index_generator/main.rs index c4826a0c31d..31a802706cb 100644 --- a/src/tools/error_index_generator/main.rs +++ b/src/tools/error_index_generator/main.rs @@ -1,4 +1,5 @@ #![feature(rustc_private)] +#![deny(warnings)] extern crate env_logger; extern crate syntax; diff --git a/src/tools/linkchecker/main.rs b/src/tools/linkchecker/main.rs index 49c149afe17..e8a7252cb76 100644 --- a/src/tools/linkchecker/main.rs +++ b/src/tools/linkchecker/main.rs @@ -14,6 +14,8 @@ //! A few whitelisted exceptions are allowed as there's known bugs in rustdoc, //! but this should catch the majority of "broken link" cases. +#![deny(warnings)] + use std::collections::hash_map::Entry; use std::collections::{HashMap, HashSet}; use std::env; diff --git a/src/tools/remote-test-client/src/main.rs b/src/tools/remote-test-client/src/main.rs index a1d52251263..d7f031a6150 100644 --- a/src/tools/remote-test-client/src/main.rs +++ b/src/tools/remote-test-client/src/main.rs @@ -1,9 +1,11 @@ -/// This is a small client program intended to pair with `remote-test-server` in -/// this repository. This client connects to the server over TCP and is used to -/// push artifacts and run tests on the server instead of locally. -/// -/// Here is also where we bake in the support to spawn the QEMU emulator as -/// well. +//! This is a small client program intended to pair with `remote-test-server` in +//! this repository. This client connects to the server over TCP and is used to +//! push artifacts and run tests on the server instead of locally. +//! +//! Here is also where we bake in the support to spawn the QEMU emulator as +//! well. + +#![deny(warnings)] use std::env; use std::fs::{self, File}; diff --git a/src/tools/remote-test-server/src/main.rs b/src/tools/remote-test-server/src/main.rs index d2238730196..0462b719b7b 100644 --- a/src/tools/remote-test-server/src/main.rs +++ b/src/tools/remote-test-server/src/main.rs @@ -1,14 +1,16 @@ -/// This is a small server which is intended to run inside of an emulator or -/// on a remote test device. This server pairs with the `remote-test-client` -/// program in this repository. The `remote-test-client` connects to this -/// server over a TCP socket and performs work such as: -/// -/// 1. Pushing shared libraries to the server -/// 2. Running tests through the server -/// -/// The server supports running tests concurrently and also supports tests -/// themselves having support libraries. All data over the TCP sockets is in a -/// basically custom format suiting our needs. +//! This is a small server which is intended to run inside of an emulator or +//! on a remote test device. This server pairs with the `remote-test-client` +//! program in this repository. The `remote-test-client` connects to this +//! server over a TCP socket and performs work such as: +//! +//! 1. Pushing shared libraries to the server +//! 2. Running tests through the server +//! +//! The server supports running tests concurrently and also supports tests +//! themselves having support libraries. All data over the TCP sockets is in a +//! basically custom format suiting our needs. + +#![deny(warnings)] use std::cmp; use std::env; diff --git a/src/tools/tidy/src/main.rs b/src/tools/tidy/src/main.rs index 5deac52f08b..a57238ad814 100644 --- a/src/tools/tidy/src/main.rs +++ b/src/tools/tidy/src/main.rs @@ -4,6 +4,8 @@ //! etc. This is run by default on `make check` and as part of the auto //! builders. +#![deny(warnings)] + use tidy::*; use std::process; diff --git a/src/tools/unstable-book-gen/src/main.rs b/src/tools/unstable-book-gen/src/main.rs index 036349ea1c8..fdb0b6d3e56 100644 --- a/src/tools/unstable-book-gen/src/main.rs +++ b/src/tools/unstable-book-gen/src/main.rs @@ -1,5 +1,7 @@ //! Auto-generate stub docs for the unstable book +#![deny(warnings)] + use tidy::features::{Feature, Features, collect_lib_features, collect_lang_features}; use tidy::unstable_book::{collect_unstable_feature_names, collect_unstable_book_section_file_names, PATH_STR, LANG_FEATURES_DIR, LIB_FEATURES_DIR}; -- cgit 1.4.1-3-g733a5 From b92330691378199f14facf4776c197826b9d0fab Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Wed, 18 Sep 2019 12:34:19 -0700 Subject: Remove `--enable-extended` from cross dist builder Shouldn't have an effect on produced artifacts and otherwise is causing issues where `-Zsave-analysis` is passed during tests but fails compilation. --- Cargo.lock | 1 - src/ci/docker/dist-i586-gnu-i586-i686-musl/Dockerfile | 1 - src/tools/cargo | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) (limited to 'src/tools') diff --git a/Cargo.lock b/Cargo.lock index fa749e5e3ae..5bc1938fee2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -597,7 +597,6 @@ version = "0.28.0" dependencies = [ "curl", "failure", - "http", "percent-encoding 2.0.0", "serde", "serde_derive", diff --git a/src/ci/docker/dist-i586-gnu-i586-i686-musl/Dockerfile b/src/ci/docker/dist-i586-gnu-i586-i686-musl/Dockerfile index ba2d32a9296..61c363fbfd6 100644 --- a/src/ci/docker/dist-i586-gnu-i586-i686-musl/Dockerfile +++ b/src/ci/docker/dist-i586-gnu-i586-i686-musl/Dockerfile @@ -32,7 +32,6 @@ RUN sh /scripts/sccache.sh ENV RUST_CONFIGURE_ARGS \ --musl-root-i586=/musl-i586 \ --musl-root-i686=/musl-i686 \ - --enable-extended \ --disable-docs # Newer binutils broke things on some vms/distros (i.e., linking against diff --git a/src/tools/cargo b/src/tools/cargo index 3596cb86b2e..b6c6f685b38 160000 --- a/src/tools/cargo +++ b/src/tools/cargo @@ -1 +1 @@ -Subproject commit 3596cb86b2e87dd9b9c1bb90d4a9d73ec2c1512f +Subproject commit b6c6f685b38d523580813b0031677c2298f458ea -- cgit 1.4.1-3-g733a5