From 8f55152f8480e40ff08486f5b107dd3a149b6b14 Mon Sep 17 00:00:00 2001 From: Oliver Schneider Date: Mon, 28 May 2018 13:34:29 +0200 Subject: Did you mean to block nightlies on clippy? --- src/tools/build-manifest/src/main.rs | 22 ++++++++++++++++++++++ src/tools/clippy | 2 +- 2 files changed, 23 insertions(+), 1 deletion(-) (limited to 'src/tools') diff --git a/src/tools/build-manifest/src/main.rs b/src/tools/build-manifest/src/main.rs index 35fc2182313..92c4545429f 100644 --- a/src/tools/build-manifest/src/main.rs +++ b/src/tools/build-manifest/src/main.rs @@ -183,6 +183,7 @@ struct Builder { rust_release: String, cargo_release: String, rls_release: String, + clippy_release: String, rustfmt_release: String, llvm_tools_release: String, @@ -196,12 +197,14 @@ struct Builder { rust_version: Option, cargo_version: Option, rls_version: Option, + clippy_version: Option, rustfmt_version: Option, llvm_tools_version: Option, rust_git_commit_hash: Option, cargo_git_commit_hash: Option, rls_git_commit_hash: Option, + clippy_git_commit_hash: Option, rustfmt_git_commit_hash: Option, llvm_tools_git_commit_hash: Option, } @@ -214,6 +217,7 @@ fn main() { let rust_release = args.next().unwrap(); let cargo_release = args.next().unwrap(); let rls_release = args.next().unwrap(); + let clippy_release = args.next().unwrap(); let rustfmt_release = args.next().unwrap(); let llvm_tools_release = args.next().unwrap(); let s3_address = args.next().unwrap(); @@ -224,6 +228,7 @@ fn main() { rust_release, cargo_release, rls_release, + clippy_release, rustfmt_release, llvm_tools_release, @@ -237,12 +242,14 @@ fn main() { rust_version: None, cargo_version: None, rls_version: None, + clippy_version: None, rustfmt_version: None, llvm_tools_version: None, rust_git_commit_hash: None, cargo_git_commit_hash: None, rls_git_commit_hash: None, + clippy_git_commit_hash: None, rustfmt_git_commit_hash: None, llvm_tools_git_commit_hash: None, }.build(); @@ -259,6 +266,7 @@ impl Builder { self.rust_git_commit_hash = self.git_commit_hash("rust", "x86_64-unknown-linux-gnu"); self.cargo_git_commit_hash = self.git_commit_hash("cargo", "x86_64-unknown-linux-gnu"); self.rls_git_commit_hash = self.git_commit_hash("rls", "x86_64-unknown-linux-gnu"); + self.clippy_git_commit_hash = self.git_commit_hash("clippy", "x86_64-unknown-linux-gnu"); self.rustfmt_git_commit_hash = self.git_commit_hash("rustfmt", "x86_64-unknown-linux-gnu"); self.llvm_tools_git_commit_hash = self.git_commit_hash("llvm-tools", "x86_64-unknown-linux-gnu"); @@ -296,10 +304,12 @@ impl Builder { self.package("rust-docs", &mut manifest.pkg, TARGETS); self.package("rust-src", &mut manifest.pkg, &["*"]); self.package("rls-preview", &mut manifest.pkg, HOSTS); + self.package("clippy-preview", &mut manifest.pkg, HOSTS); self.package("rustfmt-preview", &mut manifest.pkg, HOSTS); self.package("rust-analysis", &mut manifest.pkg, TARGETS); self.package("llvm-tools", &mut manifest.pkg, TARGETS); + let clippy_present = manifest.pkg.contains_key("clippy-preview"); let rls_present = manifest.pkg.contains_key("rls-preview"); let rustfmt_present = manifest.pkg.contains_key("rustfmt-preview"); let llvm_tools_present = manifest.pkg.contains_key("llvm-tools"); @@ -345,6 +355,12 @@ impl Builder { }); } + if clippy_present { + extensions.push(Component { + pkg: "clippy-preview".to_string(), + target: host.to_string(), + }); + } if rls_present { extensions.push(Component { pkg: "rls-preview".to_string(), @@ -470,6 +486,8 @@ impl Builder { format!("cargo-{}-{}.tar.gz", self.cargo_release, target) } else if component == "rls" || component == "rls-preview" { format!("rls-{}-{}.tar.gz", self.rls_release, target) + } else if component == "clippy" || component == "clippy-preview" { + format!("clippy-{}-{}.tar.gz", self.clippy_release, target) } else if component == "rustfmt" || component == "rustfmt-preview" { format!("rustfmt-{}-{}.tar.gz", self.rustfmt_release, target) } else if component == "llvm_tools" { @@ -484,6 +502,8 @@ impl Builder { &self.cargo_version } else if component == "rls" || component == "rls-preview" { &self.rls_version + } else if component == "clippy" || component == "clippy-preview" { + &self.clippy_version } else if component == "rustfmt" || component == "rustfmt-preview" { &self.rustfmt_version } else if component == "llvm-tools" { @@ -498,6 +518,8 @@ impl Builder { &self.cargo_git_commit_hash } else if component == "rls" || component == "rls-preview" { &self.rls_git_commit_hash + } else if component == "clippy" || component == "clippy-preview" { + &self.clippy_git_commit_hash } else if component == "rustfmt" || component == "rustfmt-preview" { &self.rustfmt_git_commit_hash } else if component == "llvm-tools" { diff --git a/src/tools/clippy b/src/tools/clippy index ebe0b0eed59..b4b6e6558e3 160000 --- a/src/tools/clippy +++ b/src/tools/clippy @@ -1 +1 @@ -Subproject commit ebe0b0eed596243a2839867363cb31d93f0b9754 +Subproject commit b4b6e6558e3ccd5ef11758297dc064acceb15ef2 -- cgit 1.4.1-3-g733a5