From dfcfaa4ec1dd8a5bda33874dc180509b74bb625f Mon Sep 17 00:00:00 2001 From: Simonas Kazlauskas Date: Fri, 23 Jul 2021 14:42:36 +0300 Subject: Do not pass through features without +/- prefix LLVM really dislikes this and will assert, saying something along the lines of: ``` rustc: llvm/lib/MC/MCSubtargetInfo.cpp:60: void ApplyFeatureFlag( llvm::FeatureBitset&, llvm::StringRef, llvm::ArrayRef ): Assertion `SubtargetFeatures::hasFlag(Feature) && "Feature flags should start with '+' or '-'"` failed. ``` --- src/test/ui/target-feature/missing-plusminus-2.rs | 6 ++++++ src/test/ui/target-feature/missing-plusminus-2.stderr | 6 ++++++ 2 files changed, 12 insertions(+) create mode 100644 src/test/ui/target-feature/missing-plusminus-2.rs create mode 100644 src/test/ui/target-feature/missing-plusminus-2.stderr (limited to 'src') diff --git a/src/test/ui/target-feature/missing-plusminus-2.rs b/src/test/ui/target-feature/missing-plusminus-2.rs new file mode 100644 index 00000000000..13168728902 --- /dev/null +++ b/src/test/ui/target-feature/missing-plusminus-2.rs @@ -0,0 +1,6 @@ +// compile-flags: -Ctarget-feature=rdrand --crate-type=rlib --target=x86_64-unknown-linux-gnu +// build-pass +// needs-llvm-components: x86 + +#![feature(no_core)] +#![no_core] diff --git a/src/test/ui/target-feature/missing-plusminus-2.stderr b/src/test/ui/target-feature/missing-plusminus-2.stderr new file mode 100644 index 00000000000..5ed2652a06d --- /dev/null +++ b/src/test/ui/target-feature/missing-plusminus-2.stderr @@ -0,0 +1,6 @@ +warning: unknown feature specified for `-Ctarget-feature`: `rdrand` + | + = note: features must begin with a `+` to enable or `-` to disable it + +warning: 1 warning emitted + -- cgit 1.4.1-3-g733a5