From 5c98737715f60ce180a3b607fd1b96c709f6807d Mon Sep 17 00:00:00 2001 From: Eric Holk Date: Fri, 13 May 2022 16:25:22 -0700 Subject: Drop tracking: handle invalid assignments better Previously this test case was crashing with an index out of bounds error deep in the call to `needs_drop`. We avoid this by detecting clearly invalid assignees in the `mutate` callback and ignoring these. --- .../ui/async-await/issue-73741-type-err-drop-tracking.rs | 14 ++++++++++++++ .../async-await/issue-73741-type-err-drop-tracking.stderr | 11 +++++++++++ 2 files changed, 25 insertions(+) create mode 100644 src/test/ui/async-await/issue-73741-type-err-drop-tracking.rs create mode 100644 src/test/ui/async-await/issue-73741-type-err-drop-tracking.stderr (limited to 'src') diff --git a/src/test/ui/async-await/issue-73741-type-err-drop-tracking.rs b/src/test/ui/async-await/issue-73741-type-err-drop-tracking.rs new file mode 100644 index 00000000000..c3423ad629f --- /dev/null +++ b/src/test/ui/async-await/issue-73741-type-err-drop-tracking.rs @@ -0,0 +1,14 @@ +// edition:2018 +// compile-flags: -Zdrop-tracking +// Regression test for issue #73741 +// Ensures that we don't emit spurious errors when +// a type error ocurrs in an `async fn` + +async fn weird() { + 1 = 2; //~ ERROR invalid left-hand side + + let mut loop_count = 0; + async {}.await +} + +fn main() {} diff --git a/src/test/ui/async-await/issue-73741-type-err-drop-tracking.stderr b/src/test/ui/async-await/issue-73741-type-err-drop-tracking.stderr new file mode 100644 index 00000000000..d4e3b6c3bf4 --- /dev/null +++ b/src/test/ui/async-await/issue-73741-type-err-drop-tracking.stderr @@ -0,0 +1,11 @@ +error[E0070]: invalid left-hand side of assignment + --> $DIR/issue-73741-type-err-drop-tracking.rs:8:7 + | +LL | 1 = 2; + | - ^ + | | + | cannot assign to this expression + +error: aborting due to previous error + +For more information about this error, try `rustc --explain E0070`. -- cgit 1.4.1-3-g733a5