1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
|
#![allow(
unused_mut,
clippy::from_iter_instead_of_collect,
clippy::get_first,
clippy::useless_vec,
clippy::out_of_bounds_indexing
)]
#![warn(clippy::unwrap_used)]
#![deny(clippy::get_unwrap)]
use std::collections::{BTreeMap, HashMap, VecDeque};
struct GetFalsePositive {
arr: [u32; 3],
}
impl GetFalsePositive {
fn get(&self, pos: usize) -> Option<&u32> {
self.arr.get(pos)
}
fn get_mut(&mut self, pos: usize) -> Option<&mut u32> {
self.arr.get_mut(pos)
}
}
fn main() {
let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);
let mut some_slice = &mut [0, 1, 2, 3];
let mut some_vec = vec![0, 1, 2, 3];
let mut some_vecdeque: VecDeque<_> = some_vec.iter().cloned().collect();
let mut some_hashmap: HashMap<u8, char> = HashMap::from_iter(vec![(1, 'a'), (2, 'b')]);
let mut some_btreemap: BTreeMap<u8, char> = BTreeMap::from_iter(vec![(1, 'a'), (2, 'b')]);
let mut false_positive = GetFalsePositive { arr: [0, 1, 2] };
{
// Test `get().unwrap()`
let _ = boxed_slice.get(1).unwrap();
//~^ get_unwrap
//~| unwrap_used
let _ = some_slice.get(0).unwrap();
//~^ get_unwrap
//~| unwrap_used
let _ = some_vec.get(0).unwrap();
//~^ get_unwrap
//~| unwrap_used
let _ = some_vecdeque.get(0).unwrap();
//~^ get_unwrap
//~| unwrap_used
let _ = some_hashmap.get(&1).unwrap();
//~^ get_unwrap
//~| unwrap_used
let _ = some_btreemap.get(&1).unwrap();
//~^ get_unwrap
//~| unwrap_used
#[allow(clippy::unwrap_used)]
let _ = false_positive.get(0).unwrap();
// Test with deref
let _: u8 = *boxed_slice.get(1).unwrap();
//~^ get_unwrap
//~| unwrap_used
}
{
// Test `get_mut().unwrap()`
*boxed_slice.get_mut(0).unwrap() = 1;
//~^ get_unwrap
//~| unwrap_used
*some_slice.get_mut(0).unwrap() = 1;
//~^ get_unwrap
//~| unwrap_used
*some_vec.get_mut(0).unwrap() = 1;
//~^ get_unwrap
//~| unwrap_used
*some_vecdeque.get_mut(0).unwrap() = 1;
//~^ get_unwrap
//~| unwrap_used
// Check false positives
#[allow(clippy::unwrap_used)]
{
*some_hashmap.get_mut(&1).unwrap() = 'b';
*some_btreemap.get_mut(&1).unwrap() = 'b';
*false_positive.get_mut(0).unwrap() = 1;
}
}
{
// Test `get().unwrap().foo()` and `get_mut().unwrap().bar()`
let _ = some_vec.get(0..1).unwrap().to_vec();
//~^ get_unwrap
//~| unwrap_used
let _ = some_vec.get_mut(0..1).unwrap().to_vec();
//~^ get_unwrap
//~| unwrap_used
}
}
mod issue9909 {
#![allow(clippy::identity_op, clippy::unwrap_used, dead_code)]
#[allow(unconditional_panic)]
fn reduced() {
let f = &[1, 2, 3];
// include a borrow in the suggestion, even if the argument is not just a numeric literal
let _x: &i32 = f.get(1 + 2).unwrap();
//~^ get_unwrap
// don't include a borrow here
let _x = f.get(1 + 2).unwrap().to_string();
//~^ get_unwrap
// don't include a borrow here
let _x = f.get(1 + 2).unwrap().abs();
//~^ get_unwrap
}
// original code:
fn linidx(row: usize, col: usize) -> usize {
row * 1 + col * 3
}
fn main_() {
let mut mat = [1.0f32, 5.0, 9.0, 2.0, 6.0, 10.0, 3.0, 7.0, 11.0, 4.0, 8.0, 12.0];
for i in 0..2 {
for j in i + 1..3 {
if mat[linidx(j, 3)] > mat[linidx(i, 3)] {
for k in 0..4 {
let (x, rest) = mat.split_at_mut(linidx(i, k) + 1);
let a = x.last_mut().unwrap();
let b = rest.get_mut(linidx(j, k) - linidx(i, k) - 1).unwrap();
//~^ get_unwrap
::std::mem::swap(a, b);
}
}
}
}
assert_eq!([9.0, 5.0, 1.0, 10.0, 6.0, 2.0, 11.0, 7.0, 3.0, 12.0, 8.0, 4.0], mat);
}
}
|
