1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
|
#![warn(clippy::while_let_loop)]
fn main() {
let y = Some(true);
loop {
if let Some(_x) = y {
let _v = 1;
} else {
break;
}
}
#[allow(clippy::never_loop)]
loop {
// no error, break is not in else clause
if let Some(_x) = y {
let _v = 1;
}
break;
}
loop {
match y {
Some(_x) => true,
None => break,
};
}
loop {
let x = match y {
Some(x) => x,
None => break,
};
let _x = x;
let _str = "foo";
}
loop {
let x = match y {
Some(x) => x,
None => break,
};
{
let _a = "bar";
};
{
let _b = "foobar";
}
}
loop {
// no error, else branch does something other than break
match y {
Some(_x) => true,
_ => {
let _z = 1;
break;
},
};
}
while let Some(x) = y {
// no error, obviously
println!("{}", x);
}
// #675, this used to have a wrong suggestion
loop {
let (e, l) = match "".split_whitespace().next() {
Some(word) => (word.is_empty(), word.len()),
None => break,
};
let _ = (e, l);
}
}
fn issue771() {
let mut a = 100;
let b = Some(true);
loop {
if a > 10 {
break;
}
match b {
Some(_) => a = 0,
None => break,
}
}
}
fn issue1017() {
let r: Result<u32, u32> = Ok(42);
let mut len = 1337;
loop {
match r {
Err(_) => len = 0,
Ok(length) => {
len = length;
break;
},
}
}
}
#[allow(clippy::never_loop)]
fn issue1948() {
// should not trigger clippy::while_let_loop lint because break passes an expression
let a = Some(10);
let b = loop {
if let Some(c) = a {
break Some(c);
} else {
break None;
}
};
}
|
