diff options
| author | Jacob Hoffman-Andrews <github@hoffman-andrews.com> | 2021-11-24 10:43:58 -0800 |
|---|---|---|
| committer | Jacob Hoffman-Andrews <github@hoffman-andrews.com> | 2021-11-24 10:46:55 -0800 |
| commit | 04cb0dc8a99c18676efeda83ca4605a0f649767e (patch) | |
| tree | 78755e59cf6942040bafabdd1b88e6c3301a94bb | |
| parent | c6a7ca196a707acd65e6cce1d337cd11786c59a5 (diff) | |
| download | rust-04cb0dc8a99c18676efeda83ca4605a0f649767e.tar.gz rust-04cb0dc8a99c18676efeda83ca4605a0f649767e.zip | |
Fix clicking on anchors inside summary tags.
| -rw-r--r-- | src/librustdoc/html/static/js/main.js | 2 | ||||
| -rw-r--r-- | src/test/rustdoc-gui/toggle-click-deadspace.goml | 4 |
2 files changed, 5 insertions, 1 deletions
diff --git a/src/librustdoc/html/static/js/main.js b/src/librustdoc/html/static/js/main.js index 32aa82195a9..c9fa72cbaab 100644 --- a/src/librustdoc/html/static/js/main.js +++ b/src/librustdoc/html/static/js/main.js @@ -888,7 +888,7 @@ function hideThemeButtonState() { onEachLazy(document.querySelectorAll(".rustdoc-toggle > summary:not(.hideme)"), function(el) { el.addEventListener("click", function(e) { - if (e.target.tagName != "SUMMARY") { + if (e.target.tagName != "SUMMARY" && e.target.tagName != "A") { e.preventDefault(); } }); diff --git a/src/test/rustdoc-gui/toggle-click-deadspace.goml b/src/test/rustdoc-gui/toggle-click-deadspace.goml index 6fcee65809d..7bc3c563157 100644 --- a/src/test/rustdoc-gui/toggle-click-deadspace.goml +++ b/src/test/rustdoc-gui/toggle-click-deadspace.goml @@ -6,3 +6,7 @@ click: "h4.code-header" // This is the position of "pub" in "pub fn a_method" assert-attribute: (".impl-items .rustdoc-toggle", {"open": ""}) click: ".impl-items .rustdoc-toggle summary::before" // This is the position of "[-]" next to that pub fn. assert-attribute-false: (".impl-items .rustdoc-toggle", {"open": ""}) + +// Click the "Trait" part of "impl Trait" and verify it navigates. +click: "#impl-Trait h3 a:first-of-type" +assert-text: (".fqn .in-band", "Trait lib2::Trait") |
