about summary refs log tree commit diff
diff options
context:
space:
mode:
authorErik Jensen <erikjensen@rkjnsn.net>2021-02-28 12:57:38 -0800
committerGitHub <noreply@github.com>2021-02-28 12:57:38 -0800
commit2616960be2493e1cdba95cc297bb2dbd520ad7c8 (patch)
tree51f6275c36d5f30b47ac07dace5150c98e30399d
parent573a697a6197abaad5a2d7208dbf1bbc77f4dcf3 (diff)
downloadrust-2616960be2493e1cdba95cc297bb2dbd520ad7c8.tar.gz
rust-2616960be2493e1cdba95cc297bb2dbd520ad7c8.zip
Clarify that SyncOnceCell::set blocks.
Reading the discussion of this feature, I gained the mistaken impression that neither `set` nor `get` blocked, and thus calling `get` immediately after `set` was not guaranteed to succeed. It turns out that `set` *does* block, guaranteeing that the cell contains a value once `set` returns. This change updates the documentation to state that explicitly.
-rw-r--r--library/std/src/lazy.rs5
1 files changed, 4 insertions, 1 deletions
diff --git a/library/std/src/lazy.rs b/library/std/src/lazy.rs
index aec2a2aa639..974851a8bd6 100644
--- a/library/std/src/lazy.rs
+++ b/library/std/src/lazy.rs
@@ -177,7 +177,10 @@ impl<T> SyncOnceCell<T> {
 
     /// Sets the contents of this cell to `value`.
     ///
-    /// Returns `Ok(())` if the cell's value was updated.
+    /// May block if another thread is currently attempting to initialize the cell. The cell is
+    /// guaranteed to contain a value when set returns, though not necessarily the one provided.
+    ///
+    /// Returns `Ok(())` if the cell's value was set by this call.
     ///
     /// # Examples
     ///