about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2013-11-08 04:36:12 -0800
committerbors <bors@rust-lang.org>2013-11-08 04:36:12 -0800
commit4ce7d573e822c1ef1d68e7797c878a6344655447 (patch)
tree7168391a9c1fd7df3e3018d3a406a51df3002452
parent35c3aaf5c5f843506a5771d2acdd6e9f7d573586 (diff)
parent09257df055ca0ca14c3c71b21d82cfa48c34c97f (diff)
downloadrust-4ce7d573e822c1ef1d68e7797c878a6344655447.tar.gz
rust-4ce7d573e822c1ef1d68e7797c878a6344655447.zip
auto merge of #10348 : ksh8281/rust/fix_android_timegm, r=yichoi
fix timegm bug on android
TZ restore not correctly before.
and it cause test case fail (time::tests::run_tests::test_convertions)

with @sammykim
-rw-r--r--src/rt/rust_builtin.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/rt/rust_builtin.cpp b/src/rt/rust_builtin.cpp
index 66c8407413b..b9c3851cc63 100644
--- a/src/rt/rust_builtin.cpp
+++ b/src/rt/rust_builtin.cpp
@@ -43,12 +43,15 @@ timegm(struct tm *tm)
     char *tz;
 
     tz = getenv("TZ");
+    if (tz)
+        tz = strdup(tz);
     setenv("TZ", "", 1);
     tzset();
     ret = mktime(tm);
-    if (tz)
+    if (tz) {
         setenv("TZ", tz, 1);
-    else
+        free(tz);
+    } else
         unsetenv("TZ");
     tzset();
     return ret;