about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRalf Jung <post@ralfj.de>2019-02-02 11:05:43 +0100
committerRalf Jung <post@ralfj.de>2019-02-02 11:05:43 +0100
commit6c67a7625fbd38b4b986981c553dc7eb5a7a4765 (patch)
tree1b3268b02fb4bc6c32ab7535d7819d29ff015b86
parentcbbf8a7ff932b599227b27d34e9b015374f5b37a (diff)
downloadrust-6c67a7625fbd38b4b986981c553dc7eb5a7a4765.tar.gz
rust-6c67a7625fbd38b4b986981c553dc7eb5a7a4765.zip
pre_exec: expand docs
-rw-r--r--src/libstd/sys/redox/ext/process.rs7
-rw-r--r--src/libstd/sys/unix/ext/process.rs7
2 files changed, 8 insertions, 6 deletions
diff --git a/src/libstd/sys/redox/ext/process.rs b/src/libstd/sys/redox/ext/process.rs
index 4e669bbb2d7..55824dc4c05 100644
--- a/src/libstd/sys/redox/ext/process.rs
+++ b/src/libstd/sys/redox/ext/process.rs
@@ -48,7 +48,8 @@ pub trait CommandExt {
     /// This also means that all resources such as file descriptors and
     /// memory-mapped regions got duplicated. It is your responsibility to make
     /// sure that the closure does not violate library invariants by making
-    /// invalid use of these duplicates.
+    /// invalid use of these duplicates.  Moreover, POSIX demands that you only
+    /// perform operations that are explicitly documented as async-signal-safe.
     ///
     /// When this closure is run, aspects such as the stdio file descriptors and
     /// working directory have successfully been changed, so output to these
@@ -60,8 +61,8 @@ pub trait CommandExt {
     /// Schedules a closure to be run just before the `exec` function is
     /// invoked.
     ///
-    /// This method should be unsafe, so it got deprecated in favor of the
-    /// unsafe [`pre_exec`].
+    /// This method is stable and usable, but it should be unsafe. To fix
+    /// that, it got deprecated in favor of the unsafe [`pre_exec`].
     ///
     /// [`pre_exec`]: #tymethod.pre_exec
     #[stable(feature = "process_exec", since = "1.15.0")]
diff --git a/src/libstd/sys/unix/ext/process.rs b/src/libstd/sys/unix/ext/process.rs
index da0507c6542..ac0abc761ff 100644
--- a/src/libstd/sys/unix/ext/process.rs
+++ b/src/libstd/sys/unix/ext/process.rs
@@ -48,7 +48,8 @@ pub trait CommandExt {
     /// This also means that all resources such as file descriptors and
     /// memory-mapped regions got duplicated. It is your responsibility to make
     /// sure that the closure does not violate library invariants by making
-    /// invalid use of these duplicates.
+    /// invalid use of these duplicates.  Moreover, POSIX demands that you only
+    /// perform operations that are explicitly documented as async-signal-safe.
     ///
     /// When this closure is run, aspects such as the stdio file descriptors and
     /// working directory have successfully been changed, so output to these
@@ -60,8 +61,8 @@ pub trait CommandExt {
     /// Schedules a closure to be run just before the `exec` function is
     /// invoked.
     ///
-    /// This method should be unsafe, so it got deprecated in favor of the
-    /// unsafe [`pre_exec`].
+    /// This method is stable and usable, but it should be unsafe. To fix
+    /// that, it got deprecated in favor of the unsafe [`pre_exec`].
     ///
     /// [`pre_exec`]: #tymethod.pre_exec
     #[stable(feature = "process_exec", since = "1.15.0")]