diff options
| author | Tamir Duberstein <tamird@gmail.com> | 2023-10-06 08:51:30 -0400 |
|---|---|---|
| committer | Tamir Duberstein <tamird@gmail.com> | 2023-10-06 08:53:23 -0400 |
| commit | 7654d4b39833bc6fc0b0bcd184a616ff6ac7d9bd (patch) | |
| tree | 980ee1f16421549ca36f7b8581eafab615cd5637 | |
| parent | d4ba2b4c7c938cf90c03a265cb31356537f608ad (diff) | |
| download | rust-7654d4b39833bc6fc0b0bcd184a616ff6ac7d9bd.tar.gz rust-7654d4b39833bc6fc0b0bcd184a616ff6ac7d9bd.zip | |
compiler: always use var_os("RUST_BACKTRACE")
There are 3 instances of var(...) and 3 instances of var_os(...); the latter avoids an appearance of unhandled error, so use it everywhere.
| -rw-r--r-- | compiler/rustc_codegen_cranelift/build_system/main.rs | 2 | ||||
| -rw-r--r-- | compiler/rustc_driver_impl/src/lib.rs | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/compiler/rustc_codegen_cranelift/build_system/main.rs b/compiler/rustc_codegen_cranelift/build_system/main.rs index 798ae9dbd50..e8cf486e966 100644 --- a/compiler/rustc_codegen_cranelift/build_system/main.rs +++ b/compiler/rustc_codegen_cranelift/build_system/main.rs @@ -55,7 +55,7 @@ enum CodegenBackend { } fn main() { - if env::var("RUST_BACKTRACE").is_err() { + if env::var_os("RUST_BACKTRACE").is_none() { env::set_var("RUST_BACKTRACE", "1"); } env::set_var("CG_CLIF_DISABLE_INCR_CACHE", "1"); diff --git a/compiler/rustc_driver_impl/src/lib.rs b/compiler/rustc_driver_impl/src/lib.rs index 65c7aed3f10..a52c5239ca9 100644 --- a/compiler/rustc_driver_impl/src/lib.rs +++ b/compiler/rustc_driver_impl/src/lib.rs @@ -1287,7 +1287,7 @@ pub fn ice_path() -> &'static Option<PathBuf> { if !rustc_feature::UnstableFeatures::from_environment(None).is_nightly_build() { return None; } - if let Ok("0") = std::env::var("RUST_BACKTRACE").as_deref() { + if let Some(s) = std::env::var_os("RUST_BACKTRACE") && s == "0" { return None; } let mut path = match std::env::var("RUSTC_ICE").as_deref() { @@ -1322,7 +1322,7 @@ pub fn install_ice_hook(bug_report_url: &'static str, extra_info: fn(&Handler)) // by the user. Compiler developers and other rustc users can // opt in to less-verbose backtraces by manually setting "RUST_BACKTRACE" // (e.g. `RUST_BACKTRACE=1`) - if std::env::var("RUST_BACKTRACE").is_err() { + if std::env::var_os("RUST_BACKTRACE").is_none() { std::env::set_var("RUST_BACKTRACE", "full"); } |
