about summary refs log tree commit diff
diff options
context:
space:
mode:
authorTakayuki Maeda <takoyaki0316@gmail.com>2022-09-07 03:59:47 +0900
committerTakayuki Maeda <takoyaki0316@gmail.com>2022-09-07 03:59:47 +0900
commit7ac124803f696b7e28d9fdae2f676093024de378 (patch)
treeec30f677efd9760f6048dae8a0392c7d308aa87b
parentb44197abb0b3ffe4908892e1e08ab1cd721ff3b9 (diff)
downloadrust-7ac124803f696b7e28d9fdae2f676093024de378.tar.gz
rust-7ac124803f696b7e28d9fdae2f676093024de378.zip
do not suggest a semicolon for a macro without `!`
-rw-r--r--compiler/rustc_parse/src/parser/expr.rs3
-rw-r--r--src/test/ui/parser/do-not-suggest-semicolon-before-array.rs (renamed from src/test/ui/parser/do-not-suggest-suggest-semicolon-before-array.rs)0
-rw-r--r--src/test/ui/parser/do-not-suggest-semicolon-before-array.stderr (renamed from src/test/ui/parser/do-not-suggest-suggest-semicolon-before-array.stderr)2
-rw-r--r--src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.rs3
-rw-r--r--src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.stderr8
-rw-r--r--src/test/ui/parser/suggest-semicolon-before-array.fixed (renamed from src/test/ui/parser/suggest-suggest-semicolon-before-array.fixed)0
-rw-r--r--src/test/ui/parser/suggest-semicolon-before-array.rs (renamed from src/test/ui/parser/suggest-suggest-semicolon-before-array.rs)0
-rw-r--r--src/test/ui/parser/suggest-semicolon-before-array.stderr (renamed from src/test/ui/parser/suggest-suggest-semicolon-before-array.stderr)2
8 files changed, 16 insertions, 2 deletions
diff --git a/compiler/rustc_parse/src/parser/expr.rs b/compiler/rustc_parse/src/parser/expr.rs
index d4828a20120..10cd353062e 100644
--- a/compiler/rustc_parse/src/parser/expr.rs
+++ b/compiler/rustc_parse/src/parser/expr.rs
@@ -1977,6 +1977,9 @@ impl<'a> Parser<'a> {
         open_delim_span: Span,
     ) -> PResult<'a, ()> {
         if self.token.kind == token::Comma {
+            if !self.sess.source_map().is_multiline(prev_span.until(self.token.span)) {
+                return Ok(());
+            }
             let mut snapshot = self.create_snapshot_for_diagnostic();
             snapshot.bump();
             match snapshot.parse_seq_to_before_end(
diff --git a/src/test/ui/parser/do-not-suggest-suggest-semicolon-before-array.rs b/src/test/ui/parser/do-not-suggest-semicolon-before-array.rs
index 7ebf3f6b0d8..7ebf3f6b0d8 100644
--- a/src/test/ui/parser/do-not-suggest-suggest-semicolon-before-array.rs
+++ b/src/test/ui/parser/do-not-suggest-semicolon-before-array.rs
diff --git a/src/test/ui/parser/do-not-suggest-suggest-semicolon-before-array.stderr b/src/test/ui/parser/do-not-suggest-semicolon-before-array.stderr
index d6e8db80329..a9dd526321f 100644
--- a/src/test/ui/parser/do-not-suggest-suggest-semicolon-before-array.stderr
+++ b/src/test/ui/parser/do-not-suggest-semicolon-before-array.stderr
@@ -1,5 +1,5 @@
 error: expected one of `.`, `?`, `]`, or an operator, found `,`
-  --> $DIR/do-not-suggest-suggest-semicolon-before-array.rs:5:5
+  --> $DIR/do-not-suggest-semicolon-before-array.rs:5:5
    |
 LL |     [1, 3)
    |     ^ ^ help: `]` may belong here
diff --git a/src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.rs b/src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.rs
new file mode 100644
index 00000000000..d6f7981813f
--- /dev/null
+++ b/src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.rs
@@ -0,0 +1,3 @@
+fn main() {
+    let _x = vec[1, 2, 3]; //~ ERROR expected one of `.`, `?`, `]`, or an operator
+}
diff --git a/src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.stderr b/src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.stderr
new file mode 100644
index 00000000000..2fe6a28eeb4
--- /dev/null
+++ b/src/test/ui/parser/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.stderr
@@ -0,0 +1,8 @@
+error: expected one of `.`, `?`, `]`, or an operator, found `,`
+  --> $DIR/do-not-suggest-semicolon-between-macro-without-exclamation-mark-and-array.rs:2:19
+   |
+LL |     let _x = vec[1, 2, 3];
+   |                   ^ expected one of `.`, `?`, `]`, or an operator
+
+error: aborting due to previous error
+
diff --git a/src/test/ui/parser/suggest-suggest-semicolon-before-array.fixed b/src/test/ui/parser/suggest-semicolon-before-array.fixed
index a06b58b2740..a06b58b2740 100644
--- a/src/test/ui/parser/suggest-suggest-semicolon-before-array.fixed
+++ b/src/test/ui/parser/suggest-semicolon-before-array.fixed
diff --git a/src/test/ui/parser/suggest-suggest-semicolon-before-array.rs b/src/test/ui/parser/suggest-semicolon-before-array.rs
index f601ca2aef5..f601ca2aef5 100644
--- a/src/test/ui/parser/suggest-suggest-semicolon-before-array.rs
+++ b/src/test/ui/parser/suggest-semicolon-before-array.rs
diff --git a/src/test/ui/parser/suggest-suggest-semicolon-before-array.stderr b/src/test/ui/parser/suggest-semicolon-before-array.stderr
index bf86b43554d..8a33321fbd5 100644
--- a/src/test/ui/parser/suggest-suggest-semicolon-before-array.stderr
+++ b/src/test/ui/parser/suggest-semicolon-before-array.stderr
@@ -1,5 +1,5 @@
 error: expected `;`, found `[`
-  --> $DIR/suggest-suggest-semicolon-before-array.rs:8:5
+  --> $DIR/suggest-semicolon-before-array.rs:8:5
    |
 LL |     [1, 3]
    |     ^