about summary refs log tree commit diff
diff options
context:
space:
mode:
authorPietro Albini <pietro@pietroalbini.org>2025-01-06 20:13:40 +0100
committerJosh Stone <jistone@redhat.com>2025-02-17 09:19:32 -0800
commit86193fa8a04bcbdeee9917c2a2d1e2ea7054c0a6 (patch)
tree42a5f1d2824e32a8a1804e03d7b68f274d875823
parentd5a78fbeaede3838588cefbcff83c7a68795a487 (diff)
downloadrust-86193fa8a04bcbdeee9917c2a2d1e2ea7054c0a6.tar.gz
rust-86193fa8a04bcbdeee9917c2a2d1e2ea7054c0a6.zip
Revert "force "HEAD" for non-CI and `git_upstream_merge_base` for CI environment"
This reverts commit 33ac202904e7820268b71b3280a7d2590378e3b9.

(cherry picked from commit 6287749471076a3065a5793cb0a1678324e768bb)
-rw-r--r--src/build_helper/src/git.rs16
1 files changed, 3 insertions, 13 deletions
diff --git a/src/build_helper/src/git.rs b/src/build_helper/src/git.rs
index 2aad5650fa8..1e28d552fe6 100644
--- a/src/build_helper/src/git.rs
+++ b/src/build_helper/src/git.rs
@@ -1,8 +1,6 @@
 use std::path::{Path, PathBuf};
 use std::process::{Command, Stdio};
 
-use crate::ci::CiEnv;
-
 pub struct GitConfig<'a> {
     pub git_repository: &'a str,
     pub nightly_branch: &'a str,
@@ -116,8 +114,8 @@ fn git_upstream_merge_base(
 
 /// Searches for the nearest merge commit in the repository that also exists upstream.
 ///
-/// It looks for the most recent commit made by the merge bot by matching the author's email
-/// address with the merge bot's email.
+/// If it fails to find the upstream remote, it then looks for the most recent commit made
+/// by the merge bot by matching the author's email address with the merge bot's email.
 pub fn get_closest_merge_commit(
     git_dir: Option<&Path>,
     config: &GitConfig<'_>,
@@ -129,15 +127,7 @@ pub fn get_closest_merge_commit(
         git.current_dir(git_dir);
     }
 
-    let merge_base = {
-        if CiEnv::is_ci() {
-            git_upstream_merge_base(config, git_dir).unwrap()
-        } else {
-            // For non-CI environments, ignore rust-lang/rust upstream as it usually gets
-            // outdated very quickly.
-            "HEAD".to_string()
-        }
-    };
+    let merge_base = git_upstream_merge_base(config, git_dir).unwrap_or_else(|_| "HEAD".into());
 
     git.args([
         "rev-list",