about summary refs log tree commit diff
diff options
context:
space:
mode:
authorTrevor Gross <tmgross@umich.edu>2025-05-28 19:59:16 +0000
committerTrevor Gross <tmgross@umich.edu>2025-05-29 15:38:10 +0000
commit8db9bd6a59c8c59b8d04ee647f071e81f79f6225 (patch)
treebfcca540dd36f7ae0834eec1fd68afaf35238155
parenta63f4826cf2ccceeedff5fb19ba0cbffc1ef5d65 (diff)
downloadrust-8db9bd6a59c8c59b8d04ee647f071e81f79f6225.tar.gz
rust-8db9bd6a59c8c59b8d04ee647f071e81f79f6225.zip
Remove the now-unneeded llvm-tools-preview
Since a working `nm` is no longer needed as part of CI, the rustup
component can be removed.
-rw-r--r--library/compiler-builtins/.github/workflows/main.yaml1
-rw-r--r--library/compiler-builtins/crates/symbol-check/src/main.rs2
2 files changed, 1 insertions, 2 deletions
diff --git a/library/compiler-builtins/.github/workflows/main.yaml b/library/compiler-builtins/.github/workflows/main.yaml
index d13dd6b0f64..567ad1205a5 100644
--- a/library/compiler-builtins/.github/workflows/main.yaml
+++ b/library/compiler-builtins/.github/workflows/main.yaml
@@ -119,7 +119,6 @@ jobs:
         rustup update "$channel" --no-self-update
         rustup default "$channel"
         rustup target add "${{ matrix.target }}"
-        rustup component add llvm-tools-preview
     - uses: taiki-e/install-action@nextest
     - uses: Swatinem/rust-cache@v2
       with:
diff --git a/library/compiler-builtins/crates/symbol-check/src/main.rs b/library/compiler-builtins/crates/symbol-check/src/main.rs
index 104505438cc..4e6417fdf95 100644
--- a/library/compiler-builtins/crates/symbol-check/src/main.rs
+++ b/library/compiler-builtins/crates/symbol-check/src/main.rs
@@ -84,7 +84,7 @@ fn exec_cargo_with_args(args: &[&str]) -> Vec<PathBuf> {
         }
     }
 
-    cmd.wait().expect("failed to wait on Cargo");
+    assert!(cmd.wait().expect("failed to wait on Cargo").success());
 
     assert!(!check_files.is_empty(), "no compiler_builtins rlibs found");
     println!("Collected the following rlibs to check: {check_files:#?}");