diff options
| author | Aaron Hill <aa1ronham@gmail.com> | 2018-12-14 21:02:33 -0500 |
|---|---|---|
| committer | Aaron Hill <aa1ronham@gmail.com> | 2018-12-14 21:33:25 -0500 |
| commit | a375410e1f8f95f13ed096ff937bf3c64f2ff905 (patch) | |
| tree | b07bb829df7dfdc7d7dd21a5680c620d0e14b4ea | |
| parent | 96d1334e567237b1507cd277938e7ae2de75ff51 (diff) | |
| download | rust-a375410e1f8f95f13ed096ff937bf3c64f2ff905.tar.gz rust-a375410e1f8f95f13ed096ff937bf3c64f2ff905.zip | |
Call poly_project_and_unify_type on types that contain inference types
Commit f57247c48cb59 (Ensure that Rusdoc discovers all necessary auto trait bounds) added a check to ensure that we only attempt to unify a projection predicatre with inference variables. However, the check it added was too strict - instead of checking that a type *contains* an inference variable (e.g. '&_', 'MyType<_>'), it required the type to *be* an inference variable (i.e. only '_' would match). This commit relaxes the check to use 'ty.has_infer_types', ensuring that we perform unification wherever possible. Fixes #56822
| -rw-r--r-- | src/librustc/traits/auto_trait.rs | 4 | ||||
| -rw-r--r-- | src/test/rustdoc/issue-56822.rs | 34 |
2 files changed, 36 insertions, 2 deletions
diff --git a/src/librustc/traits/auto_trait.rs b/src/librustc/traits/auto_trait.rs index fff77816e75..8c0a8646ad5 100644 --- a/src/librustc/traits/auto_trait.rs +++ b/src/librustc/traits/auto_trait.rs @@ -742,9 +742,9 @@ impl<'a, 'tcx> AutoTraitFinder<'a, 'tcx> { } // We can only call poly_project_and_unify_type when our predicate's - // Ty is an inference variable - otherwise, there won't be anything to + // Ty contains an inference variable - otherwise, there won't be anything to // unify - if p.ty().skip_binder().is_ty_infer() { + if p.ty().skip_binder().has_infer_types() { debug!("Projecting and unifying projection predicate {:?}", predicate); match poly_project_and_unify_type(select, &obligation.with(p.clone())) { diff --git a/src/test/rustdoc/issue-56822.rs b/src/test/rustdoc/issue-56822.rs new file mode 100644 index 00000000000..41aba1a007a --- /dev/null +++ b/src/test/rustdoc/issue-56822.rs @@ -0,0 +1,34 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or +// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license +// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +struct Wrapper<T>(T); + +trait MyTrait { + type Output; +} + +impl<'a, I, T: 'a> MyTrait for Wrapper<I> + where I: MyTrait<Output=&'a T> +{ + type Output = T; +} + +struct Inner<'a, T>(&'a T); + +impl<'a, T> MyTrait for Inner<'a, T> { + type Output = &'a T; +} + +// @has issue_56822/struct.Parser.html +// @has - '//*[@id="synthetic-implementations-list"]/*[@class="impl"]//*/code' "impl<'a> Send for \ +// Parser<'a>" +pub struct Parser<'a> { + field: <Wrapper<Inner<'a, u8>> as MyTrait>::Output +} |
