about summary refs log tree commit diff
diff options
context:
space:
mode:
authorStuart Cook <Zalathar@users.noreply.github.com>2025-08-18 15:31:09 +1000
committerGitHub <noreply@github.com>2025-08-18 15:31:09 +1000
commitb94842dcac322010d6ca4abf3baa68f702ec0706 (patch)
tree15a3ba2bb0e3a971b58abcdbc97bb30202358087
parent425a9c0a0e365c0b8c6cfd00c2ded83a73bed9a0 (diff)
parent970ac40300bc75de9f5ef2edf77e93be5bd0769d (diff)
downloadrust-b94842dcac322010d6ca4abf3baa68f702ec0706.tar.gz
rust-b94842dcac322010d6ca4abf3baa68f702ec0706.zip
Rollup merge of #144838 - Kivooeo:doc-subtype, r=notriddle
Fix outdated doc comment

This updates the documentation comment for `Type::is_doc_subtype_of` to more accurately describe its purpose as a subtyping check, rather than equality

fixes rust-lang/rust#138572

r? ````````````@tgross35````````````
-rw-r--r--src/librustdoc/clean/types.rs8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/librustdoc/clean/types.rs b/src/librustdoc/clean/types.rs
index 26b087feb16..46aaa0068de 100644
--- a/src/librustdoc/clean/types.rs
+++ b/src/librustdoc/clean/types.rs
@@ -1552,10 +1552,10 @@ impl Type {
         matches!(self, Type::Path { path: Path { res: Res::Def(DefKind::TyAlias, _), .. } })
     }
 
-    /// Check if two types are "the same" for documentation purposes.
+    /// Check if this type is a subtype of another type for documentation purposes.
     ///
     /// This is different from `Eq`, because it knows that things like
-    /// `Placeholder` are possible matches for everything.
+    /// `Infer` and generics have special subtyping rules.
     ///
     /// This relation is not commutative when generics are involved:
     ///
@@ -1566,8 +1566,8 @@ impl Type {
     /// let cache = Cache::new(false);
     /// let generic = Type::Generic(rustc_span::symbol::sym::Any);
     /// let unit = Type::Primitive(PrimitiveType::Unit);
-    /// assert!(!generic.is_same(&unit, &cache));
-    /// assert!(unit.is_same(&generic, &cache));
+    /// assert!(!generic.is_doc_subtype_of(&unit, &cache));
+    /// assert!(unit.is_doc_subtype_of(&generic, &cache));
     /// ```
     ///
     /// An owned type is also the same as its borrowed variants (this is commutative),