about summary refs log tree commit diff
diff options
context:
space:
mode:
authorCorey Richardson <corey@octayn.net>2013-12-30 17:07:19 -0500
committerCorey Richardson <corey@octayn.net>2014-01-05 21:36:53 -0500
commitcb6451c5afb081c626238172b9ae67e65709cdf0 (patch)
tree241344c0d10e97d78604a6059169efeedc69f574
parent4bca7fdf9bdd15a7d008d99dc1252d3c9ffd35be (diff)
downloadrust-cb6451c5afb081c626238172b9ae67e65709cdf0.tar.gz
rust-cb6451c5afb081c626238172b9ae67e65709cdf0.zip
Remove a fixme
I don't think it's relevant, a warning is more appropriate. Easier to just
maintain the order.

Closes #4681
-rw-r--r--src/libextra/getopts.rs4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/libextra/getopts.rs b/src/libextra/getopts.rs
index 5debc999192..78baa4f7ec8 100644
--- a/src/libextra/getopts.rs
+++ b/src/libextra/getopts.rs
@@ -1522,6 +1522,9 @@ mod tests {
             optmulti("l")
         ];
 
+        // short and verbose should always be in the same order. if they
+        // aren't the test will fail (and in mysterious ways)
+
         let verbose = ~[
             groups::reqopt("b", "banana", "Desc", "VAL"),
             groups::optopt("a", "apple", "Desc", "VAL"),
@@ -1533,7 +1536,6 @@ mod tests {
         let sample_args = ~[~"--kiwi", ~"15", ~"--apple", ~"1", ~"k",
                             ~"-p", ~"16", ~"l", ~"35"];
 
-        // FIXME #4681: sort options here?
         assert!(getopts(sample_args, short)
             == groups::getopts(sample_args, verbose));
     }