diff options
| author | León Orell Valerian Liehr <me@fmease.dev> | 2024-04-25 02:03:51 +0200 |
|---|---|---|
| committer | León Orell Valerian Liehr <me@fmease.dev> | 2024-04-30 22:27:19 +0200 |
| commit | dec1d16a9be532959cca38c68195a0d1f25f2e89 (patch) | |
| tree | db6542f5e0561e3e31b9ae527d06c0ee8dac37be | |
| parent | 9e739b723b822e7f11508f516370da5b298cab17 (diff) | |
| download | rust-dec1d16a9be532959cca38c68195a0d1f25f2e89.tar.gz rust-dec1d16a9be532959cca38c68195a0d1f25f2e89.zip | |
Give an item related to issue 27438 a more meaningful name
| -rw-r--r-- | compiler/rustc_data_structures/src/lib.rs | 4 | ||||
| -rw-r--r-- | compiler/rustc_middle/src/tests.rs | 14 |
2 files changed, 8 insertions, 10 deletions
diff --git a/compiler/rustc_data_structures/src/lib.rs b/compiler/rustc_data_structures/src/lib.rs index 495c1977df9..0c322939db9 100644 --- a/compiler/rustc_data_structures/src/lib.rs +++ b/compiler/rustc_data_structures/src/lib.rs @@ -144,9 +144,9 @@ pub fn make_display(f: impl Fn(&mut fmt::Formatter<'_>) -> fmt::Result) -> impl Printer { f } } -// See comments in compiler/rustc_middle/src/tests.rs +// See comment in compiler/rustc_middle/src/tests.rs and issue #27438. #[doc(hidden)] -pub fn __noop_fix_for_27438() {} +pub fn __noop_fix_for_windows_dllimport_issue() {} #[macro_export] macro_rules! external_bitflags_debug { diff --git a/compiler/rustc_middle/src/tests.rs b/compiler/rustc_middle/src/tests.rs index 0af75e6ff6c..6c2e5f63418 100644 --- a/compiler/rustc_middle/src/tests.rs +++ b/compiler/rustc_middle/src/tests.rs @@ -1,11 +1,9 @@ -// FIXME(#27438): right now the unit tests of rustc_middle don't refer to any actual -// functions generated in rustc_data_structures (all -// references are through generic functions), but statics are -// referenced from time to time. Due to this bug we won't -// actually correctly link in the statics unless we also -// reference a function, so be sure to reference a dummy -// function. +// FIXME(#27438): Right now, the unit tests of `rustc_middle` don't refer to any actual functions +// generated in `rustc_data_structures` (all references are through generic functions), +// but statics are referenced from time to time. Due to this Windows `dllimport` bug +// we won't actually correctly link in the statics unless we also reference a function, +// so be sure to reference a dummy function. #[test] fn noop() { - rustc_data_structures::__noop_fix_for_27438(); + rustc_data_structures::__noop_fix_for_windows_dllimport_issue(); } |