diff options
| author | Tim Chevalier <chevalier@alum.wellesley.edu> | 2013-01-31 19:34:46 -0800 |
|---|---|---|
| committer | Tim Chevalier <chevalier@alum.wellesley.edu> | 2013-01-31 19:34:46 -0800 |
| commit | e0281d991c7150a5cf1921e89a62e9427d0a6de6 (patch) | |
| tree | 719240277c86c8314a720140c5450dcabdbdd879 | |
| parent | 2de8e8f81a87492dd73688405000249d46897ba6 (diff) | |
| download | rust-e0281d991c7150a5cf1921e89a62e9427d0a6de6.tar.gz rust-e0281d991c7150a5cf1921e89a62e9427d0a6de6.zip | |
core: Stamp out XXXes (comments only)
| -rw-r--r-- | src/libcore/os.rs | 2 | ||||
| -rw-r--r-- | src/libcore/private/finally.rs | 4 | ||||
| -rw-r--r-- | src/libcore/private/global.rs | 2 | ||||
| -rw-r--r-- | src/libcore/private/weak_task.rs | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/src/libcore/os.rs b/src/libcore/os.rs index 1f1135ae871..760c08510e3 100644 --- a/src/libcore/os.rs +++ b/src/libcore/os.rs @@ -145,7 +145,7 @@ pub mod win32 { /* Accessing environment variables is not generally threadsafe. This uses a per-runtime lock to serialize access. -XXX: It would probably be appropriate to make this a real global +FIXME #4726: It would probably be appropriate to make this a real global */ fn with_env_lock<T>(f: &fn() -> T) -> T { use private::global::global_data_clone_create; diff --git a/src/libcore/private/finally.rs b/src/libcore/private/finally.rs index 66e23ff4336..6fd173f84aa 100644 --- a/src/libcore/private/finally.rs +++ b/src/libcore/private/finally.rs @@ -31,7 +31,7 @@ pub trait Finally<T> { } impl<T> &fn() -> T: Finally<T> { - // XXX: Should not require a mode here + // FIXME #4518: Should not require a mode here fn finally(&self, +dtor: &fn()) -> T { let _d = Finallyalizer { dtor: dtor @@ -88,7 +88,7 @@ fn test_retval() { #[test] fn test_compact() { - // XXX Should be able to use a fn item instead + // FIXME #4727: Should be able to use a fn item instead // of a closure for do_some_fallible_work, // but it's a type error. let do_some_fallible_work: &fn() = || { }; diff --git a/src/libcore/private/global.rs b/src/libcore/private/global.rs index f129022957c..eab3f8ee537 100644 --- a/src/libcore/private/global.rs +++ b/src/libcore/private/global.rs @@ -160,7 +160,7 @@ fn get_global_state() -> Exclusive<GlobalState> { const POISON: int = -1; - // XXX: Doing atomic_cxchg to initialize the global state + // FIXME #4728: Doing atomic_cxchg to initialize the global state // lazily, which wouldn't be necessary with a runtime written // in Rust let global_ptr = unsafe { rust_get_global_data_ptr() }; diff --git a/src/libcore/private/weak_task.rs b/src/libcore/private/weak_task.rs index 573a3e54b44..7a299d6f11b 100644 --- a/src/libcore/private/weak_task.rs +++ b/src/libcore/private/weak_task.rs @@ -30,7 +30,7 @@ use ops::Drop; type ShutdownMsg = (); -// XXX: This could be a PortOne but I've experienced bugginess +// FIXME #4729: This could be a PortOne but I've experienced bugginess // with oneshot pipes and try_send pub unsafe fn weaken_task(f: &fn(Port<ShutdownMsg>)) { let service = global_data_clone_create(global_data_key, |