diff options
| author | Adam Perry <lol@anp.lol> | 2020-07-26 09:53:24 -0700 |
|---|---|---|
| committer | Mark Rousskov <mark.simulacrum@gmail.com> | 2020-07-30 17:53:18 -0400 |
| commit | fcd1712627e21618228057396d3b62e039c21544 (patch) | |
| tree | 76270eea100819a9fee609bdd13f0f62145a6141 | |
| parent | c774981577f78f6422acd579ef865a3c06be5f25 (diff) | |
| download | rust-fcd1712627e21618228057396d3b62e039c21544.tar.gz rust-fcd1712627e21618228057396d3b62e039c21544.zip | |
Fix #[track_caller] shims for trait objects.
We were missing an Instance::resolve_for_fn_ptr in resolve_for_vtable. Closes #74764.
| -rw-r--r-- | src/librustc_middle/ty/instance.rs | 2 | ||||
| -rw-r--r-- | src/test/ui/rfc-2091-track-caller/tracked-trait-obj.rs | 25 |
2 files changed, 26 insertions, 1 deletions
diff --git a/src/librustc_middle/ty/instance.rs b/src/librustc_middle/ty/instance.rs index 1ce079821a2..b3083fa3b37 100644 --- a/src/librustc_middle/ty/instance.rs +++ b/src/librustc_middle/ty/instance.rs @@ -345,7 +345,7 @@ impl<'tcx> Instance<'tcx> { debug!(" => associated item with unsizeable self: Self"); Some(Instance { def: InstanceDef::VtableShim(def_id), substs }) } else { - Instance::resolve(tcx, param_env, def_id, substs).ok().flatten() + Instance::resolve_for_fn_ptr(tcx, param_env, def_id, substs) } } diff --git a/src/test/ui/rfc-2091-track-caller/tracked-trait-obj.rs b/src/test/ui/rfc-2091-track-caller/tracked-trait-obj.rs new file mode 100644 index 00000000000..e41b1d2dd48 --- /dev/null +++ b/src/test/ui/rfc-2091-track-caller/tracked-trait-obj.rs @@ -0,0 +1,25 @@ +// run-pass + +#![feature(track_caller)] + +trait Tracked { + #[track_caller] + fn handle(&self) { + let location = std::panic::Location::caller(); + assert_eq!(location.file(), file!()); + // we only call this via trait object, so the def site should *always* be returned + assert_eq!(location.line(), line!() - 4); + assert_eq!(location.column(), 5); + } +} + +impl Tracked for () {} +impl Tracked for u8 {} + +fn main() { + let tracked: &dyn Tracked = &5u8; + tracked.handle(); + + const TRACKED: &dyn Tracked = &(); + TRACKED.handle(); +} |
