about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRyan Prichard <ryan.prichard@gmail.com>2015-03-12 19:24:59 -0700
committerRyan Prichard <ryan.prichard@gmail.com>2015-03-13 16:46:45 -0700
commit00211ecfda53521ea6b6405beff1c490b04f3ce5 (patch)
treee29ed6c465cfb3357306fdd95fb3ce847b463b73
parent3e4be02b80a3dd27bce20870958fe0aef7e7336d (diff)
downloadrust-00211ecfda53521ea6b6405beff1c490b04f3ce5.tar.gz
rust-00211ecfda53521ea6b6405beff1c490b04f3ce5.zip
Avoid passing -L "" during cross-compilation.
LLVM_LIBDIR_<triple> is only defined for host triples, not target triples.

FWIW, the same is true for LLVM_STDCPP_RUSTFLAGS_<triple>, where we
explicitly define it as empty when --enable-llvm-static-stdcpp is not
specified, but it's still undefined for cross-compiled triples.
-rw-r--r--mk/main.mk1
-rw-r--r--mk/target.mk2
-rw-r--r--mk/tests.mk2
3 files changed, 3 insertions, 2 deletions
diff --git a/mk/main.mk b/mk/main.mk
index ad9d0d0ca5e..b9f2cf1cce8 100644
--- a/mk/main.mk
+++ b/mk/main.mk
@@ -290,6 +290,7 @@ LLVM_VERSION_$(1)=$$(shell "$$(LLVM_CONFIG_$(1))" --version)
 LLVM_BINDIR_$(1)=$$(shell "$$(LLVM_CONFIG_$(1))" --bindir)
 LLVM_INCDIR_$(1)=$$(shell "$$(LLVM_CONFIG_$(1))" --includedir)
 LLVM_LIBDIR_$(1)=$$(shell "$$(LLVM_CONFIG_$(1))" --libdir)
+LLVM_LIBDIR_RUSTFLAGS_$(1)=-L "$$(LLVM_LIBDIR_$(1))"
 LLVM_LIBS_$(1)=$$(shell "$$(LLVM_CONFIG_$(1))" --libs $$(LLVM_COMPONENTS))
 LLVM_LDFLAGS_$(1)=$$(shell "$$(LLVM_CONFIG_$(1))" --ldflags)
 # On FreeBSD, it may search wrong headers (that are for pre-installed LLVM),
diff --git a/mk/target.mk b/mk/target.mk
index 4182ec81a7e..0a41f363649 100644
--- a/mk/target.mk
+++ b/mk/target.mk
@@ -84,7 +84,7 @@ $$(TLIB$(1)_T_$(2)_H_$(3))/stamp.$(4): \
 	    $$(subst @,,$$(STAGE$(1)_T_$(2)_H_$(3))) \
 		$$(RUST_LIB_FLAGS_ST$(1)) \
 		-L "$$(RT_OUTPUT_DIR_$(2))" \
-		-L "$$(LLVM_LIBDIR_$(2))" \
+		$$(LLVM_LIBDIR_RUSTFLAGS_$(2)) \
 		$$(LLVM_STDCPP_RUSTFLAGS_$(2)) \
 		$$(RUSTFLAGS_$(4)) \
 		--out-dir $$(@D) \
diff --git a/mk/tests.mk b/mk/tests.mk
index 78f5ac11f06..48e50e47d4d 100644
--- a/mk/tests.mk
+++ b/mk/tests.mk
@@ -372,7 +372,7 @@ $(3)/stage$(1)/test/$(4)test-$(2)$$(X_$(2)): \
 	$(Q)CFG_LLVM_LINKAGE_FILE=$$(LLVM_LINKAGE_PATH_$(3)) \
 	    $$(subst @,,$$(STAGE$(1)_T_$(2)_H_$(3))) -o $$@ $$< --test \
 		-L "$$(RT_OUTPUT_DIR_$(2))" \
-		-L "$$(LLVM_LIBDIR_$(2))" \
+		$$(LLVM_LIBDIR_RUSTFLAGS_$(2)) \
 		$$(RUSTFLAGS_$(4))
 
 endef