about summary refs log tree commit diff
diff options
context:
space:
mode:
authorOliver Schneider <github35764891676564198441@oli-obk.de>2018-07-24 20:47:53 +0200
committerOliver Schneider <github35764891676564198441@oli-obk.de>2018-07-25 14:09:06 +0200
commit01d4cd5aaecef3f944812c396f58c56fcc1449ba (patch)
tree945cb01f21e700fd86ca9098f5c68b34b9a7c79a
parent13985724033467ab86da9136c43fe242092b294e (diff)
downloadrust-01d4cd5aaecef3f944812c396f58c56fcc1449ba.tar.gz
rust-01d4cd5aaecef3f944812c396f58c56fcc1449ba.zip
0-length arrays can even be mutably promoted
-rw-r--r--src/librustc_mir/borrow_check/mod.rs8
-rw-r--r--src/test/ui/const-eval/promote_mutable_zst_mir_borrowck.rs17
2 files changed, 23 insertions, 2 deletions
diff --git a/src/librustc_mir/borrow_check/mod.rs b/src/librustc_mir/borrow_check/mod.rs
index b3d7337cffe..84e3ecd5096 100644
--- a/src/librustc_mir/borrow_check/mod.rs
+++ b/src/librustc_mir/borrow_check/mod.rs
@@ -1864,8 +1864,12 @@ impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {
                     }),
                 }
             }
-            // promoteds may never be mutated
-            Place::Promoted(_) => bug!("encountered mutable promoted"),
+            // The rules for promotion are made by `qualify_consts`, there wouldn't even be a
+            // `Place::Promoted` if the promotion weren't 100% legal. So we just forward this
+            Place::Promoted(_) => Ok(RootPlace {
+                place,
+                is_local_mutation_allowed,
+            }),
             Place::Static(ref static_) => {
                 if self.tcx.is_static(static_.def_id) != Some(hir::Mutability::MutMutable) {
                     Err(place)
diff --git a/src/test/ui/const-eval/promote_mutable_zst_mir_borrowck.rs b/src/test/ui/const-eval/promote_mutable_zst_mir_borrowck.rs
new file mode 100644
index 00000000000..922d7d3ab96
--- /dev/null
+++ b/src/test/ui/const-eval/promote_mutable_zst_mir_borrowck.rs
@@ -0,0 +1,17 @@
+// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-pass
+
+#![feature(nll)]
+
+pub fn main() {
+    let y: &'static mut [u8; 0] = &mut [];
+}