diff options
| author | Matthias Krüger <476013+matthiaskrgr@users.noreply.github.com> | 2025-05-31 18:51:51 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-31 18:51:51 +0200 |
| commit | 0254c67b1aa26a9eb64ee919a5a70098bfebd2f9 (patch) | |
| tree | 1492921aca0410a59c6794ba1b0285baf6c88a96 | |
| parent | 04641b14a3b94fcbe66da1d88fcde0b8ae6203f9 (diff) | |
| parent | 7e9aee773ae3d58aeee403a5e0900b034849f2e7 (diff) | |
| download | rust-0254c67b1aa26a9eb64ee919a5a70098bfebd2f9.tar.gz rust-0254c67b1aa26a9eb64ee919a5a70098bfebd2f9.zip | |
Rollup merge of #141815 - mati865:mingw-aarch64-frame-pointers, r=workingjubilee
Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows Based on https://github.com/rust-lang/rust/pull/140828 I don't have AArch64 Windows to test it, but I trust LLVM to handle it well.
| -rw-r--r-- | compiler/rustc_target/src/spec/targets/aarch64_pc_windows_gnullvm.rs | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/compiler/rustc_target/src/spec/targets/aarch64_pc_windows_gnullvm.rs b/compiler/rustc_target/src/spec/targets/aarch64_pc_windows_gnullvm.rs index a8b133d19bb..eee668cc67e 100644 --- a/compiler/rustc_target/src/spec/targets/aarch64_pc_windows_gnullvm.rs +++ b/compiler/rustc_target/src/spec/targets/aarch64_pc_windows_gnullvm.rs @@ -1,4 +1,4 @@ -use crate::spec::{Target, TargetMetadata, base}; +use crate::spec::{FramePointer, Target, TargetMetadata, base}; pub(crate) fn target() -> Target { let mut base = base::windows_gnullvm::opts(); @@ -6,6 +6,12 @@ pub(crate) fn target() -> Target { base.features = "+v8a,+neon,+fp-armv8".into(); base.linker = Some("aarch64-w64-mingw32-clang".into()); + // Microsoft recommends enabling frame pointers on Arm64 Windows. + // From https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#integer-registers + // "The frame pointer (x29) is required for compatibility with fast stack walking used by ETW + // and other services. It must point to the previous {x29, x30} pair on the stack." + base.frame_pointer = FramePointer::NonLeaf; + Target { llvm_target: "aarch64-pc-windows-gnu".into(), metadata: TargetMetadata { |