diff options
| author | Mazdak Farrokhzad <twingoow@gmail.com> | 2019-03-29 02:40:57 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-03-29 02:40:57 +0100 |
| commit | 0494cffd3ca975aaeb58230cf7904ece05836133 (patch) | |
| tree | 9c5d04734e9346a741533cc3a89fe7be91d28943 | |
| parent | bf3e6c63d6b1a6efec0a65e22fbe9b9013d2705e (diff) | |
| parent | 8dbae794b0683668d1b46d2c319ab36dcd9bd96d (diff) | |
| download | rust-0494cffd3ca975aaeb58230cf7904ece05836133.tar.gz rust-0494cffd3ca975aaeb58230cf7904ece05836133.zip | |
Rollup merge of #59498 - mbrubeck:write_all, r=Centril
Use 'write_all' instead of 'write' in example code Using `write` without looping and checking the result can cause silent data loss. Example code should use `write_all` so that people don't copy this pattern. (Of course this does not include example code for docs that are specifically about the `write` method.)
| -rw-r--r-- | src/libstd/io/mod.rs | 2 | ||||
| -rw-r--r-- | src/libstd/io/stdio.rs | 12 |
2 files changed, 7 insertions, 7 deletions
diff --git a/src/libstd/io/mod.rs b/src/libstd/io/mod.rs index 7147b641e47..14c850b6b05 100644 --- a/src/libstd/io/mod.rs +++ b/src/libstd/io/mod.rs @@ -1151,7 +1151,7 @@ pub trait Write { /// fn main() -> std::io::Result<()> { /// let mut buffer = BufWriter::new(File::create("foo.txt")?); /// - /// buffer.write(b"some bytes")?; + /// buffer.write_all(b"some bytes")?; /// buffer.flush()?; /// Ok(()) /// } diff --git a/src/libstd/io/stdio.rs b/src/libstd/io/stdio.rs index d53a294fa6a..7e151041a9e 100644 --- a/src/libstd/io/stdio.rs +++ b/src/libstd/io/stdio.rs @@ -405,7 +405,7 @@ pub struct StdoutLock<'a> { /// use std::io::{self, Write}; /// /// fn main() -> io::Result<()> { -/// io::stdout().write(b"hello world")?; +/// io::stdout().write_all(b"hello world")?; /// /// Ok(()) /// } @@ -420,7 +420,7 @@ pub struct StdoutLock<'a> { /// let stdout = io::stdout(); /// let mut handle = stdout.lock(); /// -/// handle.write(b"hello world")?; +/// handle.write_all(b"hello world")?; /// /// Ok(()) /// } @@ -460,7 +460,7 @@ impl Stdout { /// let stdout = io::stdout(); /// let mut handle = stdout.lock(); /// - /// handle.write(b"hello world")?; + /// handle.write_all(b"hello world")?; /// /// Ok(()) /// } @@ -558,7 +558,7 @@ pub struct StderrLock<'a> { /// use std::io::{self, Write}; /// /// fn main() -> io::Result<()> { -/// io::stderr().write(b"hello world")?; +/// io::stderr().write_all(b"hello world")?; /// /// Ok(()) /// } @@ -573,7 +573,7 @@ pub struct StderrLock<'a> { /// let stderr = io::stderr(); /// let mut handle = stderr.lock(); /// -/// handle.write(b"hello world")?; +/// handle.write_all(b"hello world")?; /// /// Ok(()) /// } @@ -613,7 +613,7 @@ impl Stderr { /// let stderr = io::stderr(); /// let mut handle = stderr.lock(); /// - /// handle.write(b"hello world")?; + /// handle.write_all(b"hello world")?; /// /// Ok(()) /// } |
