about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMax Heller <max.a.heller@gmail.com>2023-08-06 12:04:33 -0400
committerMax Heller <max.a.heller@gmail.com>2023-08-06 12:04:33 -0400
commit0c21d8538c1c2f6634c4e3a426e9f2bfdf27f624 (patch)
tree328b6480ede93f68d4b711d40d25c4ed94670dc7
parentbb9d8229b87163d073bc1329bdc4f42676bead07 (diff)
downloadrust-0c21d8538c1c2f6634c4e3a426e9f2bfdf27f624.tar.gz
rust-0c21d8538c1c2f6634c4e3a426e9f2bfdf27f624.zip
FIXME
-rw-r--r--crates/ide-completion/src/context/analysis.rs3
1 files changed, 3 insertions, 0 deletions
diff --git a/crates/ide-completion/src/context/analysis.rs b/crates/ide-completion/src/context/analysis.rs
index 87380067e87..2064ae34dd9 100644
--- a/crates/ide-completion/src/context/analysis.rs
+++ b/crates/ide-completion/src/context/analysis.rs
@@ -816,6 +816,9 @@ fn classify_name_ref(
                 // are often omitted, ignore them for the purposes of matching the argument with
                 // its parameter unless a lifetime argument is provided explicitly. That is, for
                 // `struct S<'a, 'b, T>`, match `S::<$0>` to `T` and `S::<'a, $0, _>` to `'b`.
+                // FIXME: This operates on the syntax tree and will produce incorrect results when
+                // generic parameters are disabled by `#[cfg]` directives. It should operate on the
+                // HIR, but the functionality necessary to do so is not exposed at the moment.
                 let mut explicit_lifetime_arg = false;
                 let arg_idx = arg
                     .syntax()