diff options
| author | Perry Fraser <perry@frasers.org> | 2017-07-18 22:06:24 -0400 |
|---|---|---|
| committer | Perry Fraser <perry@frasers.org> | 2017-07-18 22:06:24 -0400 |
| commit | 0fcb4fca19bc566afda5a7bbda5d6759905497c2 (patch) | |
| tree | 2915d7124e502514f83c4af312dd5feccd9e4f2f | |
| parent | 83c659ef655b1f740777f83eb415fd7ebe5a3fe5 (diff) | |
| download | rust-0fcb4fca19bc566afda5a7bbda5d6759905497c2.tar.gz rust-0fcb4fca19bc566afda5a7bbda5d6759905497c2.zip | |
Change the error message for multiple unused print params
| -rw-r--r-- | src/libsyntax_ext/format.rs | 8 | ||||
| -rw-r--r-- | src/test/ui/macros/format-foreign.stderr | 21 |
2 files changed, 11 insertions, 18 deletions
diff --git a/src/libsyntax_ext/format.rs b/src/libsyntax_ext/format.rs index 144d1930df9..7351377e771 100644 --- a/src/libsyntax_ext/format.rs +++ b/src/libsyntax_ext/format.rs @@ -798,9 +798,13 @@ pub fn expand_preparsed_format_args(ecx: &mut ExtCtxt, } else { let mut diag = cx.ecx.struct_span_err(cx.fmtsp, "multiple unused formatting arguments"); - for (sp, msg) in errs { - diag.span_note(sp, msg); + + // Ignoring message, as it gets repetitive + // Then use MultiSpan to not clutter up errors + for (sp, _) in errs { + diag.span_label(sp, "unused"); } + diag } }; diff --git a/src/test/ui/macros/format-foreign.stderr b/src/test/ui/macros/format-foreign.stderr index 0283052a89f..00469b5f799 100644 --- a/src/test/ui/macros/format-foreign.stderr +++ b/src/test/ui/macros/format-foreign.stderr @@ -2,23 +2,12 @@ error: multiple unused formatting arguments --> $DIR/format-foreign.rs:12:5 | 12 | println!("%.*3$s %s!/n", "Hello,", "World", 4); - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + | ^^^^^^^^^^^^^^^^^^^^^^^^^--------^^-------^^-^^ + | | | | + | | | unused + | | unused + | unused | -note: argument never used - --> $DIR/format-foreign.rs:12:30 - | -12 | println!("%.*3$s %s!/n", "Hello,", "World", 4); - | ^^^^^^^^ -note: argument never used - --> $DIR/format-foreign.rs:12:40 - | -12 | println!("%.*3$s %s!/n", "Hello,", "World", 4); - | ^^^^^^^ -note: argument never used - --> $DIR/format-foreign.rs:12:49 - | -12 | println!("%.*3$s %s!/n", "Hello,", "World", 4); - | ^ = help: `%.*3$s` should be written as `{:.2$}` = help: `%s` should be written as `{}` = note: printf formatting not supported; see the documentation for `std::fmt` |