diff options
| author | Stuart Cook <Zalathar@users.noreply.github.com> | 2025-09-04 10:02:06 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-04 10:02:06 +1000 |
| commit | 11ea57363b37577103181cd5910a63105651335a (patch) | |
| tree | 9ca97411f671c1231294d67450352f886045d114 | |
| parent | c81fffa9a36cbebb72379a5fa69c753d5b77c271 (diff) | |
| parent | 2d20ee73a84c03907610f652d7f9d5454b070c33 (diff) | |
Rollup merge of #146172 - RalfJung:triagebot-keyword-mentions, r=Urgau
triagebot: configure some pings when certain attributes are used Let's try this out in practice. :) Cc `@rust-lang/miri` `@rust-lang/wg-const-eval` `@Urgau`
| -rw-r--r-- | src/tools/tidy/src/triagebot.rs | 7 | ||||
| -rw-r--r-- | triagebot.toml | 15 |
2 files changed, 21 insertions, 1 deletions
diff --git a/src/tools/tidy/src/triagebot.rs b/src/tools/tidy/src/triagebot.rs index 305a0b4d264..6f25ed616fa 100644 --- a/src/tools/tidy/src/triagebot.rs +++ b/src/tools/tidy/src/triagebot.rs @@ -19,7 +19,12 @@ pub fn check(path: &Path, bad: &mut bool) { // Check [mentions."*"] sections, i.e. [mentions."compiler/rustc_const_eval/src/"] if let Some(Value::Table(mentions)) = config.get("mentions") { - for path_str in mentions.keys() { + for (entry_key, entry_val) in mentions.iter() { + // If the type is set to something other than "filename", then this is not a path. + if entry_val.get("type").is_some_and(|t| t.as_str().unwrap_or_default() != "filename") { + continue; + } + let path_str = entry_key; // Remove quotes from the path let clean_path = path_str.trim_matches('"'); let full_path = path.join(clean_path); diff --git a/triagebot.toml b/triagebot.toml index cf2e95203fa..fd6329de923 100644 --- a/triagebot.toml +++ b/triagebot.toml @@ -1306,6 +1306,21 @@ cc = ["@m-ou-se"] [mentions."compiler/rustc_ast_lowering/src/format.rs"] cc = ["@m-ou-se"] +[mentions."#[miri::intrinsic_fallback_is_spec]"] +type = "content" +message = """ +`#[miri::intrinsic_fallback_is_spec]` must only be used if the function actively checks for all UB cases, +and explores the possible non-determinism of the intrinsic. +""" +cc = ["@rust-lang/miri"] +[mentions."#[rustc_allow_const_fn_unstable]"] +type = "content" +message = """ +`#[rustc_allow_const_fn_unstable]` needs careful audit to avoid accidentally exposing unstable +implementation details on stable. +""" +cc = ["@rust-lang/wg-const-eval"] + # ------------------------------------------------------------------------------ # PR assignments |
