about summary refs log tree commit diff
diff options
context:
space:
mode:
authorYuki Okushi <huyuumi.dev@gmail.com>2020-07-22 05:23:55 +0900
committerYuki Okushi <huyuumi.dev@gmail.com>2020-07-22 05:23:55 +0900
commit142a273441d1cf2039bd2857ee57cfa402e2a3f7 (patch)
tree3bcdafed23f2bbbc60bcbf637f810da7cf92c49e
parent61e3d8a55c760a543659d270940c25c8180dc637 (diff)
downloadrust-142a273441d1cf2039bd2857ee57cfa402e2a3f7.tar.gz
rust-142a273441d1cf2039bd2857ee57cfa402e2a3f7.zip
Use `(std::)f64::EPSILON` in the examples as suggested in the lints
-rw-r--r--clippy_lints/src/misc.rs10
1 files changed, 7 insertions, 3 deletions
diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs
index fc10e5077b8..26a1c32b6b3 100644
--- a/clippy_lints/src/misc.rs
+++ b/clippy_lints/src/misc.rs
@@ -99,7 +99,9 @@ declare_clippy_lint! {
     /// if y != x {} // where both are floats
     ///
     /// // Good
-    /// let error = 0.01f64; // Use an epsilon for comparison
+    /// let error = f64::EPSILON; // Use an epsilon for comparison
+    /// // Or, if Rust <= 1.42, use `std::f64::EPSILON` constant instead.
+    /// // let error = std::f64::EPSILON;
     /// if (y - 1.23f64).abs() < error { }
     /// if (y - x).abs() > error { }
     /// ```
@@ -237,10 +239,12 @@ declare_clippy_lint! {
     /// const ONE: f64 = 1.00;
     ///
     /// // Bad
-    /// if x == ONE { }  // where both are floats
+    /// if x == ONE { } // where both are floats
     ///
     /// // Good
-    /// let error = 0.1f64; // Use an epsilon for comparison
+    /// let error = f64::EPSILON; // Use an epsilon for comparison
+    /// // Or, if Rust <= 1.42, use `std::f64::EPSILON` constant instead.
+    /// // let error = std::f64::EPSILON;
     /// if (x - ONE).abs() < error { }
     /// ```
     pub FLOAT_CMP_CONST,